Re: [PATCH 02/11] cli: Separate current and deprecated format version

diff --git a/fd/180af59a284a80cacf2c71951dc3bca3db58ef b/fd/180af59a284a80cacf2c71951dc3bca3db58ef
new file mode 100644 (file)
index 0000000..c55e0dd
--- /dev/null
+++ b/fd/180af59a284a80cacf2c71951dc3bca3db58ef
@@ -0,0 +1,113 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 24E2B431FAF\r
+       for <notmuch@notmuchmail.org>; Wed,  9 Oct 2013 07:09:02 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id pPb7refKTZVU for <notmuch@notmuchmail.org>;\r
+       Wed,  9 Oct 2013 07:08:56 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-8.mit.edu (dmz-mailsec-scanner-8.mit.edu\r
+       [18.7.68.37])\r
+       by olra.theworths.org (Postfix) with ESMTP id CB001431FAE\r
+       for <notmuch@notmuchmail.org>; Wed,  9 Oct 2013 07:08:55 -0700 (PDT)\r
+X-AuditID: 12074425-b7f1c8e0000009c7-0f-525563778bde\r
+Received: from mailhub-auth-4.mit.edu ( [18.7.62.39])\r
+       by dmz-mailsec-scanner-8.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id 8B.9A.02503.77365525; Wed,  9 Oct 2013 10:08:55 -0400 (EDT)\r
+Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11])\r
+       by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id r99E8rCk002739; \r
+       Wed, 9 Oct 2013 10:08:54 -0400\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+       (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id r99E8orr018982\r
+       (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);\r
+       Wed, 9 Oct 2013 10:08:52 -0400\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)\r
+       (envelope-from <amdragon@MIT.EDU>)\r
+       id 1VTuRW-0004yN-JH; Wed, 09 Oct 2013 10:08:50 -0400\r
+Date: Wed, 9 Oct 2013 10:08:50 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Mark Walters <markwalters1009@gmail.com>\r
+Subject: Re: [PATCH 02/11] cli: Separate current and deprecated format version\r
+Message-ID: <20131009140850.GN21611@mit.edu>\r
+References: <1381185201-25197-1-git-send-email-amdragon@mit.edu>\r
+       <1381185201-25197-3-git-send-email-amdragon@mit.edu>\r
+       <87li24qmvj.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <87li24qmvj.fsf@qmul.ac.uk>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFmpkleLIzCtJLcpLzFFi42IRYrdT1y1PDg0y6HvCbrF6Lo/F9ZszmR2Y\r
+       PHbOusvu8WzVLeYApigum5TUnMyy1CJ9uwSujKmvLjMV3OeqODTtB2sD41aOLkZODgkBE4n/\r
+       B16zQthiEhfurWcDsYUE9jFKXJ6X1cXIBWRvYJRY83M7E0TiFJPE9dmVEIkljBLvj6xgBkmw\r
+       CKhITHt3gxHEZhPQkNi2fzmYLSKgI3H70AJ2EJtZQFri2+9msEHCAn4Sh168BevlBap5+L2B\r
+       GWLoVEaJW18bGCESghInZz5hgWjWkrjx7yVQMwfYoOX/OEBMTqBd+1osQCpEgU6YcnIb2wRG\r
+       oVlImmchaZ6F0LyAkXkVo2xKbpVubmJmTnFqsm5xcmJeXmqRroVebmaJXmpK6SZGcEi7qO5g\r
+       nHBI6RCjAAejEg9vB29IkBBrYllxZe4hRkkOJiVR3u0xoUFCfEn5KZUZicUZ8UWlOanFhxgl\r
+       OJiVRHiNo4FyvCmJlVWpRfkwKWkOFiVx3lsc9kFCAumJJanZqakFqUUwWRkODiUJ3tWJQI2C\r
+       RanpqRVpmTklCGkmDk6Q4TxAw6+D1PAWFyTmFmemQ+RPMSpKifMygCQEQBIZpXlwvbCU84pR\r
+       HOgVYd6bIFU8wHQF1/0KaDAT0ODt30NABpckIqSkGhhZusU0z7s9NcrqW7hwwiTPZyEbhO9P\r
+       Uj60/Ubzub9TpO76PW7dfSLDzlsvx708yDr4xQ87N98lq9bNL+2e4OHzslbTPs/KTfCv88oA\r
+       +U9VBurrFjba7npTxV418ZnpQtfbJ/6+VlR+/4pxVU14zaIzBUcmqjOJPZz46bpG7eXSjU8f\r
+       zfvQu81PiaU4I9FQi7moOBEAXQkHaRQDAAA=\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 09 Oct 2013 14:09:02 -0000\r
+\r
+Quoth Mark Walters on Oct 08 at  7:48 am:\r
+> On Mon, 07 Oct 2013, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> > Previously, the CLI would print a deprecation warning if a client\r
+> > requested any format version other than the current one.  However, if\r
+> > we add fields that are backwards-compatible, but want clients to be\r
+> > able to depend on, we need to bump the version, but that doesn't make\r
+> > the older version deprecated.\r
+> >\r
+> > Hence, separate out the "minimum active" version and only print a\r
+> > warning for requests below this version number.\r
+> > ---\r
+> >  notmuch-client.h | 5 +++++\r
+> >  notmuch.c        | 2 +-\r
+> >  2 files changed, 6 insertions(+), 1 deletion(-)\r
+> >\r
+> > diff --git a/notmuch-client.h b/notmuch-client.h\r
+> > index afb0ddf..8d986f4 100644\r
+> > --- a/notmuch-client.h\r
+> > +++ b/notmuch-client.h\r
+> > @@ -142,6 +142,11 @@ chomp_newline (char *str)\r
+> >  /* The minimum supported structured output format version.  Requests\r
+> >   * for format versions below this will return an error. */\r
+> >  #define NOTMUCH_FORMAT_MIN 1\r
+> > +/* The minimum non-deprecated structured output format version.\r
+> > + * Requests for format versions below this will print a stern warning.\r
+> > + * Must be >= NOTMUCH_FORMAT_MIN and < NOTMUCH_FORMAT_CUR.\r
+> > + */\r
+> \r
+> Should this be <= NOTMUCH_FORMAT_CUR ?\r
+\r
+Yes.\r
+\r
+> Best wishes\r
+> \r
+> Mark\r