Re: [PATCH] lib, ruby: make use of -Wl,--no-undefined configurable

diff --git a/34/5964ae4c1e3d3f0042aa55aef7c6281d3814a6 b/34/5964ae4c1e3d3f0042aa55aef7c6281d3814a6
new file mode 100644 (file)
index 0000000..0f7d3a2
--- /dev/null
+++ b/34/5964ae4c1e3d3f0042aa55aef7c6281d3814a6
@@ -0,0 +1,98 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id A219D6DE0243\r
+ for <notmuch@notmuchmail.org>; Tue, 16 Jun 2015 23:25:48 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.185\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.185 tagged_above=-999 required=5 tests=[AWL=0.185]\r
+ autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id ehHTDp91GSk4 for <notmuch@notmuchmail.org>;\r
+ Tue, 16 Jun 2015 23:25:46 -0700 (PDT)\r
+Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net\r
+ [87.98.215.224])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id 88F1D6DE01F5\r
+ for <notmuch@notmuchmail.org>; Tue, 16 Jun 2015 23:25:46 -0700 (PDT)\r
+Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim\r
+ 4.80) (envelope-from <david@tethera.net>)\r
+ id 1Z56lJ-0003uv-Va; Wed, 17 Jun 2015 06:23:49 +0000\r
+Received: (nullmailer pid 12660 invoked by uid 1000); Wed, 17 Jun 2015\r
+ 06:23:31 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Jinwoo Lee <jinwoo68@gmail.com>, Tomi Ollila <tomi.ollila@iki.fi>,\r
+ notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] lib, ruby: make use of -Wl,--no-undefined configurable\r
+In-Reply-To: <yq65y4jjjk2h.fsf@jinwoo-macbookair.roam.corp.google.com>\r
+References: <1433142542-2307-3-git-send-email-david@tethera.net>\r
+ <1434261524-14139-1-git-send-email-david@tethera.net>\r
+ <yq65a8w2u7yv.fsf@jinwoo-macbookair.roam.corp.google.com>\r
+ <87r3peye4q.fsf@maritornes.cs.unb.ca>\r
+ <yq657fr6tj64.fsf@jinwoo-macbookair.roam.corp.google.com>\r
+ <87oaki3zrh.fsf@maritornes.cs.unb.ca>\r
+ <yq654mm9tyie.fsf@jinwoo-macbookair.roam.corp.google.com>\r
+ <m2bnghe3ar.fsf@guru.guru-group.fi>\r
+ <yq65wpz463rd.fsf@jinwoo-macbookair.roam.corp.google.com>\r
+ <m2lhfjwm4x.fsf@guru.guru-group.fi>\r
+ <yq65y4jjjk2h.fsf@jinwoo-macbookair.roam.corp.google.com>\r
+User-Agent: Notmuch/0.20.1+21~g4e79903 (http://notmuchmail.org) Emacs/24.4.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Wed, 17 Jun 2015 08:23:31 +0200\r
+Message-ID: <87vbem26qk.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.18\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 17 Jun 2015 06:25:48 -0000\r
+\r
+Jinwoo Lee <jinwoo68@gmail.com> writes:\r
+>  FAIL   PATH is set to build directory\r
+>      --- T000-basic.11.expected      2015-06-16 23:40:30.000000000 +0000\r
+>      +++ T000-basic.11.output        2015-06-16 23:40:30.000000000 +0000\r
+>      @@ -1 +1 @@\r
+>      -/Users/jinwoo/Box Sync/personal/project/notmuch\r
+>      +\r
+> usage: dirname path\r
+\r
+This failure is because of spaces in your pathname. It might be simpler\r
+to run in a different directory rather than fix all the problems this\r
+causes in the test suite.\r
+\r
+>  FAIL   notmuch is compiled with debugging symbols\r
+>      --- T000-basic.12.expected      2015-06-16 23:40:30.000000000 +0000\r
+>      +++ T000-basic.12.output        2015-06-16 23:40:30.000000000 +0000\r
+>      @@ -1 +1 @@\r
+>      -1\r
+>      +0\r
+> ./T000-basic.sh: line 95: readelf: command not found\r
+\r
+This test, as it says, is testing if notmuch was compiled with debugging\r
+symbols.  Rather than yet another special case for mac, I'd be curious\r
+if there is a portable test for this (perhaps using nm?). In any case,\r
+this one test failing should not be fatal.\r
+\r
+> ./test-lib.sh: line 1062: $test_results_path: ambiguous redirect\r
+> ./test-lib.sh: line 1063: $test_results_path: ambiguous redirect\r
+> ./test-lib.sh: line 1064: $test_results_path: ambiguous redirect\r
+> ./test-lib.sh: line 1065: $test_results_path: ambiguous redirect\r
+> ./test-lib.sh: line 1066: $test_results_path: ambiguous redirect\r
+> ./test-lib.sh: line 1067: $test_results_path: ambiguous redirect\r
+\r
+At a guess, this again has to do with spaces in the pathname. Maybe this\r
+is fixable with more quoting, but it's really independent of mac vs\r
+gnu/linux. In this instance it looks like quoting "test_results_path"\r
+would help.\r