Re: [PATCH] emacs: bugfix unquoted symbol

diff --git a/ca/659599986fd88c52cc04dc6c0fc64365c2f349 b/ca/659599986fd88c52cc04dc6c0fc64365c2f349
new file mode 100644 (file)
index 0000000..d3e347a
--- /dev/null
+++ b/ca/659599986fd88c52cc04dc6c0fc64365c2f349
@@ -0,0 +1,98 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 244D3431FAF\r
+       for <notmuch@notmuchmail.org>; Sun, 15 Sep 2013 00:32:39 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id kUi2rATS7JUO for <notmuch@notmuchmail.org>;\r
+       Sun, 15 Sep 2013 00:32:31 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 5DCBB431FAE\r
+       for <notmuch@notmuchmail.org>; Sun, 15 Sep 2013 00:32:31 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 2EEDB1000B2;\r
+       Sun, 15 Sep 2013 10:32:25 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: bugfix unquoted symbol\r
+In-Reply-To: <1379189827-21363-1-git-send-email-markwalters1009@gmail.com>\r
+References: <1379189827-21363-1-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.16+77~g2561895 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sun, 15 Sep 2013 10:32:24 +0300\r
+Message-ID: <m21u4qa6bb.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 15 Sep 2013 07:32:39 -0000\r
+\r
+On Sat, Sep 14 2013, Mark Walters <markwalters1009@gmail.com> wrote:\r
+\r
+> In the recent changes for search order handling the default-value of\r
+> notmuch-search-oldest-first was used. However, default-value needs a\r
+> symbol so the symbol-name needs to be quoted.\r
+>\r
+> This missing quote was causing strange sort-orders in some cases.\r
+> ---\r
+>\r
+> I think this is clearly correct (and what was intended) and it seems\r
+> to work as expected.\r
+\r
+Marked ready.\r
+\r
+>\r
+> Best wishes\r
+>\r
+> Mark\r
+>\r
+\r
+Tomi\r
+\r
+>\r
+>\r
+>\r
+>  emacs/notmuch.el |    2 +-\r
+>  1 files changed, 1 insertions(+), 1 deletions(-)\r
+>\r
+> diff --git a/emacs/notmuch.el b/emacs/notmuch.el\r
+> index 4de6229..0ff248b 100644\r
+> --- a/emacs/notmuch.el\r
+> +++ b/emacs/notmuch.el\r
+> @@ -888,7 +888,7 @@ the configured default sort order."\r
+>      nil\r
+>      ;; Use the default search order (if we're doing a search from a\r
+>      ;; search buffer, ignore any buffer-local overrides)\r
+> -    (default-value notmuch-search-oldest-first)))\r
+> +    (default-value 'notmuch-search-oldest-first)))\r
+>  \r
+>    (let* ((query (or query (notmuch-read-query "Notmuch search: ")))\r
+>       (buffer (get-buffer-create (notmuch-search-buffer-title query))))\r
+> -- \r
+> 1.7.9.1\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r