[v2 0/3] Avoid empty thread names if possible

diff --git a/98/2b1b43b3aa470128c09458f92c599f83e91611 b/98/2b1b43b3aa470128c09458f92c599f83e91611
new file mode 100644 (file)
index 0000000..8dea124
--- /dev/null
+++ b/98/2b1b43b3aa470128c09458f92c599f83e91611
@@ -0,0 +1,77 @@
+Return-Path: <prvs=372b3579b=jrosenthal@jhu.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1ED4A431FB6\r
+       for <notmuch@notmuchmail.org>; Wed, 29 Oct 2014 14:52:22 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.3\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id Nh5q63cbOL-K for <notmuch@notmuchmail.org>;\r
+       Wed, 29 Oct 2014 14:52:14 -0700 (PDT)\r
+X-Greylist: delayed 3602 seconds by postgrey-1.32 at olra;\r
+       Wed, 29 Oct 2014 14:52:14 PDT\r
+Received: from smtpauth.johnshopkins.edu (smtpauth.johnshopkins.edu\r
+       [162.129.8.150]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 456E1431FC2\r
+       for <notmuch@notmuchmail.org>; Wed, 29 Oct 2014 14:52:14 -0700 (PDT)\r
+X-IronPort-AV: E=Sophos;i="5.07,279,1413259200"; d="scan'208";a="109648845"\r
+Received: from guppy.hwcampus.jhu.edu (HELO localhost) ([10.161.32.234])\r
+       by ipex0.johnshopkins.edu with ESMTP/TLS/AES128-SHA;\r
+       29 Oct 2014 16:52:10 -0400\r
+From: Jesse Rosenthal <jrosenthal@jhu.edu>\r
+To: notmuch@notmuchmail.org\r
+Subject: [v2 0/3] Avoid empty thread names if possible\r
+Date: Wed, 29 Oct 2014 16:51:42 -0400\r
+Message-Id: <1414615905-22554-1-git-send-email-jrosenthal@jhu.edu>\r
+X-Mailer: git-send-email 2.1.2\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 29 Oct 2014 21:52:22 -0000\r
+\r
+This is the second go at avoiding empty thread names. The differences\r
+from the first version are:\r
+\r
+  * Compare empty strings by checking for '\0' in first character\r
+    (using a macro) as suggested by Tomi Ollila.\r
+\r
+  * Make sure that threads are titled correctly regardless of sorting\r
+    order. In this version we only add change the subject in\r
+    _thread_set_subject_from_message if the subject (after cleaning\r
+    "Re:") is non-empty. This is necessary for\r
+    oldest-first. newest-first works the same as before.\r
+\r
+  * Add tests. This means that we have to force the test suite to\r
+    accept a non-empty header. I called the dummy subject\r
+    `@FORCE_EMPTY` to differentiate from a normal string, but not\r
+    invoke any special shell-ness. \r
+\r
+Jesse Rosenthal (3):\r
+  thread.cc: Avoid empty thread names if possible.\r
+  test-lib: Add dummy subject to force empty subject\r
+  thread-naming test: Test empty subject names.\r
+\r
+ lib/thread.cc              | 16 +++++++++++-----\r
+ test/T200-thread-naming.sh | 32 ++++++++++++++++++++++++++++++++\r
+ test/test-lib.sh           |  2 ++\r
+ 3 files changed, 45 insertions(+), 5 deletions(-)\r
+\r
+-- \r
+2.1.2\r
+\r