Re: [PATCH 0/2] Improve message threading

diff --git a/40/037ae6194ccc0700053523e7fdde48165adfac b/40/037ae6194ccc0700053523e7fdde48165adfac
new file mode 100644 (file)
index 0000000..fe7e209
--- /dev/null
+++ b/40/037ae6194ccc0700053523e7fdde48165adfac
@@ -0,0 +1,92 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id F2FF0431FAF\r
+       for <notmuch@notmuchmail.org>; Sun, 10 Aug 2014 12:50:11 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 7+UhkrC2xbnQ for <notmuch@notmuchmail.org>;\r
+       Sun, 10 Aug 2014 12:50:02 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 7DB71431FAE\r
+       for <notmuch@notmuchmail.org>; Sun, 10 Aug 2014 12:50:02 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 30459100033;\r
+       Sun, 10 Aug 2014 22:49:46 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 0/2] Improve message threading\r
+In-Reply-To: <1401113157-32454-1-git-send-email-sojkam1@fel.cvut.cz>\r
+References: <1401113157-32454-1-git-send-email-sojkam1@fel.cvut.cz>\r
+User-Agent: Notmuch/0.18.1+25~gdaf4b6f (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sun, 10 Aug 2014 22:49:45 +0300\r
+Message-ID: <m2fvh4azvq.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 10 Aug 2014 19:50:12 -0000\r
+\r
+On Mon, May 26 2014, Michal Sojka <sojkam1@fel.cvut.cz> wrote:\r
+\r
+> Hi all,\r
+>\r
+> I noticed that in certain situations notmuch does not reconstruct\r
+> thread structure correctly. The fix was quite trivial - see the\r
+> patches.\r
+>\r
+> The patch fixes my problem, however, as I learnt from the thread\r
+> around id:87oazwjq1e.fsf@yoom.home.cworth.org, there are more problems\r
+> in this code. I think that my problem is orthogonal to what was\r
+> discussed there.\r
+>\r
+> The patch does not break any existing text (except two in\r
+> T460-emacs-tree.sh, which fail even with 0.18 on my system).\r
+>\r
+> Cheers,\r
+> -Michal\r
+\r
+This series looks good to me, and patch 2/2 fixes the borken test\r
+introduced in patch 1/2 -- i.e. the fix is clear, test is somewhat\r
+tedious to be parsed by a human ;D\r
+\r
+Tomi\r
+\r
+\r
+>\r
+> Michal Sojka (2):\r
+>   Add test for incorrect threading of messages\r
+>   Make parsing of References and In-Reply-To header less error prone\r
+>\r
+>  lib/database.cc             | 15 ++++++---------\r
+>  test/T510-thread-replies.sh | 27 +++++++++++++++++++++++++++\r
+>  2 files changed, 33 insertions(+), 9 deletions(-)\r
+>\r
+> -- \r
+> 2.0.0.rc2\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r