Re: sort order regression

diff --git a/76/855f53cb6b9a1d3733e79bb5cf3f6cc3e9eda9 b/76/855f53cb6b9a1d3733e79bb5cf3f6cc3e9eda9
new file mode 100644 (file)
index 0000000..40c53ce
--- /dev/null
+++ b/76/855f53cb6b9a1d3733e79bb5cf3f6cc3e9eda9
@@ -0,0 +1,69 @@
+Return-Path: <prvs=jrosenthal=7218428b9@jhu.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 011A94196F3\r
+       for <notmuch@notmuchmail.org>; Thu, 22 Apr 2010 07:21:14 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.301\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.301 tagged_above=-999 required=5\r
+       tests=[BAYES_20=-0.001, RCVD_IN_DNSWL_MED=-2.3] autolearn=ham\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id u6Ve1vJrl0Sr for <notmuch@notmuchmail.org>;\r
+       Thu, 22 Apr 2010 07:21:13 -0700 (PDT)\r
+Received: from ipex3.johnshopkins.edu (ipex3.johnshopkins.edu\r
+       [128.220.161.140])\r
+       by olra.theworths.org (Postfix) with ESMTP id 2C5FC431FC1\r
+       for <notmuch@notmuchmail.org>; Thu, 22 Apr 2010 07:21:13 -0700 (PDT)\r
+X-IronPort-AV: E=Sophos;i="4.52,257,1270440000"; d="scan'208";a="378222304"\r
+Received: from c-69-255-36-229.hsd1.md.comcast.net (HELO lucky)\r
+       ([69.255.36.229])\r
+       by ipex3.johnshopkins.edu with ESMTP/TLS/AES256-SHA;\r
+       22 Apr 2010 10:21:12 -0400\r
+Received: from jkr by lucky with local (Exim 4.69)\r
+       (envelope-from <jrosenthal@jhu.edu>)\r
+       id 1O4xHD-00065P-Cd; Thu, 22 Apr 2010 10:21:11 -0400\r
+From: Jesse Rosenthal <jrosenthal@jhu.edu>\r
+To: cworth@cworth.org, Sebastian Spaeth <Sebastian@SSpaeth.de>,\r
+       Notmuch development list <notmuch@notmuchmail.org>\r
+Subject: Re: sort order regression\r
+In-Reply-To: <87wrvz7ex3.fsf@jhu.edu>\r
+References: <87bpdbmvj0.fsf@SSpaeth.de> <87wrvz7ex3.fsf@jhu.edu>\r
+Date: Thu, 22 Apr 2010 10:21:11 -0400\r
+Message-ID: <87vdbj7elk.fsf@jhu.edu>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 22 Apr 2010 14:21:14 -0000\r
+\r
+On Thu, 22 Apr 2010 10:14:16 -0400, Jesse Rosenthal <jrosenthal@jhu.edu> wrote:\r
+> Just to follow up on this, it seems that the regression comes from the\r
+> fix Carl introduced in 2a1a4f0551 to make his simplification of my patch\r
+> (simplification = 36e4459a3 , my patch = 4971b85641) pass tests. The\r
+> question is whether my original, more complicated version would have\r
+> passed the tests without the regressing fix.\r
+\r
+Okay, I just tested using the current test suite: my patch (4971b85641)\r
+passes all tests, while Carl's simplification fails.\r
+\r
+My suggestion would be to revert both the simplification and the fix to\r
+enable the simplification to pass: (36e4459a3, 2a1a4f0551).\r
+\r
+Should we send reverts as patches?\r
+\r
+Best,\r
+Jesse\r