Re: [PATCH 3/4] emacs: tree: add sort argument to notmuch-tree

diff --git a/c4/cd59ed1b9d2834542ce938469dd95ad468dcaf b/c4/cd59ed1b9d2834542ce938469dd95ad468dcaf
new file mode 100644 (file)
index 0000000..f11d5da
--- /dev/null
+++ b/c4/cd59ed1b9d2834542ce938469dd95ad468dcaf
@@ -0,0 +1,66 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 284396DE1607\r
+ for <notmuch@notmuchmail.org>; Fri, 31 Jul 2015 22:50:54 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.15\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.15 tagged_above=-999 required=5 tests=[AWL=0.150]\r
+ autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id e7hswqroZGvS for <notmuch@notmuchmail.org>;\r
+ Fri, 31 Jul 2015 22:50:52 -0700 (PDT)\r
+Received: from gitolite.debian.net (gitolite.debian.net [87.98.215.224])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id 181C76DE1384\r
+ for <notmuch@notmuchmail.org>; Fri, 31 Jul 2015 22:50:51 -0700 (PDT)\r
+Received: from remotemail by gitolite.debian.net with local (Exim 4.80)\r
+ (envelope-from <david@tethera.net>)\r
+ id 1ZLPff-00047A-QT; Sat, 01 Aug 2015 05:49:23 +0000\r
+Received: (nullmailer pid 21893 invoked by uid 1000); Sat, 01 Aug 2015\r
+ 05:49:09 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 3/4] emacs: tree: add sort argument to notmuch-tree\r
+In-Reply-To: <1435359035-6767-4-git-send-email-markwalters1009@gmail.com>\r
+References: <1435359035-6767-1-git-send-email-markwalters1009@gmail.com>\r
+ <1435359035-6767-4-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Sat, 01 Aug 2015 07:49:09 +0200\r
+Message-ID: <87614zftii.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.18\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 01 Aug 2015 05:50:54 -0000\r
+\r
+Mark Walters <markwalters1009@gmail.com> writes:\r
+\r
+> +  OPEN-TARGET: If TRUE open the target message in the message pane.\r
+> +  OLDEST-FIRST: If TRUE display threads sorted oldest first"\r
+> +  (interactive\r
+> +   (list\r
+> +    ;; Prompt for a query\r
+> +    nil\r
+> +    ;; use default search order\r
+> +    nil nil nil nil (default-value 'notmuch-search-oldest-first)))\r
+\r
+This is probably just me being ignorant, but I had to check the docs for\r
+this usage of interactive. If you think it's tricky also, might be worth\r
+a brief comment.\r
+\r
+Otherwise the series looks ok to me.\r