Re: [PATCH 10/10] test: use emacsclient(1) for Emacs tests

diff --git a/67/f5af2f51d109c609f5405bfbfb7ab8c1405c0f b/67/f5af2f51d109c609f5405bfbfb7ab8c1405c0f
new file mode 100644 (file)
index 0000000..6a1147c
--- /dev/null
+++ b/67/f5af2f51d109c609f5405bfbfb7ab8c1405c0f
@@ -0,0 +1,98 @@
+Return-Path: <cworth@cworth.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 873CC429E55\r
+       for <notmuch@notmuchmail.org>; Tue, 28 Jun 2011 17:15:50 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.01\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.01 tagged_above=-999 required=5\r
+       tests=[T_MIME_NO_TEXT=0.01] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 4WMtmqO4l7JI for <notmuch@notmuchmail.org>;\r
+       Tue, 28 Jun 2011 17:15:49 -0700 (PDT)\r
+Received: from arlo.cworth.org (arlo.cworth.org [50.43.72.2])\r
+       by olra.theworths.org (Postfix) with ESMTP id C50F4429E32\r
+       for <notmuch@notmuchmail.org>; Tue, 28 Jun 2011 17:15:49 -0700 (PDT)\r
+Received: from yoom.home.cworth.org (localhost [127.0.0.1])\r
+       by arlo.cworth.org (Postfix) with ESMTP id B0ECC29A608;\r
+       Tue, 28 Jun 2011 17:15:48 -0700 (PDT)\r
+Received: by yoom.home.cworth.org (Postfix, from userid 1000)\r
+       id A07A72541A8; Tue, 28 Jun 2011 17:15:48 -0700 (PDT)\r
+From: Carl Worth <cworth@cworth.org>\r
+To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 10/10] test: use emacsclient(1) for Emacs tests\r
+In-Reply-To: <87wrg5wq8o.fsf@gmail.com>\r
+References: <1309236311-2162-1-git-send-email-dmitry.kurochkin@gmail.com>\r
+       <1309236311-2162-10-git-send-email-dmitry.kurochkin@gmail.com>\r
+       <87hb798uz7.fsf@yoom.home.cworth.org> <87wrg5wq8o.fsf@gmail.com>\r
+User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.3.1\r
+       (i486-pc-linux-gnu)\r
+Date: Tue, 28 Jun 2011 17:15:42 -0700\r
+Message-ID: <87r56d7as1.fsf@yoom.home.cworth.org>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha1; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 29 Jun 2011 00:15:50 -0000\r
+\r
+--=-=-=\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Wed, 29 Jun 2011 02:22:31 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmai=\r
+l.com> wrote:\r
+> Ouch.  I never saw these.  Do you get these in crypto tests only?\r
+\r
+Yes.\r
+\r
+I just found the bug. The crypto tests use emacs_deliver_message to\r
+generate signed/encrypted messages, but that function doesn't call\r
+increment_mtime between running emacs and running "notmuch new".\r
+\r
+That means that if the emacs_deliver_message code is fast enough, (less\r
+than 1 second), and if the test suite is being run on a lame filesystem\r
+without sub-second timestamp granularity (including ext3fs) that the\r
+"notmuch new" invocation will not see the mail[*].\r
+\r
+I've added a call to increment_mtime and the failures go away. So I've\r
+pushed the patch to use emacsclient now.\r
+\r
+Thanks very much for helping our test suite run faster!\r
+\r
+=2DCarl\r
+\r
+[*] And, yes, this does mean that there are race conditions under which\r
+mail can be delivered and notmuch won't see it, (unless subsequent mails\r
+are delivered to the same directory). Austin has a plan to fix the use\r
+of the mtime timestamp in notmuch, (never storing the current mtime in\r
+the database if it's the same as the current time), that should\r
+hopefully close this race window.\r
+\r
+=2D-=20\r
+carl.d.worth@intel.com\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.11 (GNU/Linux)\r
+\r
+iEYEARECAAYFAk4Kbq4ACgkQ6JDdNq8qSWhvCgCgnOOkZyTwN+xo+xlf8trYdGL4\r
+uGwAoIAxLJ5uNH8Ak0UETWy+bWPsAf+9\r
+=CGeG\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r