Re: [PATCH v2 3/3] search: Support automatic tag exclusions

diff --git a/e4/3a641c4d554f9b49b7203ef96d38b055dc00a3 b/e4/3a641c4d554f9b49b7203ef96d38b055dc00a3
new file mode 100644 (file)
index 0000000..03bd724
--- /dev/null
+++ b/e4/3a641c4d554f9b49b7203ef96d38b055dc00a3
@@ -0,0 +1,105 @@
+Return-Path: <jrollins@finestructure.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id E61AB421171\r
+       for <notmuch@notmuchmail.org>; Sat, 14 Jan 2012 15:40:31 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.29\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id zGqpXEex7yjL for <notmuch@notmuchmail.org>;\r
+       Sat, 14 Jan 2012 15:40:31 -0800 (PST)\r
+Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu\r
+       [131.215.239.19])\r
+       by olra.theworths.org (Postfix) with ESMTP id 75D07421167\r
+       for <notmuch@notmuchmail.org>; Sat, 14 Jan 2012 15:40:31 -0800 (PST)\r
+Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1])\r
+       by fire-doxen-postvirus (Postfix) with ESMTP id 1D3C02E50D93;\r
+       Sat, 14 Jan 2012 15:40:31 -0800 (PST)\r
+X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new\r
+Received: from finestructure.net (cpe-76-174-137-84.socal.res.rr.com\r
+       [76.174.137.84]) (Authenticated sender: jrollins)\r
+       by fire-doxen-submit (Postfix) with ESMTP id 517342E507DB;\r
+       Sat, 14 Jan 2012 15:40:27 -0800 (PST)\r
+Received: by finestructure.net (Postfix, from userid 1000)\r
+       id BCF6232B; Sat, 14 Jan 2012 15:40:26 -0800 (PST)\r
+From: Jameson Graef Rollins <jrollins@finestructure.net>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 3/3] search: Support automatic tag exclusions\r
+In-Reply-To: <1326496024-14403-4-git-send-email-amdragon@mit.edu>\r
+References: <1326258173-21163-1-git-send-email-amdragon@mit.edu>\r
+       <1326496024-14403-1-git-send-email-amdragon@mit.edu>\r
+       <1326496024-14403-4-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.11+63~g6965a07 (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 14 Jan 2012 15:40:26 -0800\r
+Message-ID: <87wr8tsvit.fsf@servo.finestructure.net>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha256; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 14 Jan 2012 23:40:32 -0000\r
+\r
+--=-=-=\r
+\r
+This patch looks fine.  Philosophical UI discussion to follow:\r
+\r
+On Fri, 13 Jan 2012 18:07:04 -0500, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> +    if (notmuch_config_get_auto_exclude_tags (config, &tmp) == NULL) {\r
+> +    const char *tags[] = { "deleted", "spam" };\r
+> +    notmuch_config_set_auto_exclude_tags (config, tags, 2);\r
+> +    }\r
+\r
+This creates the config section with the exclude list pre-set to\r
+"deleted;spam".  I personally have no problem with this, since I was\r
+going to be setting exactly that anyway.  However, assuming we decide to\r
+have this be the default in the CLI, should we therefore add support for\r
+it in the emacs UI?  I've been going back and forth on this (as readers\r
+are well aware), and have most recently rejected the idea that we should\r
+add delete support to the emacs UI.  However, if we are excluding\r
+"deleted" tags by default, then I'm going to go back and say that we\r
+should include the keybindings to "delete" messages.  Comments?\r
+\r
+If people think we should exclude "deleted;spam" by default, and agree\r
+that we should also add delete support in the emacs UI, I'll go ahead\r
+and rework my keybinding patches.\r
+\r
+jamie.\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.11 (GNU/Linux)\r
+\r
+iQIcBAEBCAAGBQJPEhJqAAoJEO00zqvie6q8S/UP/AzPEQQRINYv4wK0s910UZmC\r
+WhCkeYdeydsKHwBKtETnUF0QNa10wJO+SiQfeffs0BCc28jR9U3NIi32WkIHuvcM\r
+1JzOcG4AY4lfqN8laJQgrKWbDnXrRnLw0bS0DYx2wDGacq2JEEa4xOVsjIp9styX\r
+keHfVtfTaJ1l2bWQsXeVNUw99DpbGAn3JYnrDRDy7AaQiaa5DUk3NAdrn+vj9hla\r
+ccMOfeGwLmFRe98EgBN4LjWotjmE09s0EoyLGh+M5c2bK81zO0ZcvQth6FSjDfjr\r
+bZMSxwlYhq6ACG7/o+mN0+yMiDzxA8K/P0fEZ2XsNXPrAPBNcNu1efDpcPbm+xbH\r
+0rXQFN1YN1v1cIvnXi/B4f6X8qfkBdtKput32aCXuge6T4/WuNvt743uXw2DLZvt\r
+O2Yi5QcJA51oZcaKsPiqEXQ3IijwM5e0z3xFFGCnZFJpNEUkKyKieNBE/I5ty2n3\r
+y3bEKpWvCB7dbxy4nQnul0EuNNcJshPyMeLSwFV2Y0pxf9pTfvt+y66K1WwgjnCF\r
+9o/YTd/uKUuFNDJ+BibltYUWm4GbMfo8WuybMHuqMOETPHw2lya/PpW7LaS+pJcD\r
+2tvkcjAHrj2bhqCljb0A8RWb1sYBIlMsTnCtA1DAWuB+ceaycwLO8VCH6hcznBlr\r
+BRI+dnjIFMId5K7Qh0Zt\r
+=a6Yk\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r