Re: [PATCH v2 06/10] cli: Introduce "notmuch address" command

diff --git a/d0/b0ea471c34fa8f749e495fdd16164477bf6fc7 b/d0/b0ea471c34fa8f749e495fdd16164477bf6fc7
new file mode 100644 (file)
index 0000000..d034a1f
--- /dev/null
+++ b/d0/b0ea471c34fa8f749e495fdd16164477bf6fc7
@@ -0,0 +1,111 @@
+Return-Path: <sojka@merica.cz>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 13897431FAF\r
+       for <notmuch@notmuchmail.org>; Wed,  5 Nov 2014 04:24:11 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.3\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 7FiyazWQSo4D for <notmuch@notmuchmail.org>;\r
+       Wed,  5 Nov 2014 04:24:03 -0800 (PST)\r
+Received: from max.feld.cvut.cz (max.feld.cvut.cz [147.32.192.36])\r
+       by olra.theworths.org (Postfix) with ESMTP id 92586431FAE\r
+       for <notmuch@notmuchmail.org>; Wed,  5 Nov 2014 04:24:03 -0800 (PST)\r
+Received: from localhost (unknown [192.168.200.7])\r
+       by max.feld.cvut.cz (Postfix) with ESMTP id 449FB5CD26F;\r
+       Wed,  5 Nov 2014 13:23:59 +0100 (CET)\r
+X-Virus-Scanned: IMAP STYX AMAVIS\r
+Received: from max.feld.cvut.cz ([192.168.200.1])\r
+       by localhost (styx.feld.cvut.cz [192.168.200.7]) (amavisd-new,\r
+       port 10044)\r
+       with ESMTP id d01Jy_ID88Tj; Wed,  5 Nov 2014 13:23:54 +0100 (CET)\r
+Received: from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34])\r
+       by max.feld.cvut.cz (Postfix) with ESMTP id 196515CD26A;\r
+       Wed,  5 Nov 2014 13:23:53 +0100 (CET)\r
+Received: from wsh by steelpick.2x.cz with local (Exim 4.84)\r
+       (envelope-from <sojka@merica.cz>)\r
+       id 1Xlzcu-000669-T2; Wed, 05 Nov 2014 13:23:52 +0100\r
+From: Michal Sojka <sojkam1@fel.cvut.cz>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 06/10] cli: Introduce "notmuch address" command\r
+In-Reply-To: <87d291ao34.fsf@qmul.ac.uk>\r
+References: <1415058622-21162-1-git-send-email-sojkam1@fel.cvut.cz>\r
+       <1415058622-21162-7-git-send-email-sojkam1@fel.cvut.cz>\r
+       <87zjc72v79.fsf@qmul.ac.uk> <87y4rqliid.fsf@steelpick.2x.cz>\r
+       <87d291ao34.fsf@qmul.ac.uk>\r
+User-Agent: Notmuch/0.18.2+178~g6e9e8bb (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Wed, 05 Nov 2014 13:23:52 +0100\r
+Message-ID: <87y4rpkf8n.fsf@steelpick.2x.cz>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=utf-8\r
+Content-Transfer-Encoding: quoted-printable\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 05 Nov 2014 12:24:11 -0000\r
+\r
+On Wed, Nov 05 2014, Mark Walters wrote:\r
+> On Tue, 04 Nov 2014, Michal Sojka <sojkam1@fel.cvut.cz> wrote:\r
+>> On Tue, Nov 04 2014, Mark Walters wrote:\r
+>>> On Mon, 03 Nov 2014, Michal Sojka <sojkam1@fel.cvut.cz> wrote:\r
+>>>> This moves address-related functionality from search command to the\r
+>>>> new address command. The implementation shares almost all code and\r
+>>>> some command line options.\r
+>>>>\r
+>>>> Options --offset and --limit were intentionally not included in the\r
+>>>> address command, because they refer to messages numbers, which users\r
+>>>> do not see in the output. This could confuse users because, for\r
+>>>> example, they could see more addresses in the output that what was\r
+>>>> specified with --limit. This functionality can be correctly\r
+>>>> reimplemented for addresses later.\r
+>>>\r
+>>> I am not sure about this: we already have this anomaly for output=3Dfil=\r
+es\r
+>>> say. Also I can imagine calling notmuch address --limit=3D1000 ... to g=\r
+et\r
+>>> a bunch of recent addresses quickly and I really am wanting to look at\r
+>>> 1000 messages, not collect 1000 addresses.\r
+>>\r
+>> I think that one of the reasons for having the new "address" command is\r
+>> to have cleaner user interface. And including "anomalies" doesn't sound\r
+>> like a way to achieve this. I think that now you can use "date:" query\r
+>> to limit the search.\r
+>>\r
+>> I volunteer to implement "address --limit" properly after 0.19. This\r
+>> should be easy.\r
+>\r
+> I think this depends on how you view limit: is it to limit the output\r
+> (roughly to run "head" on the output), or is to bound the amount of work\r
+> notmuch has to do (eg to make sure you don't get a long delay). Your\r
+> suggestion is definitely the former, whereas I am more worried about the\r
+> latter: limit in your definition could take an essentially unbounded\r
+> amount of time.\r
+\r
+Why? If I understand you correctly, you think of limit in terms of\r
+messages. There is 1:N mapping between messages and addresses, where\r
+N=C2=A0>=3D=C2=A01. If I limit the number of printed addresses, I limit the=\r
+ number\r
+of messages as well. Only if N is zero (which probably can be the case\r
+with Bcc and --output=3Drecipients) then it can result in unbounded work\r
+(provided you have infinite number of Bcc only messages in your\r
+database=C2=A0:-)).\r
+\r
+Do I miss something?\r
+\r
+-Michal\r