Re: [PATCH 2/4] nmbug: Handle missing @upstream in is_unmerged

diff --git a/e4/c78843c5c416c4e83c08ba627e443e787d3fca b/e4/c78843c5c416c4e83c08ba627e443e787d3fca
new file mode 100644 (file)
index 0000000..4131b4f
--- /dev/null
+++ b/e4/c78843c5c416c4e83c08ba627e443e787d3fca
@@ -0,0 +1,66 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 35B67431FC4\r
+       for <notmuch@notmuchmail.org>; Tue, 15 Jul 2014 16:45:01 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id daztKjc2v+7M for <notmuch@notmuchmail.org>;\r
+       Tue, 15 Jul 2014 16:44:57 -0700 (PDT)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id A2AE6431FC0\r
+       for <notmuch@notmuchmail.org>; Tue, 15 Jul 2014 16:44:57 -0700 (PDT)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1X7CP2-0003LQ-Tl; Tue, 15 Jul 2014 20:44:56 -0300\r
+Received: (nullmailer pid 5239 invoked by uid 1000); Tue, 15 Jul 2014\r
+       23:44:53 -0000\r
+From: David Bremner <bremner@debian.org>\r
+To: "W. Trevor King" <wking@tremily.us>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 2/4] nmbug: Handle missing @upstream in is_unmerged\r
+In-Reply-To:\r
+ <f96d39a63a505216141bd2daaf3a52e066713296.1404678709.git.wking@tremily.us>\r
+References: <cover.1404678709.git.wking@tremily.us>\r
+       <f96d39a63a505216141bd2daaf3a52e066713296.1404678709.git.wking@tremily.us>\r
+User-Agent: Notmuch/0.18.1+45~gf47eeac (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Tue, 15 Jul 2014 20:44:53 -0300\r
+Message-ID: <874myi89vu.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 15 Jul 2014 23:45:01 -0000\r
+\r
+"W. Trevor King" <wking@tremily.us> writes:\r
+\r
+> -  my $fetch_head = git ('rev-parse', $commit);\r
+> +  my ($fetch_head, $status) = git_with_status ('rev-parse', $commit);\r
+> +  if ($status) {\r
+> +    return 0;\r
+> +  }\r
+\r
+Could there be other errors here, other than @{upstream} not existing?\r
+At first glance it seems like there is potential to hide errors here.\r
+\r
+d\r
+\r