Fix insecure tempfile usage

svn path=/main/trunk/; revision=6286

diff --git a/pym/portage/tests/env/config/test_PackageKeywordsFile.py b/pym/portage/tests/env/config/test_PackageKeywordsFile.py
index f493b82dc890cd9b8841465621ba7d15d0d3cd20..229d9dffe4135bad6bef237c16c1d8f168a073c4 100644 (file)
--- a/pym/portage/tests/env/config/test_PackageKeywordsFile.py
+++ b/pym/portage/tests/env/config/test_PackageKeywordsFile.py
@@ -5,10 +5,11 @@
 
 from portage.tests import TestCase
 from portage.env.config import PackageKeywordsFile
+from tempfile import mkstemp
+import os
 
 class PackageKeywordsFileTestCase(TestCase):
 
-       fname = 'package.keywords'
        cpv = 'sys-apps/portage'
        keywords = ['~x86', 'amd64', '-mips']
        
@@ -28,8 +29,9 @@ class PackageKeywordsFileTestCase(TestCase):
                        self.NukeFile()
        
        def BuildFile(self):
-               f = open(self.fname, 'wb')
-               f.write('%s %s\n' % (self.cpv, ' '.join(self.keywords)))
+               fd, self.fname = mkstemp()
+               f = os.fdopen(fd, 'w')
+               f.write("\n".join(self.atoms))
                f.close()
 
        def NukeFile(self):

diff --git a/pym/portage/tests/env/config/test_PackageMaskFile.py b/pym/portage/tests/env/config/test_PackageMaskFile.py
index d97eeebe87d904755396721e30520cb93432b23e..ad87d5a56a15131411e19cc065454a84fc51c92e 100644 (file)
--- a/pym/portage/tests/env/config/test_PackageMaskFile.py
+++ b/pym/portage/tests/env/config/test_PackageMaskFile.py
@@ -7,6 +7,7 @@ import os
 
 from portage.env.config import PackageMaskFile
 from portage.tests import TestCase
+from tempfile import mkstemp
 
 class PackageMaskFileTestCase(TestCase):
 
@@ -22,7 +23,6 @@ class PackageMaskFileTestCase(TestCase):
                        self.NukeFile()
        
        def BuildFile(self):
-               from tempfile import mkstemp
                fd, self.fname = mkstemp()
                f = os.fdopen(fd, 'w')
                f.write("\n".join(self.atoms))

diff --git a/pym/portage/tests/env/config/test_PackageUseFile.py b/pym/portage/tests/env/config/test_PackageUseFile.py
index 71ab526fffcd774d07161021b2b8c51be8d77995..d20ab4572ff786c143644741c2dcada587d231fb 100644 (file)
--- a/pym/portage/tests/env/config/test_PackageUseFile.py
+++ b/pym/portage/tests/env/config/test_PackageUseFile.py
@@ -3,12 +3,14 @@
 # Distributed under the terms of the GNU General Public License v2
 # $Id: test_PackageUseFile.py 6182 2007-03-06 07:35:22Z antarus $
 
+import os
 from portage.tests import TestCase
 from portage.env.config import PackageUseFile
+from tempfile import mkstemp
+
 
 class PackageUseFileTestCase(TestCase):
 
-       fname = 'package.use'
        cpv = 'sys-apps/portage'
        useflags = ['cdrom', 'far', 'boo', 'flag', 'blat']
        
@@ -27,7 +29,8 @@ class PackageUseFileTestCase(TestCase):
                        self.NukeFile()
 
        def BuildFile(self):
-               f = open(self.fname, 'wb')
+               fd, self.fname = mkstemp()
+               f = os.fdopen(self.fname, 'wb')
                f.write("%s %s" % (self.cpv, ' '.join(self.useflags)))
        
        def NukeFile(self):