Re: [PATCH v2 08/10] cli: address: Do not output duplicate addresses

diff --git a/8b/cfc9ab414d52891f36055eac5094a192df2a72 b/8b/cfc9ab414d52891f36055eac5094a192df2a72
new file mode 100644 (file)
index 0000000..8c44ce5
--- /dev/null
+++ b/8b/cfc9ab414d52891f36055eac5094a192df2a72
@@ -0,0 +1,96 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1C5C9431FC4\r
+       for <notmuch@notmuchmail.org>; Mon,  3 Nov 2014 23:05:29 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id snuFFBZx9aLm for <notmuch@notmuchmail.org>;\r
+       Mon,  3 Nov 2014 23:05:22 -0800 (PST)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 1F74F431FAE\r
+       for <notmuch@notmuchmail.org>; Mon,  3 Nov 2014 23:05:22 -0800 (PST)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1XlYB7-0001pe-DF; Tue, 04 Nov 2014 03:05:21 -0400\r
+Received: (nullmailer pid 26803 invoked by uid 1000); Tue, 04 Nov 2014\r
+       07:05:16 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 08/10] cli: address: Do not output duplicate addresses\r
+In-Reply-To: <1415058622-21162-9-git-send-email-sojkam1@fel.cvut.cz>\r
+References: <1415058622-21162-1-git-send-email-sojkam1@fel.cvut.cz>\r
+       <1415058622-21162-9-git-send-email-sojkam1@fel.cvut.cz>\r
+User-Agent: Notmuch/0.18.2+156~g3cc8ed5 (http://notmuchmail.org) Emacs/24.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Tue, 04 Nov 2014 08:05:16 +0100\r
+Message-ID: <87a947monn.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 04 Nov 2014 07:05:29 -0000\r
+\r
+Michal Sojka <sojkam1@fel.cvut.cz> writes:\r
+\r
+>  \r
+> +/* Returns TRUE iff name and addr is duplicate. */\r
+\r
+If you're revising this patch, it would be good to mention the side\r
+effect of this function.\r
+\r
+> -process_address_list (const search_context_t *ctx, InternetAddressList *list)\r
+> +process_address_list (const search_context_t *ctx,\r
+> +                  InternetAddressList *list)\r
+\r
+It probably doesn't make any difference, but this looks like a needless\r
+whitespace change.\r
+\r
+This function definitely needs some comment / pointer to\r
+documention. And probably not to have _my in the name.\r
+\r
+> +static void\r
+> +_my_talloc_free_for_g_hash (void *ptr)\r
+> +{\r
+> +    talloc_free (ptr);\r
+> +}\r
+> +\r
+\r
+I don't understand the name of the next subtest\r
+\r
+> +test_begin_subtest "No --output"\r
+> +notmuch address --output=sender --output=recipients '*' >OUTPUT\r
+> +# Use EXPECTED from previous subtest\r
+> +test_expect_equal_file OUTPUT EXPECTED\r
+> +\r
+> +\r
+> +test_done\r
+\r
+nitpick, extra blank lines\r
+\r
+So, AIUI, this is all of the series proposed for 0.19. It looks close to\r
+OK to me, modulo some minor style nits. One anonymous commentator on\r
+IRC mentioned the use of module scope variables, I guess in patch\r
+6/10. I'm not sure of a better solution, but it's true in a perfect\r
+world we wouldn't have module local state.\r
+\r
+d\r