Re: [PATCH 2/3] notmuch-mutt: support for messages that lack Message-ID headers

diff --git a/23/30b2d353228a2726c0499c0429196e009fbfff b/23/30b2d353228a2726c0499c0429196e009fbfff
new file mode 100644 (file)
index 0000000..4535beb
--- /dev/null
+++ b/23/30b2d353228a2726c0499c0429196e009fbfff
@@ -0,0 +1,97 @@
+Return-Path: <jani@nikula.org>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id BE552431FAF\r
+       for <notmuch@notmuchmail.org>; Sat, 24 Jan 2015 12:04:16 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 1.738\r
+X-Spam-Level: *\r
+X-Spam-Status: No, score=1.738 tagged_above=-999 required=5\r
+       tests=[DNS_FROM_AHBL_RHSBL=2.438, RCVD_IN_DNSWL_LOW=-0.7]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id t0Gp+FUpb8WM for <notmuch@notmuchmail.org>;\r
+       Sat, 24 Jan 2015 12:04:13 -0800 (PST)\r
+Received: from mail-we0-f173.google.com (mail-we0-f173.google.com\r
+       [74.125.82.173]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id B4A54431FAE\r
+       for <notmuch@notmuchmail.org>; Sat, 24 Jan 2015 12:04:12 -0800 (PST)\r
+Received: by mail-we0-f173.google.com with SMTP id w62so3007604wes.4\r
+       for <notmuch@notmuchmail.org>; Sat, 24 Jan 2015 12:04:10 -0800 (PST)\r
+X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
+       d=1e100.net; s=20130820;\r
+       h=x-gm-message-state:from:to:subject:in-reply-to:references\r
+       :user-agent:date:message-id:mime-version:content-type;\r
+       bh=JZ+ZCDE1s7YHZksy7xxNjbJysOLdiG7tYJR1X9WSvTs=;\r
+       b=cFOE2ouqurwtFAJ/Hr+ekIzX6YOgWGtf/h+uaP3Gl9hVPpAIghhol0ZKqDFtBYFPMR\r
+       X3WCjwtUthUNE2Q62zlT1Sbbo0ByB4TOvMBbOJFokXD7/Mr5XFHQ2CNB71Fyf7CC6EUn\r
+       HcJxK69SkQ3ic1OSlxKtjhUVnrNukQ322NXi4L6xr8ObZH9KBF5nAlGHNmpvwY8KjNDt\r
+       ESDTwo8z56rVhaCCwWf5e7lcx87Ehirtr19tBIsg1FX7P2fF05+EK0F1wCkQMznryIwn\r
+       ma5zTLQF6z2+PsdnHaYCU0QwmZQlOPGvKh2c4SJuav7LptCmaL1SD6FsNz4m8NnHtpK8\r
+       NiDw==\r
+X-Gm-Message-State:\r
+ ALoCoQk1m2mMDbbMkenHc5yT6upx49UQx+bKGUOe37raRulJtKsr6z4NQDILUKFSQLsMm915MOEY\r
+X-Received: by 10.194.222.136 with SMTP id qm8mr28157892wjc.116.1422129850310;\r
+       Sat, 24 Jan 2015 12:04:10 -0800 (PST)\r
+Received: from localhost (mobile-internet-bcee98-87.dhcp.inet.fi.\r
+       [188.238.152.87])\r
+       by mx.google.com with ESMTPSA id ha1sm7042734wib.24.2015.01.24.12.04.09\r
+       (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\r
+       Sat, 24 Jan 2015 12:04:09 -0800 (PST)\r
+From: Jani Nikula <jani@nikula.org>\r
+To: "Jan N. Klug" <jan.n.klug@rub.de>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 2/3] notmuch-mutt: support for messages that\r
+       lack    Message-ID      headers\r
+In-Reply-To: <20150124165639.GA1316@mobil-13.rubion.rub.de>\r
+References: <1422090701-19385-1-git-send-email-zack@upsilon.cc>\r
+       <1422090701-19385-3-git-send-email-zack@upsilon.cc>\r
+       <871tmkql6j.fsf@nikula.org> <20150124152106.GA23037@upsilon.cc>\r
+       <20150124165639.GA1316@mobil-13.rubion.rub.de>\r
+User-Agent: Notmuch/0.19+37~g290dc80 (http://notmuchmail.org) Emacs/24.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 24 Jan 2015 22:04:20 +0200\r
+Message-ID: <87y4ososhn.fsf@nikula.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 24 Jan 2015 20:04:16 -0000\r
+\r
+On Sat, 24 Jan 2015, "Jan N. Klug" <jan.n.klug@rub.de> wrote:\r
+> On Sat, Jan 24, 2015 at 04:21:06PM +0100, Stefano Zacchiroli wrote:\r
+>> On Sat, Jan 24, 2015 at 04:59:16PM +0200, Jani Nikula wrote:\r
+>> > On Sat, 24 Jan 2015, Stefano Zacchiroli <zack@upsilon.cc> wrote:\r
+>> > > To do the above, rewrite get_message_id() to scan the current message\r
+>> > > line by line, incrementally computing a SHA1. As a consequence, drop\r
+>> > > the dependency on Mail::Internet.\r
+>> > \r
+>> > I am not so sure this is a good idea however, see below.\r
+>> [...]\r
+>> But I didn't think of header folding, and you're absolutely correct in\r
+>> saying that might be a problem.\r
+>\r
+> I disagree. I do not think that header folding is a problem here. RFC\r
+> 5322 and RFC 2822 state that FWS in the message-id are not allowed (as\r
+> opposed to In-Reply: and other headers, where FWS may occur between, but\r
+> not inside message-ids).\r
+\r
+Not *inside* message-ids, but as a data point, 0.05% of my email have\r
+FWS *before* the message-id. That's more than the amount of messages\r
+I have without a message-id.\r
+\r
+BR,\r
+Jani.\r