Re: [PATCH] emacs: tree/show remove duplicate function

diff --git a/a6/f61b1c07e11242e92dc7f8851c2f90c8f4d6af b/a6/f61b1c07e11242e92dc7f8851c2f90c8f4d6af
new file mode 100644 (file)
index 0000000..9b6ad26
--- /dev/null
+++ b/a6/f61b1c07e11242e92dc7f8851c2f90c8f4d6af
@@ -0,0 +1,76 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 18C1B431FC3\r
+       for <notmuch@notmuchmail.org>; Tue, 15 Jul 2014 16:29:32 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id kMYN-QCyN6+2 for <notmuch@notmuchmail.org>;\r
+       Tue, 15 Jul 2014 16:29:25 -0700 (PDT)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 626F1431FC0\r
+       for <notmuch@notmuchmail.org>; Tue, 15 Jul 2014 16:29:25 -0700 (PDT)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1X7CA0-0003HR-Ol; Tue, 15 Jul 2014 20:29:24 -0300\r
+Received: (nullmailer pid 20872 invoked by uid 1000); Tue, 15 Jul 2014\r
+       23:29:21 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: tree/show remove duplicate function\r
+In-Reply-To: <87zjgbw0t5.fsf@qmul.ac.uk>\r
+References: <1402134668-18587-1-git-send-email-markwalters1009@gmail.com>\r
+       <87a98bbfab.fsf@maritornes.cs.unb.ca> <87zjgbw0t5.fsf@qmul.ac.uk>\r
+User-Agent: Notmuch/0.18.1+39~g64ba418 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Tue, 15 Jul 2014 20:29:21 -0300\r
+Message-ID: <87d2d69p66.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 15 Jul 2014 23:29:32 -0000\r
+\r
+Mark Walters <markwalters1009@gmail.com> writes:\r
+\r
+> On Tue, 15 Jul 2014, David Bremner <david@tethera.net> wrote:\r
+>> Mark Walters <markwalters1009@gmail.com> writes:\r
+>>> +             (cond ((eq major-mode 'notmuch-show-mode)\r
+>>> +                    (notmuch-show-get-message-properties))\r
+>>> +                   ((eq major-mode 'notmuch-tree-mode)\r
+>>> +                    (notmuch-tree-get-message-properties))))\r
+>>\r
+>> I see this already existed, but it looks weird to me to have a two test\r
+>> cond with no else. Is it intentional to have the code drop through and\r
+>> do nothing if neither case matches?  It seems like it might be better to\r
+>> signal an error.\r
+>\r
+> I can definitely do that. But as a comparison\r
+> notmuch-search-get-result and notmuch-search-find-thread-id "work" in\r
+> any buffer in the sense of returning nil but not complaining so perhaps\r
+> the current version is more consistent. \r
+>\r
+\r
+It occurs to me that we can fix all 3 places in a followup patch,\r
+so I'll push this for now.\r
+\r
+d\r