[PATCH 1/8] emacs: Fix misuse of `notmuch-tag'

diff --git a/37/668ba8efaae022b20891c2b8405dc56256e452 b/37/668ba8efaae022b20891c2b8405dc56256e452
new file mode 100644 (file)
index 0000000..cc56762
--- /dev/null
+++ b/37/668ba8efaae022b20891c2b8405dc56256e452
@@ -0,0 +1,97 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id C7DD3431E82\r
+       for <notmuch@notmuchmail.org>; Tue, 22 Oct 2013 12:51:12 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 4jafm6ItMFmZ for <notmuch@notmuchmail.org>;\r
+       Tue, 22 Oct 2013 12:51:06 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-1.mit.edu (dmz-mailsec-scanner-1.mit.edu\r
+       [18.9.25.12])\r
+       by olra.theworths.org (Postfix) with ESMTP id 75E5C431FBC\r
+       for <notmuch@notmuchmail.org>; Tue, 22 Oct 2013 12:51:06 -0700 (PDT)\r
+X-AuditID: 1209190c-b7fd38e0000009aa-d7-5266d7292f7e\r
+Received: from mailhub-auth-4.mit.edu ( [18.7.62.39])\r
+       by dmz-mailsec-scanner-1.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id 7D.16.02474.927D6625; Tue, 22 Oct 2013 15:51:05 -0400 (EDT)\r
+Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11])\r
+       by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id r9MJp3OC020279; \r
+       Tue, 22 Oct 2013 15:51:04 -0400\r
+Received: from drake.dyndns.org (31-33-57.wireless.csail.mit.edu\r
+       [128.31.33.57]) (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id r9MJp0Xd005188\r
+       (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+       Tue, 22 Oct 2013 15:51:03 -0400\r
+Received: from amthrax by drake.dyndns.org with local (Exim 4.77)\r
+       (envelope-from <amdragon@mit.edu>)\r
+       id 1VYhym-0006yd-Hz; Tue, 22 Oct 2013 15:51:00 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: notmuch@notmuchmail.org\r
+Subject: [PATCH 1/8] emacs: Fix misuse of `notmuch-tag'\r
+Date: Tue, 22 Oct 2013 15:50:50 -0400\r
+Message-Id: <1382471457-26056-2-git-send-email-amdragon@mit.edu>\r
+X-Mailer: git-send-email 1.8.4.rc3\r
+In-Reply-To: <1382471457-26056-1-git-send-email-amdragon@mit.edu>\r
+References: <1382471457-26056-1-git-send-email-amdragon@mit.edu>\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFlrPIsWRmVeSWpSXmKPExsUixG6nrqt5PS3IYNMyE4vrN2cyOzB6PFt1\r
+       izmAMYrLJiU1J7MstUjfLoErY37jBPaCqRwVx/Y/YWpgfMTWxcjJISFgIvF08QUmCFtM4sK9\r
+       9UBxLg4hgX2MEn2vO9khnI2MEt8af7KAVAkJHGOSeL9eHMKeyyix4GkAiM0moCGxbf9yRhBb\r
+       REBaYufd2axdjBwczAJqEn+6VEDCwgLmEh2vL7KDhFkEVCXOXbIBCfMKOEhMOvmUFeIGJYmF\r
+       p7aB2ZwCjhLT9/1jAykXAqo5dYdjAiP/AkaGVYyyKblVurmJmTnFqcm6xcmJeXmpRbqGermZ\r
+       JXqpKaWbGEHhwinJs4PxzUGlQ4wCHIxKPLwPWtKChFgTy4orcw8xSnIwKYnyRlwFCvEl5adU\r
+       ZiQWZ8QXleakFh9ilOBgVhLhbfYFyvGmJFZWpRblw6SkOViUxHlvctgHCQmkJ5akZqemFqQW\r
+       wWRlODiUJHgfgQwVLEpNT61Iy8wpQUgzcXCCDOcBGn4MpIa3uCAxtzgzHSJ/ilFRSpz3BkhC\r
+       ACSRUZoH1wuL51eM4kCvCEO08wBTAVz3K6DBTECDpywBG1ySiJCSamDk+t5+7FVv3yzPAgmt\r
+       9xUqxz8qXFjDksd3yXrtiTLGTWaG69ndp0c1LWVNe/Tv7joFffWUjbW/WeJ+3vT/rHdN/0Tr\r
+       nXvSb/buvCDrcyuxXz5+S9u2Mzd/LbLi2a8ncnpWb0DLjyt71FXY19YlzlyVUbmxyHbSvvQP\r
+       mt0W0y3yldZVV6avCatWYinOSDTUYi4qTgQAQlC87cICAAA=\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 22 Oct 2013 19:51:13 -0000\r
+\r
+The calling convention for `notmuch-tag' changed in commit 97aa3c06 to\r
+take a list of tag changes instead of a &rest argument, but the call\r
+from `notmuch-search-tag-all' still passed a &rest argument.  This\r
+happened to work for interactive calls because tag-changes would be\r
+nil, so the `apply' call would pass only the query string to\r
+`notmuch-tag' and simply omit the &optional tag-changes argument.\r
+---\r
+ emacs/notmuch.el | 2 +-\r
+ 1 file changed, 1 insertion(+), 1 deletion(-)\r
+\r
+diff --git a/emacs/notmuch.el b/emacs/notmuch.el\r
+index c47c6b5..e0511c8 100644\r
+--- a/emacs/notmuch.el\r
++++ b/emacs/notmuch.el\r
+@@ -837,7 +837,7 @@ non-authors is found, assume that all of the authors match."\r
+ \r
+ See `notmuch-tag' for information on the format of TAG-CHANGES."\r
+   (interactive)\r
+-  (apply 'notmuch-tag notmuch-search-query-string tag-changes))\r
++  (notmuch-tag notmuch-search-query-string tag-changes))\r
+ \r
+ (defun notmuch-search-buffer-title (query)\r
+   "Returns the title for a buffer with notmuch search results."\r
+-- \r
+1.8.4.rc3\r
+\r