Re: [PATCH] replace gnu xargs usage in notmuch-mutt with perl

diff --git a/f5/aeb6310e542b55a361d08b20069b878d84e26d b/f5/aeb6310e542b55a361d08b20069b878d84e26d
new file mode 100644 (file)
index 0000000..82f663b
--- /dev/null
+++ b/f5/aeb6310e542b55a361d08b20069b878d84e26d
@@ -0,0 +1,118 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 24051431FB6\r
+       for <notmuch@notmuchmail.org>; Tue, 10 Apr 2012 09:28:41 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id l+11-8K3D7R4 for <notmuch@notmuchmail.org>;\r
+       Tue, 10 Apr 2012 09:28:40 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66])\r
+       by olra.theworths.org (Postfix) with ESMTP id 21771431FAF\r
+       for <notmuch@notmuchmail.org>; Tue, 10 Apr 2012 09:28:40 -0700 (PDT)\r
+Received: by guru.guru-group.fi (Postfix, from userid 501)\r
+       id 7569668055; Tue, 10 Apr 2012 19:28:37 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Taylor Carpenter <taylor@codecafe.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] replace gnu xargs usage in notmuch-mutt with perl\r
+In-Reply-To: <20120409211153.GA6497@codecafe.com>\r
+References: <20120409211153.GA6497@codecafe.com>User-Agent:\r
+ Notmuch/0.12+77~gee11800      (http://notmuchmail.org) Emacs/23.3.1\r
+ (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Tue, 10 Apr 2012 19:28:37 +0300\r
+Message-ID: <m2hawr4klm.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 10 Apr 2012 16:28:41 -0000\r
+\r
+On Tue, Apr 10 2012, Taylor Carpenter wrote:\r
+\r
+> ---\r
+\r
+what if instead of\r
+\r
+> +    my @filelist = `notmuch search --output=files $query`;\r
+> +    foreach(@filelist) {\r
+\r
+there is:\r
+\r
+  open my $fh, '-|', qw/notmuch search --output=files/, $query;\r
+  while (<$fh>) { \r
+   ...\r
+  }\r
+  unless (close $fh) {\r
+     # handle error case\r
+  }\r
+\r
+Tomi\r
+\r
+(in addition to more verbose commit message & unrelated change moved to\r
+another commit)\r
+\r
+\r
+>  contrib/notmuch-mutt/notmuch-mutt |   12 ++++++++----\r
+>  1 files changed, 8 insertions(+), 4 deletions(-)\r
+>\r
+> diff --git a/contrib/notmuch-mutt/notmuch-mutt b/contrib/notmuch-mutt/notmuch-mutt\r
+> index 71206c3..dbe7f2d 100755\r
+> --- a/contrib/notmuch-mutt/notmuch-mutt\r
+> +++ b/contrib/notmuch-mutt/notmuch-mutt\r
+> @@ -1,4 +1,4 @@\r
+> -#!/usr/bin/perl -w\r
+> +#!/usr/bin/env perl -w\r
+>  #\r
+>  # notmuch-mutt - notmuch (of a) helper for Mutt\r
+>  #\r
+> @@ -12,6 +12,7 @@ use strict;\r
+>  use warnings;\r
+>  \r
+>  use File::Path;\r
+> +use File::Basename;\r
+>  use Getopt::Long qw(:config no_getopt_compat);\r
+>  use Mail::Internet;\r
+>  use Mail::Box::Maildir;\r
+> @@ -41,9 +42,12 @@ sub search($$) {\r
+>      $query = shell_quote($query);\r
+>  \r
+>      empty_maildir($maildir);\r
+> -    system("notmuch search --output=files $query"\r
+> -       . " | sed -e 's: :\\\\ :g'"\r
+> -       . " | xargs --no-run-if-empty ln -s -t $maildir/cur/");\r
+> +    my @filelist = `notmuch search --output=files $query`;\r
+> +    foreach(@filelist) {\r
+> +        chomp;\r
+> +        my $target = sprintf("$maildir/cur/%s", basename($_));\r
+> +        symlink($_, $target);\r
+> +    }\r
+>  }\r
+>  \r
+>  sub prompt($$) {\r
+> -- \r
+> 1.7.7.4\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r