Re: [Patch v2 0/3] Add test and fix exclude bug

diff --git a/ac/1074e6f858e86c4db283986416366265632a00 b/ac/1074e6f858e86c4db283986416366265632a00
new file mode 100644 (file)
index 0000000..14bfc9c
--- /dev/null
+++ b/ac/1074e6f858e86c4db283986416366265632a00
@@ -0,0 +1,105 @@
+Return-Path: <jrollins@finestructure.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 90C39431FBF\r
+       for <notmuch@notmuchmail.org>; Fri, 16 Mar 2012 23:02:36 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.29\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 4nl6GIIqeWgz for <notmuch@notmuchmail.org>;\r
+       Fri, 16 Mar 2012 23:02:35 -0700 (PDT)\r
+Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu\r
+       [131.215.239.19])\r
+       by olra.theworths.org (Postfix) with ESMTP id 67F61431FB6\r
+       for <notmuch@notmuchmail.org>; Fri, 16 Mar 2012 23:02:34 -0700 (PDT)\r
+Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1])\r
+       by earth-doxen-postvirus (Postfix) with ESMTP id E030F66E00DD;\r
+       Fri, 16 Mar 2012 23:02:31 -0700 (PDT)\r
+X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new\r
+Received: from finestructure.net (cpe-74-66-81-190.nyc.res.rr.com\r
+       [74.66.81.190]) (Authenticated sender: jrollins)\r
+       by earth-doxen-submit (Postfix) with ESMTP id 106D066E0108;\r
+       Fri, 16 Mar 2012 23:02:29 -0700 (PDT)\r
+Received: by finestructure.net (Postfix, from userid 1000)\r
+       id 154A74A8; Fri, 16 Mar 2012 23:02:26 -0700 (PDT)\r
+From: Jameson Graef Rollins <jrollins@finestructure.net>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [Patch v2 0/3] Add test and fix exclude bug\r
+In-Reply-To: <1331728014-32698-1-git-send-email-markwalters1009@gmail.com>\r
+References: <1331728014-32698-1-git-send-email-markwalters1009@gmail.com>\r
+User-Agent: Notmuch/0.11.1+306~g05d342c (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Fri, 16 Mar 2012 23:02:25 -0700\r
+Message-ID: <87limzepe6.fsf@servo.finestructure.net>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha256; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 17 Mar 2012 06:02:37 -0000\r
+\r
+--=-=-=\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+On Wed, 14 Mar 2012 12:26:51 +0000, Mark Walters <markwalters1009@gmail.com=\r
+> wrote:\r
+> The test in the previous patches\r
+> id:"1331551914-28323-1-git-send-email-markwalters1009@gmail.com"\r
+> triggered the bug accidentally. It accidentally set the exclude tags\r
+> to be "=3D" and "deleted" rather than just "deleted". The non-existent\r
+> "=3D" tag (i.e., the tag that does not occur anywhere in the Xapian\r
+> database) triggered the bug. First we correct the tests to just set\r
+> the "deleted" tag, then we add some tests including one with a\r
+> deliberately non-existent tag. Finally, we modify the exclusion code\r
+> to avoid the bug.\r
+>=20\r
+> The modification also appears to fix a similar problem for jrollins\r
+> that I have not yet been able to reproduce.\r
+>=20\r
+> Since the code is now more clearly correct, cleaner and we do\r
+> definitely avoid a Xapian bug I think these patches can be committed\r
+> even without knowing why it fixed jrollins' bug.\r
+>=20\r
+> Finally these apply to current master (not to the --with-excluded series).\r
+\r
+tested, and it works for me, so LGTM.\r
+\r
+jamie.\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.11 (GNU/Linux)\r
+\r
+iQIcBAEBCAAGBQJPZCjxAAoJEO00zqvie6q88ZsQALW3GWKh7IXsI/Z/s2gjdNqh\r
+FwVhXQjsibRLxvZ8FvXhPp7iU6mwn8maBLLe8uEUdvGdf4e55/Uf4GF1zjWHOQvN\r
+eevD9wiV55z+uVA4hmp0VGC69rgoPGlb+BUcdQKUj2CnbRuydOObXUUqJbNKFksA\r
+LrneTwEGgiw0ogSoymjkXd3Jj+aaWuEyx9FPyvme16Q3JcqMeeCpqXOb0n8m2x8c\r
+9a+4nD7TxeRkCSVDbvVfV0ecOmPr7D6IrcLUYZd8wK//hdKTWVSN1DY8De4mQA78\r
+vthnh1p4ArCXoiSlf4yUotLz0h0xNmvsKWoY6wGIvgYVaEVeClj7ELNsubx8mu3J\r
+J2OvXN8gU1TM8X122r8/rIdQBXy0zgqus6ysqgcCDo0zsb4tI44xnZMAy+yixwqs\r
+OBFkAMQrfL10KzECSvts9J4geXG9CJovAFbSSWCFwdI391zuaCXhVYJaqljsbuHg\r
+aSqxdne8ukcK/oPf8doXq/rHoeAgBy4e62MZjKISGHpm9T1MWTL9Vr5TmKtHskDB\r
+sFqOCPj8bbzrfbwOi06B40lEB8zg1MX2untTBsKj3449eoWl1DCHdn8JlS40IpDF\r
+snJD1efGqvRtLkxlpsekp/+zjXfax4ppsehGdPB7C4f2/aU4gv4D64HRKiQs8L6E\r
+Yy1ZFNJOMr06CJARZAbe\r
+=yO6E\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r