Re: [PATCH] cli: notmuch address option defaults update

diff --git a/96/1b9fc9a1d817267fc4d1130e42693a87a85ea1 b/96/1b9fc9a1d817267fc4d1130e42693a87a85ea1
new file mode 100644 (file)
index 0000000..6232211
--- /dev/null
+++ b/96/1b9fc9a1d817267fc4d1130e42693a87a85ea1
@@ -0,0 +1,108 @@
+Return-Path: <sojkam1@fel.cvut.cz>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1676F431FB6\r
+       for <notmuch@notmuchmail.org>; Fri,  7 Nov 2014 01:21:31 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.3\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 6iwdQ65qEbAT for <notmuch@notmuchmail.org>;\r
+       Fri,  7 Nov 2014 01:21:27 -0800 (PST)\r
+Received: from max.feld.cvut.cz (max.feld.cvut.cz [147.32.192.36])\r
+       by olra.theworths.org (Postfix) with ESMTP id 75BB9431FAE\r
+       for <notmuch@notmuchmail.org>; Fri,  7 Nov 2014 01:21:27 -0800 (PST)\r
+Received: from localhost (unknown [192.168.200.7])\r
+       by max.feld.cvut.cz (Postfix) with ESMTP id 480D95CD092;\r
+       Fri,  7 Nov 2014 10:21:24 +0100 (CET)\r
+X-Virus-Scanned: IMAP STYX AMAVIS\r
+Received: from max.feld.cvut.cz ([192.168.200.1])\r
+       by localhost (styx.feld.cvut.cz [192.168.200.7]) (amavisd-new,\r
+       port 10044)\r
+       with ESMTP id 8VQ1S9AQtDFR; Fri,  7 Nov 2014 10:21:18 +0100 (CET)\r
+Received: from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34])\r
+       by max.feld.cvut.cz (Postfix) with ESMTP id A12335CD088;\r
+       Fri,  7 Nov 2014 10:21:18 +0100 (CET)\r
+Received: from wsh by steelpick.2x.cz with local (Exim 4.84)\r
+       (envelope-from <sojkam1@fel.cvut.cz>)\r
+       id 1XmfjK-0008UB-EV; Fri, 07 Nov 2014 10:21:18 +0100\r
+From: Michal Sojka <sojkam1@fel.cvut.cz>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] cli: notmuch address option defaults update\r
+In-Reply-To: <1415297516-29203-1-git-send-email-tomi.ollila@iki.fi>\r
+References: <1415297516-29203-1-git-send-email-tomi.ollila@iki.fi>\r
+User-Agent: Notmuch/0.18.2+178~g6e9e8bb (http://notmuchmail.org) Emacs/24.4.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Fri, 07 Nov 2014 10:21:18 +0100\r
+Message-ID: <87h9ybxt69.fsf@steelpick.2x.cz>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: tomi.ollila@iki.fi\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Fri, 07 Nov 2014 09:21:31 -0000\r
+\r
+On Thu, Nov 06 2014, Tomi Ollila wrote:\r
+> When no --output option were given, change default to display senders\r
+> only. This is faster and provides useful-enough list of addresses.\r
+>\r
+> When only --count option is given, display senders (in contrary to not\r
+> displaying anything).\r
+>\r
+> Document how --count affects to "sort order" a bit more accurately.\r
+>\r
+> Clean up some whitespace in the documentation.\r
+>\r
+> One test updated to have --output=count without sender nor recipient\r
+> output option.\r
+> ---\r
+>\r
+> Some quick updates to the notmuch address interface which I hope will\r
+> be considered to be included in 0.19 release. As we are in feature freeze\r
+> I hope this gets quick feedback, in any way you desire.\r
+>\r
+> Tomi\r
+>\r
+>  doc/man1/notmuch-address.rst | 34 ++++++++++++++++++----------------\r
+>  notmuch-search.c             |  4 ++--\r
+>  test/T095-address.sh         | 14 +++++++-------\r
+>  3 files changed, 27 insertions(+), 25 deletions(-)\r
+>\r
+> diff --git a/doc/man1/notmuch-address.rst b/doc/man1/notmuch-address.rst\r
+> index 359616e0dc5f..034607c434d2 100644\r
+> --- a/doc/man1/notmuch-address.rst\r
+> +++ b/doc/man1/notmuch-address.rst\r
+> @@ -32,28 +32,28 @@ Supported options for **address** include\r
+>      ``--output=(sender|recipients|count)``\r
+>  \r
+>          Controls which information appears in the output. This option\r
+> -    can be given multiple times to combine different outputs.\r
+> -    Omitting this option is equivalent to\r
+> -    --output=sender --output=recipients.\r
+> +        can be given multiple times to combine different outputs.\r
+> +        Omitting this option is equivalent to --output=sender.\r
+\r
+The implementation does a bit more. What about:\r
+\r
+    When neither --output=sender nor --output=recipients is given,\r
+    --output=sender is implied.\r
+\r
+Otherwise it LGTM.\r
+\r
+Thanks,\r
+-Michal\r