--- /dev/null
+Return-Path: <micah@riseup.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 764D5431FC7\r
+ for <notmuch@notmuchmail.org>; Wed, 27 Jan 2010 11:00:04 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.095\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.095 tagged_above=-999 required=5 tests=[AWL=0.903,\r
+ BAYES_50=0.001, RCVD_IN_DNSWL_LOW=-1, UNPARSEABLE_RELAY=0.001] autolearn=ham\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id 5q7O2m-dXFzQ for <notmuch@notmuchmail.org>;\r
+ Wed, 27 Jan 2010 11:00:01 -0800 (PST)\r
+Received: from mx1.riseup.net (mx1.riseup.net [204.13.164.18])\r
+ by olra.theworths.org (Postfix) with ESMTP id C3FD6431FAE\r
+ for <notmuch@notmuchmail.org>; Wed, 27 Jan 2010 11:00:01 -0800 (PST)\r
+Received: from [127.0.0.1] (localhost [127.0.0.1])\r
+ (Authenticated sender: micah@mx1.riseup.net)\r
+ with ESMTPSA id E0B4125F69C\r
+Received: by lillypad (Postfix, from userid 1000)\r
+ id 39AA52CC063; Wed, 27 Jan 2010 10:56:01 -0500 (EST)\r
+From: micah anderson <micah@riseup.net>\r
+To: Andreas =?iso-8859-1?q?Kl=F6ckner?= <lists@informa.tiker.net>,\r
+ notmuch@notmuchmail.org\r
+In-Reply-To: <200912141421.52561.lists@informa.tiker.net>\r
+References: <200912141421.52561.lists@informa.tiker.net>\r
+Date: Thu, 28 Jan 2010 04:55:55 +1300\r
+Message-ID: <87ljfjfsok.fsf@lillypad.riseup.net>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+ micalg=pgp-sha512; protocol="application/pgp-signature"\r
+X-Virus-Scanned: clamav-milter 0.95.3 at mx1\r
+X-Virus-Status: Clean\r
+Subject: Re: [notmuch] [patch] store folder information\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 27 Jan 2010 19:00:04 -0000\r
+\r
+--=-=-=\r
+Content-Transfer-Encoding: quoted-printable\r
+\r
+\r
+Hi Andreas,\r
+\r
+I'm just writing because of the patch you sent to the notmuch list on\r
+December 15th. It seems like many people are wanting this functionality,\r
+I know I am myself and Carl has also indicated the same. However, there\r
+were a couple of minor suggestions for improvements for your patch that\r
+have not seen a reply from you yet. I'm particularly eager to see this\r
+get accepted upstream, and it sounds like the changes necessary to do so\r
+are relatively minor.\r
+\r
+I'm wondering what your plans are for addressing these issues? I've come\r
+to depend on this functionality, and would love to see it incorporated\r
+upstream!=20\r
+\r
+Specifically these were:\r
+\r
+1. Unrelated whitespace:\r
+\r
+On December 16th,2009 Ruben Pollan <meskio@sindominio.net> wrote:\r
+\r
+> [meskio@blackspot:src/notmuch.orig]$ git apply ~/0001-Preseve-folder-info=\r
+rmation-when-indexing.patch\r
+> /home/meskio/0001-Preseve-folder-information-when-indexing.patch:136: tra=\r
+iling whitespace.\r
+> status notmuch_database_add_message (notmuch, next,\r
+> /home/meskio/0001-Preseve-folder-information-when-indexing.patch:137: tra=\r
+iling whitespace.\r
+> folder_base_name,\r
+> warning: 2 lines add whitespace errors.\r
+>\r
+> It's just whitespaces at the end of the lines.\r
+\r
+2. An unrelated hunk creeping in:\r
+\r
+On Tue, 15 Dec 2009 13:22:19 -0800, Carl Worth <cworth@cworth.org> wrote:\r
+> On Mon, 14 Dec 2009 14:21:50 -0500, Andreas Kl=3DC3=3DB6ckner <lists@info=\r
+rma.=3D\r
+tiker.net> wrote:\r
+> >\r
+> > @@ -116,6 +116,8 @@ skip_re_in_subject (const char *subject)\r
+> > s++;\r
+> > if (strncasecmp (s, "re:", 3) =3D3D=3D3D 0)\r
+> > s +=3D3D 3;\r
+> > + else if (strncasecmp (s, "aw:", 3) =3D3D=3D3D 0)\r
+> > + s +=3D3D 3;\r
+> > else\r
+> > break;\r
+> > }\r
+>=3D20\r
+> This hunk looks unrelated to the rest. Could you submit that separately,\r
+> please?\r
+\r
+\r
+3. Redundant trailing directory name traversal:\r
+\r
+> > + gchar *full_folder_name =3D3D NULL;\r
+> > + gchar *folder_base_name =3D3D NULL;\r
+> > +\r
+> > + /* Find name of "folder" containing the email. */\r
+> > + full_folder_name =3D3D g_strdup(path);\r
+> > + while (1)\r
+> > + {\r
+> > + folder_base_name =3D3D g_path_get_basename(full_folder_name);\r
+>\r
+> The trailing directory name is available already during the\r
+> traversal. So you don't need to search it back out again. See the patch\r
+> in the following message:\r
+>\r
+> id:87fx8bygi7.fsf@linux.vnet.ibm.com\r
+>\r
+> which simply passes the trailing directory name along, (but skipping a\r
+> name of "cur" or "new" while traversing).\r
+\r
+4. supporting hierarchical folders (perhaps this is a later improvement\r
+that does not need to be added before the original patch is accepted?):\r
+\r
+> Beyond that, though, I imagine some people have hierarchical folders as\r
+> well, so it probably makes sense to store them as well.\r
+>\r
+> To do that, it's probably just a matter of calling gen_terms on the\r
+> complete filename. I haven't tested, but doing that should allow\r
+> Xapian's phrase searching to do the right thing for something like:\r
+>\r
+> filename:portion/of/the/path/name\r
+\r
+5. Probably the patch needs to be rebased off of master at this point.\r
+\r
+Micah\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1.4.10 (GNU/Linux)\r
+\r
+iQIcBAEBCgAGBQJLYGIMAAoJEIy/mjIoYaeQxogP/2AV4t+6G50aqwKs9EAY9Ewq\r
+PRY75DLhuBbf5pYi6/s8eurMhtYDRZIuc1E9XgDc5goAE9vLuQQ2I2qwKIdVJFbt\r
+mv5gcLzE9VjVa+W0rvxQTFxIAGbDNZ4EuWs6ajl9uvrmioCTvXH0pP7CQ5bWckuX\r
+/jJr28w1JjgMiP6Wz9PQ5JCxg7WSgsTxsqv2XskR+J9XHjJiSAQdr7lhLsBUUZjY\r
+nqcgvC5YbmGwaJkFpmEWcb9gKp+QjyTJ3hpQJDfOyst/+CzL99Z1Dw6ODKq+98sf\r
+0AxixzleGhaIVush4wKI1IYI7l6x3YBHAMVFE42fyJqKBazO8VGCULUMsOwBSk01\r
+Bh5iaOTrW5NwAUfvsjKsBvYZhcszMvmRkfINfoRAs3G4DziJ2QmDScwBDVfWYR/5\r
+7sqLHRBPsyoogC+HonNk0hKy3BjfYZZWZr74M7Z2Vi44BR3ATlbxxxvGwSx6S9ig\r
+k1LjzGz4WOax35Q4TntrdbVV7IDyBafpy7mBgavm9x5kAcCjbk/auFrFZESzmTjZ\r
+zDB4/ea7g8tJp6Ky2Q6YkzZrh5B6FjV7HQf3cxQuutgaXX2fcexJTflxubGJZYBx\r
+2VmYVveKTgFtGJFGxyH8MIxLlBHohascFDTN3uO5bEbZYf3QYQx6mTI19IB9+4k8\r
+BsFiJMOulwjoLJ5rEqtm\r
+=Oye4\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r
projects / notmuch-archives.git / commitdiff