Re: [PATCH v4 2/3] emacs: add notmuch-version.el.tmpl and create notmuch-version...

diff --git a/5f/d14638201905cf2ed5e768057d0cef2f725032 b/5f/d14638201905cf2ed5e768057d0cef2f725032
new file mode 100644 (file)
index 0000000..3c31a7e
--- /dev/null
+++ b/5f/d14638201905cf2ed5e768057d0cef2f725032
@@ -0,0 +1,100 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 7B294431FBF\r
+       for <notmuch@notmuchmail.org>; Mon,  7 Apr 2014 02:22:36 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id VmphGEC6OU6H for <notmuch@notmuchmail.org>;\r
+       Mon,  7 Apr 2014 02:22:26 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id C513B431FB6\r
+       for <notmuch@notmuchmail.org>; Mon,  7 Apr 2014 02:22:25 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 4910D100086;\r
+       Mon,  7 Apr 2014 12:22:17 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v4 2/3] emacs: add notmuch-version.el.tmpl and create\r
+       notmuch-version.el from it\r
+In-Reply-To: <87a9by47wh.fsf@maritornes.cs.unb.ca>\r
+References: <1395261431-24668-1-git-send-email-tomi.ollila@iki.fi>\r
+       <1395261431-24668-2-git-send-email-tomi.ollila@iki.fi>\r
+       <87a9by47wh.fsf@maritornes.cs.unb.ca>\r
+User-Agent: Notmuch/0.17+174~gef82849 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Mon, 07 Apr 2014 12:22:17 +0300\r
+Message-ID: <m261mlbik6.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 07 Apr 2014 09:22:36 -0000\r
+\r
+On Sun, Apr 06 2014, David Bremner <david@tethera.net> wrote:\r
+\r
+> Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+>\r
+>> +;; You should have received a copy of the GNU General Public License\r
+>> +;; along with Notmuch.  If not, see <http://www.gnu.org/licenses/>.\r
+>\r
+> Do you think we need a copyright header in a generated file?\r
+\r
+This is more due to the template-to-file conversion simplicity than need\r
+and I thought there is no harm having the copyright there. At least the\r
+file is consistent with others in that sense.\r
+\r
+>> +\r
+>> +(defconst notmuch-emacs-version %VERSION%\r
+>> +  "Version string of this version of Notmuch Emacs MUA.")\r
+>> +\r
+>\r
+> At the risk of being very picky, how about less copies of Version, maybe\r
+> "Version of Notmuch Emacs MUA"\r
+\r
+Actually that is a good point:\r
+\r
+What I put there was modeled after `emacs-version':\r
+"Version numbers of this version of Emacs."\r
+\r
+Then, gnus has (lisp/gnus/gnus.el in emacs sources):\r
+\r
+(defconst gnus-version-number "5.13"\r
+  "Version number for this version of Gnus.")\r
+\r
+(defconst gnus-version (format "Gnus v%s" gnus-version-number)\r
+  "Version string for this version of Gnus.")\r
+\r
+All of these are of type string, and the documentation states whether \r
+it is (at least close to) numeric or not within string. But there is\r
+no tradition of what *-version should contain.\r
+\r
+Therefore if we say "Version of Notmuch Emacs MUA", it can contain\r
+"0.17+163~gcedea23" "0.18" or "unknown"\r
+\r
+\r
+> Other than that, the series looks OK, and works on Debian now.\r
+>\r
+> d\r
+\r
+Tomi\r