Re: [PATCH] bitmap:improve memory usage using CHAR_BITS and unsigned CHAR

diff --git a/56/69cd71a31b9bb3b64de3f1c6efe94b5d347f2b b/56/69cd71a31b9bb3b64de3f1c6efe94b5d347f2b
new file mode 100644 (file)
index 0000000..b0c5cc8
--- /dev/null
+++ b/56/69cd71a31b9bb3b64de3f1c6efe94b5d347f2b
@@ -0,0 +1,77 @@
+Return-Path: <bremner@unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 39618431FB6\r
+       for <notmuch@notmuchmail.org>; Sat, 16 Feb 2013 03:37:54 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id b0eBaf+q+GVQ for <notmuch@notmuchmail.org>;\r
+       Sat, 16 Feb 2013 03:37:53 -0800 (PST)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id AAFB7431FAF\r
+       for <notmuch@notmuchmail.org>; Sat, 16 Feb 2013 03:37:53 -0800 (PST)\r
+Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net\r
+       ([156.34.82.78] helo=zancas.localnet)\r
+       by tesseract.cs.unb.ca with esmtpsa\r
+       (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1U6g5O-0004w8-O4; Sat, 16 Feb 2013 07:37:47 -0400\r
+Received: from bremner by zancas.localnet with local (Exim 4.80)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1U6g5J-0007Hj-52; Sat, 16 Feb 2013 07:37:37 -0400\r
+From: David Bremner <david@tethera.net>\r
+To: Robert Mast <beheerder@tekenbeetziekten.nl>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] bitmap:improve memory usage using CHAR_BITS and unsigned\r
+       CHAR\r
+In-Reply-To: <1360769577-4861-1-git-send-email-beheerder@tekenbeetziekten.nl>\r
+References: <1359917491-17178-1-git-send-email-beheerder@tekenbeetziekten.nl>\r
+       <1360769577-4861-1-git-send-email-beheerder@tekenbeetziekten.nl>\r
+User-Agent: Notmuch/0.15.1 (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 16 Feb 2013 07:37:37 -0400\r
+Message-ID: <87halc7am6.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-Spam_bar: -\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 16 Feb 2013 11:37:54 -0000\r
+\r
+Robert Mast <beheerder@tekenbeetziekten.nl> writes:\r
+\r
+> Using char instead of int allows for simpler definitions of the\r
+> DOCIDSET macros so the code is easier to understand and consistent with\r
+> respect to memory-usage. Estimated reduction of memory-usage for\r
+> bitmap about 8 times.\r
+\r
+Pushed to master.\r
+\r
+I did a bit of testing, and this yields about a 7% improvement in the\r
+total memory allocated on the medium corpus (running\r
+performance-tests/M00-new) and about a 3% speedup running the large\r
+corpus.  These are definitely improvements worth having, but I think I\r
+won't push it to the bug fix release, but rather wait for the next\r
+regular release.\r
+\r
+d\r
+\r
+\r