Re: [PATCH v4 5/6] cli: search: Add configurable way to filter out duplicate addresses

diff --git a/9a/2e7538208477a8b9b966e1cd88172cf86644f5 b/9a/2e7538208477a8b9b966e1cd88172cf86644f5
new file mode 100644 (file)
index 0000000..058d744
--- /dev/null
+++ b/9a/2e7538208477a8b9b966e1cd88172cf86644f5
@@ -0,0 +1,84 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1E9EB431FC7\r
+       for <notmuch@notmuchmail.org>; Thu, 30 Oct 2014 01:53:11 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id O8M4nRfoqhYj for <notmuch@notmuchmail.org>;\r
+       Thu, 30 Oct 2014 01:53:03 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 68B5C431FB6\r
+       for <notmuch@notmuchmail.org>; Thu, 30 Oct 2014 01:53:03 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 548E4100051;\r
+       Thu, 30 Oct 2014 10:52:43 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Mark Walters <markwalters1009@gmail.com>,\r
+       Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v4 5/6] cli: search: Add configurable way to\r
+       filter  out     duplicate addresses\r
+In-Reply-To: <87egtqug4t.fsf@qmul.ac.uk>\r
+References: <1414421455-3037-1-git-send-email-sojkam1@fel.cvut.cz>\r
+       <1414421455-3037-6-git-send-email-sojkam1@fel.cvut.cz>\r
+       <87egtqug4t.fsf@qmul.ac.uk>\r
+User-Agent: Notmuch/0.18.1+130~ga61922f (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Thu, 30 Oct 2014 10:52:43 +0200\r
+Message-ID: <m2zjceueg4.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 30 Oct 2014 08:53:11 -0000\r
+\r
+On Thu, Oct 30 2014, Mark Walters <markwalters1009@gmail.com> wrote:\r
+\r
+> On Mon, 27 Oct 2014, Michal Sojka <sojkam1@fel.cvut.cz> wrote:\r
+>> This adds an algorithm to filter out duplicate addresses from address\r
+>> outputs (sender, receivers). The algorithm can be configured with\r
+>> --filter-by command line option.\r
+>>\r
+>> The code here is an extended version of a patch from Jani Nikula.\r
+>\r
+> Hi\r
+>\r
+> As this is getting into the more controversial bike shedding region I\r
+> wonder if it would be worth splitting this into 2 patches: the first\r
+> could do the default dedupe based on name/address and the second could\r
+> do add the filter-by options. \r
+>\r
+> I think the default deduping is obviously worth doing but I am not sure\r
+> about the rest. In any case I think the default deduping could go in\r
+> pre-freeze but I would recommend the rest is left until after.\r
+\r
+I can agree with that, but there is one hard thing to resolve: \r
+"naming things"(*)\r
+\r
+(*) http://martinfowler.com/bliki/TwoHardThings.html\r
+\r
+With all rest ignored (sorry no time to work on this in more detail now),\r
+this default deduping could be done with single argument '--unique'...\r
+\r
+Tomi\r
+\r