Re: [PATCH] emacs: initialize ido mode in notmuch-mua.el

diff --git a/7a/6502b659211f51fa6c1c84e3d22abbf155d8ed b/7a/6502b659211f51fa6c1c84e3d22abbf155d8ed
new file mode 100644 (file)
index 0000000..1545f0f
--- /dev/null
+++ b/7a/6502b659211f51fa6c1c84e3d22abbf155d8ed
@@ -0,0 +1,94 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 23740431FBD\r
+       for <notmuch@notmuchmail.org>; Sat, 25 Jan 2014 13:27:56 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id oxzFRsY9auLy for <notmuch@notmuchmail.org>;\r
+       Sat, 25 Jan 2014 13:27:48 -0800 (PST)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 8C61E431FBC\r
+       for <notmuch@notmuchmail.org>; Sat, 25 Jan 2014 13:27:48 -0800 (PST)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 109801000B3;\r
+       Sat, 25 Jan 2014 23:27:39 +0200 (EET)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: David Bremner <david@tethera.net>,\r
+ Mark Walters <markwalters1009@gmail.com>,     notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: initialize ido mode in notmuch-mua.el\r
+In-Reply-To: <87bnyzoqq9.fsf@zancas.localnet>\r
+References: <87y5sipcjn.fsf@qmul.ac.uk>\r
+       <1329900529-16295-1-git-send-email-markwalters1009@gmail.com>\r
+       <87bnyzoqq9.fsf@zancas.localnet>\r
+User-Agent: Notmuch/0.17+41~g8e7fabf (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sat, 25 Jan 2014 23:27:38 +0200\r
+Message-ID: <m2a9ejkb05.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 25 Jan 2014 21:27:56 -0000\r
+\r
+On Sat, Jan 25 2014, David Bremner <david@tethera.net> wrote:\r
+\r
+> Mark Walters <markwalters1009@gmail.com> writes:\r
+>\r
+>> ido-completing-read is used in notmuch-mua.el without any\r
+>> initialization.  This should work but a bug (emacs bug #3247) in some\r
+>> emacs 23 versions (including 23.2.1 from Debian stable) causes emacs\r
+>> to get stuck in the mini-buffer. This tests to see if ido-mode has\r
+>> been initialized and if not calls it. This avoids the bug for these\r
+>> older versions of emacs.\r
+>>\r
+>> This is the only place that ido-completing-read is used so an alternative \r
+>> would be to replace ido-completing-read by completing-read but cworth \r
+>> expressed a preference for the ido version in \r
+>> id:"87wrhfvk6a.fsf@yoom.home.cworth.\r
+>\r
+> This patch was tagged wip, but then there was no progress ;).  It still\r
+> applies cleanly, and doesn't seem to do any harm in emacs 23.4 nor\r
+> emacs24.3. I don't have 23.2 at hand but I guess Tomi or Mark can\r
+> confirm it actually fixes the bug there.\r
+>\r
+> I propose we either apply the patch or ::wontfix the bug.\r
+\r
+How about doing it with defadvice with something like:\r
+\r
+(from http://comments.gmane.org/gmane.emacs.bugs/27856 one can notice\r
+this happening with emacs 23.3 -- David can check whether 23.4 if\r
+affected)\r
+\r
+(if (and (= emacs-major-version 23) (< emacs-minor-version 4))\r
+  (defadvice ido-completing-read (before notmuch-ido-mode-init activate)\r
+      (unless (ido-mode) (ido-mode t))\r
+      (ad-disable-advice 'ido-completing-read 'before 'notmuch-ido-mode-init)))\r
+\r
+>\r
+> cheers,\r
+>\r
+> d\r
+\r
+\r
+Tomi\r