Re: [PATCH 3/4] nmbug: Catch stderr in is_unmerged

diff --git a/ff/55cdbdd5a3aefdbb8241fcaba3d17a4bb6ede5 b/ff/55cdbdd5a3aefdbb8241fcaba3d17a4bb6ede5
new file mode 100644 (file)
index 0000000..511ed44
--- /dev/null
+++ b/ff/55cdbdd5a3aefdbb8241fcaba3d17a4bb6ede5
@@ -0,0 +1,97 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1EA1B431FC0\r
+       for <notmuch@notmuchmail.org>; Wed, 16 Jul 2014 03:04:31 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id uQ-Xmsx8J0LT for <notmuch@notmuchmail.org>;\r
+       Wed, 16 Jul 2014 03:04:23 -0700 (PDT)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 78AFF431FBD\r
+       for <notmuch@notmuchmail.org>; Wed, 16 Jul 2014 03:04:23 -0700 (PDT)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1X7M4U-0005SP-Th; Wed, 16 Jul 2014 07:04:22 -0300\r
+Received: (nullmailer pid 6752 invoked by uid 1000); Wed, 16 Jul 2014\r
+       10:04:19 -0000\r
+From: David Bremner <bremner@debian.org>\r
+To: "W. Trevor King" <wking@tremily.us>\r
+Subject: Re: [PATCH 3/4] nmbug: Catch stderr in is_unmerged\r
+In-Reply-To: <20140716001730.GI30232@odin>\r
+References: <cover.1404678709.git.wking@tremily.us>\r
+       <d55cf02465c5f2d83f2dd0bc666831ee524b0fb7.1404678709.git.wking@tremily.us>\r
+       <871ttm89nd.fsf@maritornes.cs.unb.ca> <20140716001730.GI30232@odin>\r
+User-Agent: Notmuch/0.18.1+45~gf47eeac (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Wed, 16 Jul 2014 07:04:19 -0300\r
+Message-ID: <87y4vt8vrw.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=utf-8\r
+Content-Transfer-Encoding: quoted-printable\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 16 Jul 2014 10:04:31 -0000\r
+\r
+"W. Trevor King" <wking@tremily.us> writes:\r
+\r
+>\r
+> There should be standard Perl syntax for capturing both streams ;).  I\r
+> can add a separate parameter instead, but Perl doesn't seem to have\r
+> keyword-arguments.  At least, nmbug relies on assumptions about\r
+> argument values:\r
+>\r
+>   sub git_pipe {\r
+>     my $envref =3D (ref $_[0] eq 'HASH') ? shift : {};\r
+>     my $ioref  =3D (ref $_[0] eq 'ARRAY') ? shift : undef;\r
+>     my $dir =3D ($_[0] eq '-|' or $_[0] eq '|-') ? shift : undef;\r
+>     =E2=80=A6\r
+>   }\r
+>\r
+\r
+Perl supports keyword arguments fine, by passing a single hash=20\r
+to the subroutine. This particular sub doesn't do things that way, but\r
+it's only called in three places, so it would be simple enough to change\r
+the calling convention to to\r
+\r
+git_pipe (env =3D> {}, lines=3D>[],=20\r
+         command =3D> [  qw/diff-index --cached/,\r
+                "--diff-filter=3D$filter", qw/--name-only HEAD/ ],\r
+         redirect =3D> [ whatever you want here ]=20=20=20=20=20=20=20=20=\r
+=20=20=20=20=20=20=20=20=20\r
+         )\r
+\r
+\r
+>  I'd be happy to rewrite nmbug in Python too, which has (to my eyes)\r
+> much saner kwargs and subprocess handling.\r
+\r
+Although I think that's an extreme answer to this particular issue ;), I\r
+do think it's worth discussing. In particular I think it would be\r
+reasonable to consider an updated nmbug that used the python bindings to\r
+notmuch, for possibly more speed. Of the people that currently work on\r
+nmbug (I count myself, yourself, and Tomi), I think we're all ok with\r
+python.  I know at least Jani mentioned he'd be more interested in\r
+contributing to a python version.\r
+\r
+d\r
+\r