--- /dev/null
+Return-Path: <markwalters1009@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 15E54431FC2\r
+ for <notmuch@notmuchmail.org>; Tue, 13 May 2014 05:05:49 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.201\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.201 tagged_above=-999 required=5\r
+ tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+ FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001,\r
+ RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id r6kD6k3nXhCH for <notmuch@notmuchmail.org>;\r
+ Tue, 13 May 2014 05:05:40 -0700 (PDT)\r
+Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com\r
+ [209.85.212.182]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id A4BFC431FBD\r
+ for <notmuch@notmuchmail.org>; Tue, 13 May 2014 05:05:40 -0700 (PDT)\r
+Received: by mail-wi0-f182.google.com with SMTP id r20so460412wiv.3\r
+ for <notmuch@notmuchmail.org>; Tue, 13 May 2014 05:05:39 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+ h=from:to:subject:in-reply-to:references:user-agent:date:message-id\r
+ :mime-version:content-type;\r
+ bh=R8ogC98n158X26oLlc63Rb84tVT0Mx/FLv6hRrVGOjs=;\r
+ b=clIlwUULTjT8EJTnwNFE52fe6dl7ARC8KTshyvSBzhXmBj+TKWuP7XBulkw9REdqzY\r
+ FzOQjXMiAIyqEnlX2Ffo7nJ87C/ycqF2i4MbRZD8cUAc3VwawRNbuuou38m0IQrSoHwH\r
+ KlL+3JsftAMqXDKn2XrKZhZvcBPB0ZPrW2LPL+K8YoOtM4YLGCylUfCpdBeTZ974iTyM\r
+ DVs2+GSQWDEQQqX9+VdP6q/HPF433Tq3RXlK3IrrqO8w/hAsdhkRYeJM8vlvEl+NQykt\r
+ SM4xpzZpisVH/Xumlkg3J6It1Gj2qRCLTONUNniDLOWsiNHiLGPlxC3g9MiKkBu4GIrQ\r
+ UQAA==\r
+X-Received: by 10.180.212.107 with SMTP id nj11mr21082267wic.40.1399982739332;\r
+ Tue, 13 May 2014 05:05:39 -0700 (PDT)\r
+Received: from localhost (5751dfa2.skybroadband.com. [87.81.223.162])\r
+ by mx.google.com with ESMTPSA id\r
+ ed6sm21566629wib.20.2014.05.13.05.05.38 for <multiple recipients>\r
+ (version=TLSv1.2 cipher=RC4-SHA bits=128/128);\r
+ Tue, 13 May 2014 05:05:38 -0700 (PDT)\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v3 0/9] emacs: Improve the cited message included in\r
+ replies\r
+In-Reply-To: <cunvbta5755.fsf@hotblack-desiato.hh.sledj.net>\r
+References: <87sixdujkv.fsf@qmul.ac.uk>\r
+ <1399897769-26809-1-git-send-email-dme@dme.org>\r
+ <87vbtak5uz.fsf@qmul.ac.uk>\r
+ <cunvbta5755.fsf@hotblack-desiato.hh.sledj.net>\r
+User-Agent: Notmuch/0.15.2+615~g78e3a93 (http://notmuchmail.org) Emacs/23.4.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Tue, 13 May 2014 13:05:35 +0100\r
+Message-ID: <87y4y5j33k.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 13 May 2014 12:05:49 -0000\r
+\r
+\r
+On Tue, 13 May 2014, David Edmondson <dme@dme.org> wrote:\r
+> Firstly, I don't think that the code resulting from this patch series is\r
+> beyond improvement - the intention was really only that it be better\r
+> than the current implementation.\r
+>\r
+> On Mon, May 12 2014, Mark Walters wrote:\r
+>> On Mon, 12 May 2014, David Edmondson <dme@dme.org> wrote:\r
+>>> emacs: Improve the cited message included in replies\r
+>>>\r
+>>> I tried to do things in small increments to make it easier to review.\r
+>>>\r
+>>> v2:\r
+>>> - Don't run the text/plain hooks when generating the message to quote.\r
+>>>\r
+>>> v3:\r
+>>> - Remove the 'no-button code, as it's no longer used.\r
+>>> - Control the insertion of part headers using a function.\r
+>>> - Fix the tests.\r
+>>\r
+>> I think I broadly like this series. I haven't thought through all the\r
+>> ramifications yet so this is just some first thoughts. I will also send\r
+>> some comments on individual patches.\r
+>\r
+> Thanks!\r
+>\r
+>> In notmuch-show we go to notmuch-show-insert-part-*/* to\r
+>> notmuch-mm-display-part-inline and then leave the decision to inline to\r
+>> mm-inlined-types. I think this means that, by default, we will not\r
+>> inline signatures amongst other things.\r
+>\r
+> The rule is essentially: whatever text would be shown when the message\r
+> is displayed for reading, without any of the washing.\r
+\r
+Yes I think that is a good rule. That means that essentially all my\r
+comments end up being more a (future) feature request that we make\r
+choosing which parts to view in notmuch-show more configurable.\r
+\r
+I do have a slight worry about whether there are any cases that people\r
+will want parts shown in their emacs-show but not in any reply but I\r
+can't think of any.\r
+\r
+>> So at the least I think we should decide whether we want to override\r
+>> mm-inlined-types.\r
+>\r
+> I'm not really clear on the benefits of this. Could you explain?\r
+\r
+This was just the above slight worry.\r
+\r
+>> Alternatively, and in my view preferably, we could have a function or\r
+>> variable of our own which says which parts to include. Indeed, if do\r
+>> it with a function we might be able to make an option to reply to mean\r
+>> "include parts currently shown in the notmuch-show buffer" which might\r
+>> be nice.\r
+>\r
+> That seems over complicated to me. The rule (above) from this series\r
+> is easy to understand and work with. Other mechanisms could be\r
+> implemented later, of course.\r
+\r
+Yes, as you say, leave this for later (if ever).\r
+>\r
+>> There is a related question and possible bug that we might be able to\r
+>> do something about at the same time: should we include text parts in the\r
+>> reply if they have content-disposition attachment? I have been caught\r
+>> about by this on one occasion replying to a message with a 500K log file\r
+>> attached (and notmuch-show/wash becomes very slow with a 500K\r
+>> message!)\r
+>\r
+> This is really a question of what happens in `show' mode. If it is\r
+> currently displaying text parts with content-disposition attachment,\r
+> that sounds like a bug that should be fixed (which would mean that the\r
+> cited message wouldn't include that part either).\r
+\r
+Yes I agree.\r
+\r
+>> Finally, I am not sure whether I like having buttons in the reply. My\r
+>> instinct is against, but they do add context.\r
+>\r
+> The last patch in the series is an example of trying to do the right\r
+> thing - show the part headers when they are necessary for proper\r
+> understanding, but elide them in all other cases.\r
+>\r
+> The mechanism used to do this is pretty crude in the patch. One could\r
+> imagine a better implementation that examines the depth of the part\r
+> tree, etc.\r
+\r
+OK I will try and review these soon.\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+>\r
+>> Best wishes\r
+>>\r
+>> Mark\r
+>>\r
+>>\r
+>>\r
+>>\r
+>>>\r
+>>>\r
+>>> David Edmondson (9):\r
+>>> emacs/show: Re-arrange determination if a part header is necessary\r
+>>> emacs/show: Allow the user to decide when part headers should be\r
+>>> inserted\r
+>>> emacs/show: Accommodate the lack of part header buttons\r
+>>> emacs/mua: Generate improved cited text for replies\r
+>>> emacs/show: Remove the 'no-buttons option of\r
+>>> `notmuch-show-insert-bodypart'\r
+>>> emacs/mua: Don't insert part headers in citations\r
+>>> test: Update the test output to accord with the reply changes\r
+>>> emacs/mua: Insert part headers depending on the message\r
+>>> test: Update the test output to accord with more reply changes\r
+>>>\r
+>>> emacs/notmuch-mua.el | 82 +++++++++++++++++++-----------\r
+>>> emacs/notmuch-show.el | 135 +++++++++++++++++++++++++++++++-------------------\r
+>>> test/T310-emacs.sh | 44 ++++++++++++++++\r
+>>> 3 files changed, 180 insertions(+), 81 deletions(-)\r
+>>>\r
+>>> -- \r
+>>> 2.0.0.rc0\r
+>>>\r
+>>> _______________________________________________\r
+>>> notmuch mailing list\r
+>>> notmuch@notmuchmail.org\r
+>>> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff