Re: [PATCH] lib: Add a new prefix "list" to the search-terms syntax

diff --git a/0c/689fdde2ec6b5085b3601f3a8f2f81841217bf b/0c/689fdde2ec6b5085b3601f3a8f2f81841217bf
new file mode 100644 (file)
index 0000000..1009f6c
--- /dev/null
+++ b/0c/689fdde2ec6b5085b3601f3a8f2f81841217bf
@@ -0,0 +1,85 @@
+Return-Path: <bremner@unb.ca>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 90164431FB6\r
+       for <notmuch@notmuchmail.org>; Sat,  6 Apr 2013 04:55:07 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id HBz4t5RxMy8o for <notmuch@notmuchmail.org>;\r
+       Sat,  6 Apr 2013 04:55:07 -0700 (PDT)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 0E78F431FAE\r
+       for <notmuch@notmuchmail.org>; Sat,  6 Apr 2013 04:55:07 -0700 (PDT)\r
+Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net\r
+       ([156.34.82.78] helo=zancas.localnet)\r
+       by tesseract.cs.unb.ca with esmtpsa\r
+       (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1UORi5-0008BB-Kw; Sat, 06 Apr 2013 08:55:06 -0300\r
+Received: from bremner by zancas.localnet with local (Exim 4.80)\r
+       (envelope-from <bremner@unb.ca>)\r
+       id 1UORhz-00061H-Pc; Sat, 06 Apr 2013 08:54:59 -0300\r
+From: David Bremner <david@tethera.net>\r
+To: "Alexey I. Froloff" <raorn@raorn.name>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] lib: Add a new prefix "list" to the search-terms syntax\r
+In-Reply-To: <1364996763-19718-1-git-send-email-raorn@raorn.name>\r
+References: <1364996763-19718-1-git-send-email-raorn@raorn.name>\r
+User-Agent: Notmuch/0.15.2+73~g1c450ec (http://notmuchmail.org) Emacs/24.2.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sat, 06 Apr 2013 08:54:59 -0300\r
+Message-ID: <874nfjj2lo.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-Spam_bar: -\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sat, 06 Apr 2013 11:55:07 -0000\r
+\r
+"Alexey I. Froloff" <raorn@raorn.name> writes:\r
+> +\r
+> +    /* Description may be RFC2047 encoded */\r
+> +    char *decoded_desc = g_mime_utils_header_decode_phrase(description);\r
+\r
+Surprisingly, the docs claim g_mime_utils_header_decode_phrase has no\r
+error conditions, so I guess this is OK.\r
+\r
+> +\r
+> +    _notmuch_message_gen_terms(message, "list", list_id);\r
+> +\r
+> +    if (decoded_desc)\r
+> +    _notmuch_message_gen_terms(message, "list", decoded_desc);\r
+> \r
+\r
+On the other hand, _notmuch_message_gen_terms does return a status. I\r
+agree that currently this status is not useful, but that could change in\r
+the future.  I also agree that the existing code does the same thing in\r
+a few places, but I think it's better not to introduce more.\r
+\r
+We'll need a test or two before we introduce a core change.\r
+\r
+Any objections to the list: syntax?  The only issue I see is that at\r
+some point we will probably add a generic header search syntax, and this\r
+implicitly says list-id is more important/common than other headers.\r
+\r
+d\r
+\r
+\r