--- /dev/null
+Return-Path: <jrollins@finestructure.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id CBFED431FC0\r
+ for <notmuch@notmuchmail.org>; Sun, 6 Apr 2014 23:16:37 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.3\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id E4uwXgQxcduc for <notmuch@notmuchmail.org>;\r
+ Sun, 6 Apr 2014 23:16:32 -0700 (PDT)\r
+Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu\r
+ [131.215.239.19])\r
+ by olra.theworths.org (Postfix) with ESMTP id 0FDB4431FBF\r
+ for <notmuch@notmuchmail.org>; Sun, 6 Apr 2014 23:16:32 -0700 (PDT)\r
+Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1])\r
+ by earth-doxen-postvirus (Postfix) with ESMTP id B010066E0120;\r
+ Sun, 6 Apr 2014 23:16:31 -0700 (PDT)\r
+X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new\r
+Received: from finestructure.net (cpe-107-185-189-81.socal.res.rr.com\r
+ [107.185.189.81]) (Authenticated sender: jrollins)\r
+ by earth-doxen-submit (Postfix) with ESMTP id B2DE966E0103;\r
+ Sun, 6 Apr 2014 23:16:30 -0700 (PDT)\r
+Received: by finestructure.net (Postfix, from userid 1000)\r
+ id 5E9A460187; Sun, 6 Apr 2014 23:16:29 -0700 (PDT)\r
+From: Jameson Graef Rollins <jrollins@finestructure.net>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: sign/encrypt replies to signed/encrypted messages\r
+In-Reply-To: <1396689486-19232-1-git-send-email-jani@nikula.org>\r
+References: <87a9f1c8aq.fsf@servo.finestructure.net>\r
+ <1396689486-19232-1-git-send-email-jani@nikula.org>\r
+User-Agent: Notmuch/0.17+174~gaa1f476 (http://notmuchmail.org) Emacs/24.3.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Sun, 06 Apr 2014 23:16:26 -0700\r
+Message-ID: <8738hppsud.fsf@servo.finestructure.net>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+ micalg=pgp-sha256; protocol="application/pgp-signature"\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 07 Apr 2014 06:16:37 -0000\r
+\r
+--=-=-=\r
+Content-Type: text/plain\r
+\r
+On Sat, Apr 05 2014, Jani Nikula <jani@nikula.org> wrote:\r
+> This is a simple approach to improving security when replying to\r
+> signed or encrypted messages. If the message being replied to was\r
+> signed, add mml tag to sign the reply. If the message being replied to\r
+> was encrypted, add mml tag to sign and encrypt the reply.\r
+\r
+Jani, thank you so much for this patch! This is really great, and I\r
+very much appreciate your work on it.\r
+\r
+I've tested it and so far it does exactly as advertised: replys to\r
+encrypted messages automatically get the correct mml tags to encrypt the\r
+reply. I sign all messages by default, and it doesn't seem to interact\r
+adversely with that configuration afaict.\r
+\r
+> This may need configuration; I for one might want to encrypt replies\r
+> to encrypted messages, but not always sign replies to signed messages.\r
+>\r
+> This still includes a slight bug: if any mml tags are added, they are\r
+> included in the region containing the quoted parts. Killing the region\r
+> will kill the mml tags too.\r
+\r
+Both of these issues seem pretty minor to me. It certainly gets my vote\r
+to push without these additional features (especially considering the\r
+security benefits).\r
+\r
+I just have one comment below:\r
+\r
+> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el\r
+> index ba3ef275ec5e..9fb84b57b030 100644\r
+> --- a/emacs/notmuch-mua.el\r
+> +++ b/emacs/notmuch-mua.el\r
+> @@ -224,7 +233,10 @@ list."\r
+> (set-mark (point))\r
+> (goto-char start)\r
+> ;; Quote the original message according to the user's configured style.\r
+> - (message-cite-original))))\r
+> + (message-cite-original)))\r
+> +\r
+> + ;; Sign and/or encrypt replies to signed and/or encrypted messages.\r
+> + (notmuch-mua-reply-crypto (plist-get original :body)))\r
+\r
+Maybe we should check to see if crypto processing is activated before\r
+adding this additional crypto handling. I would have guessed we might\r
+want something like this instead:\r
+\r
+ (when notmuch-show-process-crypto\r
+ (notmuch-mua-reply-crypto (plist-get original :body))))\r
+\r
+However, for some reason I can't get this to work. It looks like\r
+notmuch-show-process-crypto keeps evaluating to false in this context,\r
+regardless of whether crypto processing has been engaged. I'm unclear\r
+why. Anyone know see how notmuch-show-process-crypto would evaluate to\r
+false here, even when it evaluates to true earlier in the same\r
+notmuch-mua-reply call?\r
+\r
+jamie.\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG v1\r
+\r
+iQIcBAEBCAAGBQJTQkK7AAoJEO00zqvie6q89/kP/2sIsdj6C6ltNvufSrTxFpHX\r
+IytJX9+0pfB5Z3BjJ6vEDa3LTaQPmEZdnlcvGvx7Qe1D5ZONljTMR3xMWV4VCbAk\r
+aFK5+Fvs70bChQQkvwjwo1OoZ16EOs/dkS+ZChq7UGJy/1hD1dOh0FV7MBdh/qMV\r
+gjUD3iAvM7ShdvumcVYzE1aOxLfse1+LgKBTwt8yPH3DVHGxx9ixJn4nOqbIq2H7\r
+10sDnLu9sMwqUr3Vt8FFPNuCDMhbFrLMXJVnm/odLKz6xQHfT3cpXEi0TP6KZrww\r
+/VT8I5XtVE5ypmcDyWV18KgjYRNH8U2j6nv73AcP12Dlrc///LmS8gsEsrHq0wEh\r
+8Y6YVwdzr8gRYb+6xNCUarrkP0GY9Oy7pSwZfms8H9mdfYMMVyNU41dpUdo2XSVs\r
+40+Yf0j1gAt8lrAUY0Lry5oMdKFJZnhDk6BCP9TlYW3r0hYUYCl1i72+yPi0Pcio\r
+gG/r2rDqP/6lS0MZUS79EI8k+GOeiKS059gvcHPvzPi6xWXhu5Nn1uL8t8keXTTL\r
+P67IYQCCoMuAXnHt8EKSWpL2OLCemx/2ZMO9JRb+Spknrzj9rx6ButcCydC2LR6G\r
+3/5r6J3/UgT8Sj++hNovTS3xT/AVk1z7l8XThIpzVTQsHLKXiHzh/7pKM1GX7Hn6\r
+87u/MPqXm2Qt6xHBuYri\r
+=BbLW\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r
projects / notmuch-archives.git / commitdiff