--- /dev/null
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id 623B9431FBC\r
+ for <notmuch@notmuchmail.org>; Sun, 27 Jul 2014 02:33:22 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0.502\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0.502 tagged_above=-999 required=5\r
+ tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+ NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id 5VfnxNiHeJML for <notmuch@notmuchmail.org>;\r
+ Sun, 27 Jul 2014 02:33:15 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+ (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+ (No client certificate requested)\r
+ by olra.theworths.org (Postfix) with ESMTPS id CC023431FB6\r
+ for <notmuch@notmuchmail.org>; Sun, 27 Jul 2014 02:33:14 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+ by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1XBKpG-0005Xp-DE; Sun, 27 Jul 2014 10:33:09 +0100\r
+Received: from 94.196.249.126.threembb.co.uk ([94.196.249.126] helo=localhost)\r
+ by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)\r
+ (envelope-from <m.walters@qmul.ac.uk>)\r
+ id 1XBKpF-0002Rm-M5; Sun, 27 Jul 2014 10:33:06 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 04/14] new: Don't report version after upgrade\r
+In-Reply-To: <1406433173-19169-5-git-send-email-amdragon@mit.edu>\r
+References: <1406433173-19169-1-git-send-email-amdragon@mit.edu>\r
+ <1406433173-19169-5-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.15.2+615~g78e3a93 (http://notmuchmail.org) Emacs/23.4.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Sun, 27 Jul 2014 10:33:02 +0100\r
+Message-ID: <87y4vfywmp.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 94.196.249.126\r
+X-QM-Geographic: According to ripencc,\r
+ this message was delivered by a machine in Britain (UK) (GB).\r
+X-QM-SPAM-Info: Sender has good ham record. :)\r
+X-QM-Body-MD5: ce1ec861b7e9488729ea4d284c3c3b54 (of first 20000 bytes)\r
+X-SpamAssassin-Score: -0.1\r
+X-SpamAssassin-SpamBar: /\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+ determine if it is\r
+ spam. We require at least 5.0 points to mark a message as spam.\r
+ This message scored -0.1 points.\r
+ Summary of the scoring: \r
+ * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+ provider * (markwalters1009[at]gmail.com)\r
+ * -0.1 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 27 Jul 2014 09:33:22 -0000\r
+\r
+On Sun, 27 Jul 2014, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> The version number has always been pretty meaningless to the user and\r
+> it's about to become even more meaningless with the introduction of\r
+> "features". Hopefully, the database will remain on version 3 for some\r
+> time to come; however, the introduction of new features over time in\r
+> version 3 will necessitate upgrades within version 3. It would be\r
+> confusing if we always tell the user they've been "upgraded to version\r
+> 3". If the user wants to know what's new, they should read the news.\r
+\r
+Two thoughts on this: \r
+\r
+first, we could print the names of the new features here to make it\r
+easier for the user to find them in NEWS. \r
+\r
+Secondly, would it be worth having something like notmuch\r
+--database-version or similar which prints the features? If I understand\r
+the series then notmuch clients don't necessarily need to upgrade the\r
+database unless they want the new features. This means that knowing what\r
+version they are running might not tell us which features they have\r
+enabled (which could make debugging difficult)\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+> ---\r
+> notmuch-new.c | 3 +--\r
+> test/T530-upgrade.sh | 2 +-\r
+> 2 files changed, 2 insertions(+), 3 deletions(-)\r
+>\r
+> diff --git a/notmuch-new.c b/notmuch-new.c\r
+> index d269c7c..b7590a8 100644\r
+> --- a/notmuch-new.c\r
+> +++ b/notmuch-new.c\r
+> @@ -1023,8 +1023,7 @@ notmuch_new_command (notmuch_config_t *config, int argc, char *argv[])\r
+> add_files_state.verbosity >= VERBOSITY_NORMAL ? upgrade_print_progress : NULL,\r
+> &add_files_state);\r
+> if (add_files_state.verbosity >= VERBOSITY_NORMAL)\r
+> - printf ("Your notmuch database has now been upgraded to database format version %u.\n",\r
+> - notmuch_database_get_version (notmuch));\r
+> + printf ("Your notmuch database has now been upgraded.\n");\r
+> }\r
+> \r
+> add_files_state.total_files = 0;\r
+> diff --git a/test/T530-upgrade.sh b/test/T530-upgrade.sh\r
+> index 7d5d5aa..c4c4ac8 100755\r
+> --- a/test/T530-upgrade.sh\r
+> +++ b/test/T530-upgrade.sh\r
+> @@ -33,7 +33,7 @@ test_expect_equal "$output" "\\r
+> Welcome to a new version of notmuch! Your database will now be upgraded.\r
+> This process is safe to interrupt.\r
+> Backing up tags to FILENAME\r
+> -Your notmuch database has now been upgraded to database format version 2.\r
+> +Your notmuch database has now been upgraded.\r
+> No new mail."\r
+> \r
+> test_begin_subtest "tag backup matches pre-upgrade dump"\r
+> -- \r
+> 2.0.0\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r
projects / notmuch-archives.git / commitdiff