Re: [PATCH 0/2] Enhancements to notmuch-hello search history

diff --git a/b1/6aa0e1adab2adda4dc20debad670f7d71cb77c b/b1/6aa0e1adab2adda4dc20debad670f7d71cb77c
new file mode 100644 (file)
index 0000000..af4b8e2
--- /dev/null
+++ b/b1/6aa0e1adab2adda4dc20debad670f7d71cb77c
@@ -0,0 +1,85 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id B2201431FAF\r
+       for <notmuch@notmuchmail.org>; Sun,  5 May 2013 02:59:00 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id WJHAzXpA9uC5 for <notmuch@notmuchmail.org>;\r
+       Sun,  5 May 2013 02:58:56 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 81A67431FAE\r
+       for <notmuch@notmuchmail.org>; Sun,  5 May 2013 02:58:56 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 363B6100033;\r
+       Sun,  5 May 2013 12:58:55 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Servilio Afre Puentes <servilio@gmail.com>, Jani Nikula <jani@nikula.org>,\r
+       notmuch <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH 0/2] Enhancements to notmuch-hello search history\r
+In-Reply-To: <87ppx6lo6g.fsf@goose.CSU.McMaster.CA>\r
+References: <87y5bwkml2.fsf@goose.CSU.McMaster.CA> <874nejrupr.fsf@nikula.org>\r
+       <87ppx6lo6g.fsf@goose.CSU.McMaster.CA>\r
+User-Agent: Notmuch/0.15.2+75~gd7fa7c4 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Sun, 05 May 2013 12:58:54 +0300\r
+Message-ID: <m2li7teoip.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 05 May 2013 09:59:00 -0000\r
+\r
+On Sat, May 04 2013, Servilio Afre Puentes <servilio@gmail.com> wrote:\r
+\r
+> Jani Nikula <jani@nikula.org> writes:\r
+>\r
+>> On Fri, 03 May 2013, Servilio Afre Puentes <servilio@gmail.com> wrote:\r
+>>> Two patches that enhance the notmuch-hello search history UI. Though\r
+>>> minor I find them very helpful.\r
+>>\r
+>> Both seem to work as advertised; I did not look at the code much.  A\r
+>> minor bikeshed is that I think y-or-n-p would suffice in patch 1/2.\r
+>\r
+> I know, but as it clears the whole history I decided to go with a\r
+> confirmation that required more attention to diminish the chance of\r
+> accident, and the action is taken not so oftenly (at least for me, and\r
+> my guess is that it is the same for most) so it stills balances out\r
+> positively in the usability.\r
+\r
+I tested the patch and it works as advertised.\r
+\r
+I agree with Jani that y-or-n-p would suffice for clearing all\r
+recent searches (but yes-or-no-p is not so bad as I originally thought\r
+as C-g can be used to stop processing (typoing 'no' is too easy ;/). \r
+\r
+If we could use "undo" feature to restore last clear/del then I'd agree\r
+100% with Mark (i.e. no y-or-n-p for [del]).\r
+\r
+In any case fix at least the style issue Mark mentioned -- any of the\r
+yes/no queries will eventually be fine with me (as I don't know without\r
+experience what would be the best (for me) after all).\r
+\r
+> Servilio\r
+\r
+Tomi\r