Re: [notmuch] Notmuch doesn't index new mails when mail location contains symlinks

diff --git a/1c/ffd67af3d9c4d5f8bfd34c0e6b4a0a623248f8 b/1c/ffd67af3d9c4d5f8bfd34c0e6b4a0a623248f8
new file mode 100644 (file)
index 0000000..d5c1455
--- /dev/null
+++ b/1c/ffd67af3d9c4d5f8bfd34c0e6b4a0a623248f8
@@ -0,0 +1,83 @@
+Return-Path: <five9a2@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id EEC6A431FAE\r
+       for <notmuch@notmuchmail.org>; Thu, 26 Nov 2009 13:21:52 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id Gpi5eBc7WVNB for <notmuch@notmuchmail.org>;\r
+       Thu, 26 Nov 2009 13:21:52 -0800 (PST)\r
+Received: from mail-bw0-f224.google.com (mail-bw0-f224.google.com\r
+       [209.85.218.224])\r
+       by olra.theworths.org (Postfix) with ESMTP id 91001431FBC\r
+       for <notmuch@notmuchmail.org>; Thu, 26 Nov 2009 13:21:52 -0800 (PST)\r
+Received: by bwz24 with SMTP id 24so840369bwz.30\r
+       for <notmuch@notmuchmail.org>; Thu, 26 Nov 2009 13:21:50 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;\r
+       h=domainkey-signature:received:received:sender:from:to:cc:subject\r
+       :in-reply-to:references:date:message-id:mime-version:content-type;\r
+       bh=P4sQvcLYOUk0BUbvbFa+3aCaewGXMSPPoqrPgfc2r4o=;\r
+       b=JRD+XWKpLcCmxEY2lU+QXCzHUQDO0GevWwt6WsAO154UR8s/iQ5+nPoaHAP+0IWoO7\r
+       +9rTf0uiD5fFYZOxo46OJ1dlRgqVrR5HkDFiZRU+982fXGaENtE4leuxU/EKJNuwtWfe\r
+       S5ZsitBa5ON0z9DMB0JwNspmVOqiQNEhb1l3A=\r
+DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;\r
+       h=sender:from:to:cc:subject:in-reply-to:references:date:message-id\r
+       :mime-version:content-type;\r
+       b=hz+XV7zIoeYCe6gg5qyurYV08wltn/5bC4P7kFB+vFQsC8ZgR2hrAitjk/J5LLY6Qa\r
+       AfiVBR9TjNu6hhEIA1WcD+DqVl3/XzlgJ9vbkWctQh6B6+z/kz/AXzFKTXRqf6oSqFAX\r
+       3JpiQuDIaqOBuondHtRDTCaackiCXHO3ZI4Ec=\r
+Received: by 10.204.175.2 with SMTP id v2mr217689bkz.197.1259270510719;\r
+       Thu, 26 Nov 2009 13:21:50 -0800 (PST)\r
+Received: from kunyang (vawpc43.ethz.ch [129.132.59.11])\r
+       by mx.google.com with ESMTPS id 2sm1398839fks.43.2009.11.26.13.21.48\r
+       (version=TLSv1/SSLv3 cipher=RC4-MD5);\r
+       Thu, 26 Nov 2009 13:21:49 -0800 (PST)\r
+Sender: Jed Brown <five9a2@gmail.com>\r
+From: Jed Brown <jed@59A2.org>\r
+To: Carl Worth <cworth@cworth.org>, Tassilo Horn <tassilo@member.fsf.org>,\r
+       Mikhail Gusarov <dottedmag@dottedmag.net>\r
+In-Reply-To: <87ljhtq98x.fsf@yoom.home.cworth.org>\r
+References: <87ws1hldmu.fsf@thinkpad.tsdh.de>\r
+       <87einpl50j.fsf@thinkpad.tsdh.de> <87ljhxjq5i.fsf@vertex.dottedmag>\r
+       <876391l2si.fsf@thinkpad.tsdh.de> <87vdh1472z.fsf@59A2.org>\r
+       <871vjlrv8b.fsf@yoom.home.cworth.org> <873a41dtbu.fsf@59A2.org>\r
+       <87ljhtq98x.fsf@yoom.home.cworth.org>\r
+Date: Thu, 26 Nov 2009 22:22:24 +0100\r
+Message-ID: <87zl69c773.fsf@59A2.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Cc: notmuch@notmuchmail.org\r
+Subject: Re: [notmuch] Notmuch doesn't index new mails when mail location\r
+ contains symlinks\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.12\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 26 Nov 2009 21:21:53 -0000\r
+\r
+On Thu, 26 Nov 2009 13:14:22 -0800, Carl Worth <cworth@cworth.org> wrote:\r
+\r
+> Then I'm still being really dense here. The non-propagation of mtime is\r
+> the with actual directories. And the code is trying to do the right\r
+> thing for that.\r
+\r
+The stat() is correct, it's the check for the d_type field coming out of scandir().\r
+\r
+20:08 [   jedbrown  ] cworth: I think there are two problems with symlinks.\r
+20:08 [   jedbrown  ] cworth: First, notmuch-new.c:152 checks path_mtime which is mtime for the current directory.\r
+20:09 [   jedbrown  ] cworth: Additionally, won't entry->d_type == DT_LNK for a symlink?\r
+20:14 [     aneesh  ] jedbrown,  i already have a patch posted for that\r
+20:15 [     aneesh  ] 1259125104-18785-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com\r
+\r
+\r
+Jed\r