Re: [PATCH v2] emacs: Make the part content available to the mm-inline* checks.

diff --git a/1d/2134b2e307064ec102474f71fd1415ec353d74 b/1d/2134b2e307064ec102474f71fd1415ec353d74
new file mode 100644 (file)
index 0000000..e9643c4
--- /dev/null
+++ b/1d/2134b2e307064ec102474f71fd1415ec353d74
@@ -0,0 +1,106 @@
+Return-Path: <dmitry.kurochkin@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 85B37431FAF\r
+       for <notmuch@notmuchmail.org>; Wed, 18 Jan 2012 12:00:02 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.799\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id zHi5-n7V7cN3 for <notmuch@notmuchmail.org>;\r
+       Wed, 18 Jan 2012 12:00:01 -0800 (PST)\r
+Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com\r
+       [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 3FF3C431FAE\r
+       for <notmuch@notmuchmail.org>; Wed, 18 Jan 2012 12:00:01 -0800 (PST)\r
+Received: by bkty12 with SMTP id y12so2058201bkt.26\r
+       for <notmuch@notmuchmail.org>; Wed, 18 Jan 2012 11:59:59 -0800 (PST)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;\r
+       h=from:to:cc:subject:in-reply-to:references:user-agent:date\r
+       :message-id:mime-version:content-type;\r
+       bh=Fh2VTPS5qFSDWXtBPzTI9lJhDrUoc4vERx1XFQpoePY=;\r
+       b=SQRYRVRBetb0UR1IPJNPbuk3de7m9ZITzbOQqliVvrA7yAkdXTEQ9ixlZUjsgYo3yL\r
+       4JJNvyGfrowYDreh/vCs7IeowQ8ZxLKEVSYUQEzwideGUou1Of3Fr8wbL1WFytc4+uLO\r
+       641RzR7W5R3S7qOS2r8N5gfiT2Fmw86wivvXU=\r
+Received: by 10.204.133.213 with SMTP id g21mr9188793bkt.126.1326916799643;\r
+       Wed, 18 Jan 2012 11:59:59 -0800 (PST)\r
+Received: from localhost ([91.144.186.21])\r
+       by mx.google.com with ESMTPS id n9sm57053093bkg.8.2012.01.18.11.59.58\r
+       (version=TLSv1/SSLv3 cipher=OTHER);\r
+       Wed, 18 Jan 2012 11:59:58 -0800 (PST)\r
+From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
+To: Austin Clements <amdragon@MIT.EDU>\r
+Subject: Re: [PATCH v2] emacs: Make the part content available to the\r
+       mm-inline* checks.\r
+In-Reply-To: <20120118193501.GG16740@mit.edu>\r
+References: <1326907993-11054-1-git-send-email-dme@dme.org>\r
+       <1326908371-11949-1-git-send-email-dme@dme.org>\r
+       <877h0o99aj.fsf@gmail.com>\r
+       <cunlip47tir.fsf@hotblack-desiato.hh.sledj.net>\r
+       <874nvs96ps.fsf@gmail.com> <20120118193501.GG16740@mit.edu>\r
+User-Agent: Notmuch/0.11+73~g8a5402e (http://notmuchmail.org) Emacs/23.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Wed, 18 Jan 2012 23:59:03 +0400\r
+Message-ID: <87zkdk7pfc.fsf@gmail.com>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 18 Jan 2012 20:00:02 -0000\r
+\r
+On Wed, 18 Jan 2012 14:35:01 -0500, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> Quoth Dmitry Kurochkin on Jan 18 at 11:00 pm:\r
+> > On Wed, 18 Jan 2012 18:30:36 +0000, David Edmondson <dme@dme.org> wrote:\r
+> > > On Wed, 18 Jan 2012 22:04:36 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:\r
+> > > > On Wed, 18 Jan 2012 17:39:31 +0000, David Edmondson <dme@dme.org> wrote:\r
+> > > > > The `mm-inlinable-p' and `mm-inlined-p' functions work better if they\r
+> > > > > have access to the data of the relevant part, so load that content\r
+> > > > > before calling either function.\r
+> > > > > \r
+> > > > > This fixes the display of attached image/jpeg parts, for example.\r
+> > > > \r
+> > > > Not so long ago I made an opposite change to avoid fetching useless\r
+> > > > parts (e.g. audio files).  Looks like we need a better check here.  Can\r
+> > > > we know from Content-Type if fetching a part body would be useful?\r
+> > > \r
+> > > What if `notmuch-show-insert-part-*/*' consulted a list of content-type\r
+> > > regexps to attempt to inline?\r
+> > > \r
+> > > That would allow a sane default (("image/*" "text/*") perhaps), but also\r
+> > > allow more to be added to that list (or some to be removed), either by\r
+> > > code that detected the (in)ability to render it or the user.\r
+> > \r
+> > Perhaps there is such a list in mm already?\r
+> \r
+> Shouldn't we only be doing this for parts with inline (or not\r
+> attachment) content-disposition?  That's cheap to check.  Or do we\r
+> actually want things like image attachments to get inlined, despite\r
+> their disposition?\r
+\r
+It may be good to have this behavior configurable.  I would like Emacs\r
+to display all part types that it can, independent from\r
+content-disposition.\r
+\r
+Anyway, this is a separate issue.  In any case we want to fetch part\r
+body only if it is useful.\r
+\r
+Regards,\r
+  Dmitry\r