Re: [PATCH] contrib: pick: use the sexp parser
authorMark Walters <markwalters1009@gmail.com>
Sun, 2 Jun 2013 12:01:12 +0000 (13:01 +0100)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 17:55:17 +0000 (09:55 -0800)
9d/1bd50ae0e954e9ef041c8a61d1db1c7cfaaf43 [new file with mode: 0644]

diff --git a/9d/1bd50ae0e954e9ef041c8a61d1db1c7cfaaf43 b/9d/1bd50ae0e954e9ef041c8a61d1db1c7cfaaf43
new file mode 100644 (file)
index 0000000..5a751f1
--- /dev/null
@@ -0,0 +1,124 @@
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id D95DD429E2F\r
+       for <notmuch@notmuchmail.org>; Sun,  2 Jun 2013 05:01:31 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 1.401\r
+X-Spam-Level: *\r
+X-Spam-Status: No, score=1.401 tagged_above=-999 required=5\r
+       tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+       FREEMAIL_REPLY=2.499, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id fnVLm9Tdlvlr for <notmuch@notmuchmail.org>;\r
+       Sun,  2 Jun 2013 05:01:23 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id AE19D431E64\r
+       for <notmuch@notmuchmail.org>; Sun,  2 Jun 2013 05:01:22 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+       by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1Uj6yK-0007SV-6W; Sun, 02 Jun 2013 13:01:18 +0100\r
+Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)\r
+       by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1Uj6yJ-0003rX-Vy; Sun, 02 Jun 2013 13:01:16 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] contrib: pick: use the sexp parser\r
+In-Reply-To: <m2r4gllfo6.fsf@guru.guru-group.fi>\r
+References: <1370113483-10081-1-git-send-email-markwalters1009@gmail.com>\r
+       <m2r4gllfo6.fsf@guru.guru-group.fi>\r
+User-Agent: Notmuch/0.14+255~gff3cc55 (http://notmuchmail.org) Emacs/23.4.1\r
+       (i486-pc-linux-gnu)\r
+Date: Sun, 02 Jun 2013 13:01:12 +0100\r
+Message-ID: <87sj10g1rr.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+X-Sender-Host-Address: 93.97.24.31\r
+X-QM-SPAM-Info: Sender has good ham record.  :)\r
+X-QM-Body-MD5: 4930dc4cc7c3fcae0bcc227ef1a65ba0 (of first 20000 bytes)\r
+X-SpamAssassin-Score: 0.5\r
+X-SpamAssassin-SpamBar: /\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+       determine if it is\r
+       spam. We require at least 5.0 points to mark a message as spam.\r
+       This message scored 0.5 points. Summary of the scoring: \r
+       * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+       provider *      (markwalters1009[at]gmail.com)\r
+       *  1.0 FREEMAIL_REPLY From and body contain different freemails\r
+       * -0.5 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 02 Jun 2013 12:01:32 -0000\r
+\r
+\r
+Tomi Ollila <tomi.ollila@iki.fi> writes:\r
+\r
+> These trivial changes look good -- is sexp already supported in show ?\r
+\r
+At the moment sexp is not supported in show (despite that using\r
+synchronous command so it is much easier). I posted a (not good) at\r
+id:1354975891-24663-1-git-send-email-markwalters1009@gmail.com and in\r
+Austin's reply he suggested a much better way of doing is. But I never posted a\r
+corrected version (perhaps I was waiting for the error handling stuff to\r
+clear?).\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+>\r
+> Tomi\r
+>\r
+>>\r
+>>  contrib/notmuch-pick/notmuch-pick.el |    5 ++---\r
+>>  1 files changed, 2 insertions(+), 3 deletions(-)\r
+>>\r
+>> diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el\r
+>> index 128fabf..33905d6 100644\r
+>> --- a/contrib/notmuch-pick/notmuch-pick.el\r
+>> +++ b/contrib/notmuch-pick/notmuch-pick.el\r
+>> @@ -773,8 +773,7 @@ Complete list of currently available key bindings:\r
+>>          (save-excursion\r
+>>            (goto-char (point-max))\r
+>>            (insert string))\r
+>> -   (notmuch-json-parse-partial-list 'notmuch-pick-insert-forest-thread\r
+>> -                                    'notmuch-pick-show-error\r
+>> +   (notmuch-sexp-parse-partial-list 'notmuch-pick-insert-forest-thread\r
+>>                                      results-buf)))))\r
+>>  \r
+>>  (defun notmuch-pick-worker (basic-query &optional query-context target buffer)\r
+>> @@ -796,7 +795,7 @@ Complete list of currently available key bindings:\r
+>>      (if notmuch-pick-asynchronous-parser\r
+>>     (let ((proc (start-process\r
+>>                  "notmuch-pick" buffer\r
+>> -                notmuch-command "show" "--body=false" "--format=json"\r
+>> +                notmuch-command "show" "--body=false" "--format=sexp"\r
+>>                  message-arg search-args))\r
+>>           ;; Use a scratch buffer to accumulate partial output.\r
+>>                ;; This buffer will be killed by the sentinel, which\r
+>> -- \r
+>> 1.7.9.1\r
+>>\r
+>> _______________________________________________\r
+>> notmuch mailing list\r
+>> notmuch@notmuchmail.org\r
+>> http://notmuchmail.org/mailman/listinfo/notmuch\r