Re: [PATCH 2/2] notmuch-reply.c: uncrustify

diff --git a/3b/b914e91184359a806105d5c8883abe9c0851a8 b/3b/b914e91184359a806105d5c8883abe9c0851a8
new file mode 100644 (file)
index 0000000..fcd998e
--- /dev/null
+++ b/3b/b914e91184359a806105d5c8883abe9c0851a8
@@ -0,0 +1,102 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id D4928429E29\r
+       for <notmuch@notmuchmail.org>; Wed, 11 Jan 2012 19:57:37 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id dcwebr+Y6lhz for <notmuch@notmuchmail.org>;\r
+       Wed, 11 Jan 2012 19:57:37 -0800 (PST)\r
+Received: from dmz-mailsec-scanner-6.mit.edu (DMZ-MAILSEC-SCANNER-6.MIT.EDU\r
+       [18.7.68.35])\r
+       by olra.theworths.org (Postfix) with ESMTP id 5E15C429E25\r
+       for <notmuch@notmuchmail.org>; Wed, 11 Jan 2012 19:57:37 -0800 (PST)\r
+X-AuditID: 12074423-b7f9c6d0000008c3-e9-4f0e5a309d62\r
+Received: from mailhub-auth-1.mit.edu ( [18.9.21.35])\r
+       by dmz-mailsec-scanner-6.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id 9D.64.02243.03A5E0F4; Wed, 11 Jan 2012 22:57:36 -0500 (EST)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+       by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id q0C3vZpc030544; \r
+       Wed, 11 Jan 2012 22:57:35 -0500\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+       (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q0C3vYvS015394\r
+       (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+       Wed, 11 Jan 2012 22:57:35 -0500 (EST)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
+       (envelope-from <amdragon@mit.edu>)\r
+       id 1RlBnH-0004ju-Fv; Wed, 11 Jan 2012 22:57:39 -0500\r
+Date: Wed, 11 Jan 2012 22:57:39 -0500\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: David Bremner <david@tethera.net>\r
+Subject: Re: [PATCH 2/2] notmuch-reply.c: uncrustify\r
+Message-ID: <20120112035739.GW20796@mit.edu>\r
+References: <1324135695-15487-1-git-send-email-david@tethera.net>\r
+       <1326197228-10356-1-git-send-email-david@tethera.net>\r
+       <1326197228-10356-3-git-send-email-david@tethera.net>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <1326197228-10356-3-git-send-email-david@tethera.net>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFuplleLIzCtJLcpLzFFi42IR4hRV1jWI4vM3WNGnbbFx2U9mixut3YwW\r
+       12/OZHZg9vjVNpfZ49mqW8weWw69Zw5gjuKySUnNySxLLdK3S+DK2PO3galgI3vF/jcHWBoY\r
+       n7B2MXJySAiYSOzf08UMYYtJXLi3nq2LkYtDSGAfo0T7mmVMIAkhgQ2MEi2dUhD2SSaJC1MD\r
+       IYqWMErM61sGNolFQFVi2rVdYA1sAhoS2/YvZwSxRYDiV7dNZgOxmQXsJRbNnsQOYgsDbX69\r
+       8SbYZl4BHYmrnd9YIIZuZJTo3bGVDSIhKHFy5hMWiGYtiRv/XgIt4ACypSWW/+MACXMKOEks\r
+       v3ge7AZRARWJKSe3sU1gFJqFpHsWku5ZCN0LGJlXMcqm5Fbp5iZm5hSnJusWJyfm5aUW6Zrp\r
+       5WaW6KWmlG5iBIU6u4vyDsY/B5UOMQpwMCrx8O7Yy+svxJpYVlyZe4hRkoNJSZT3RjifvxBf\r
+       Un5KZUZicUZ8UWlOavEhRgkOZiURXqcaoHLelMTKqtSifJiUNAeLkjivhtY7PyGB9MSS1OzU\r
+       1ILUIpisDAeHkgTvp0igoYJFqempFWmZOSUIaSYOTpDhPEDDH4HU8BYXJOYWZ6ZD5E8xKkqJ\r
+       8x4ESQiAJDJK8+B6YanoFaM40CvCvHtAqniAaQyu+xXQYCagwVvW8YAMLklESEk1MHr93/Fp\r
+       /fbXFtvqKiXjFleXnhdVLp0R6HGjXeXwAy/VrsotT1l6s769ELCY/D7wPteF9P4FD9WPWsT4\r
+       qjRcdupZELmjx0P85PTuF73b9LqimDLkG87eKti+8EemG+ttgT8Mn/Le3PRnNj5tfkmp4ops\r
+       eveNknOb5V/HdsfM+d/86dzV2OM5/kosxRmJhlrMRcWJAC+Vv7YgAwAA\r
+Cc: notmuch@notmuchmail.org, David Bremner <bremner@debian.org>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 12 Jan 2012 03:57:38 -0000\r
+\r
+Quoth David Bremner on Jan 10 at  8:07 am:\r
+> From: David Bremner <bremner@debian.org>\r
+> \r
+> This patch shows the raw result of running uncrustify on notmuch-reply.c.\r
+> The re-indenting of "format_reply" would probably not be desirable.\r
+\r
+The good news is that that structure is on its way out.\r
+\r
+> @@ -625,6 +612,7 @@ notmuch_reply_command (void *ctx, int argc, char *argv[])\r
+>      notmuch_query_t *query;\r
+>      char *query_string;\r
+>      int opt_index, ret = 0;\r
+> +\r
+\r
+This one's a little weird.  Did it get confused by the function\r
+prototype?\r
+\r
+>      int (*reply_format_func)(void *ctx, notmuch_config_t *config, notmuch_query_t *query, notmuch_show_params_t *params);\r
+>      notmuch_show_params_t params = { .part = -1 };\r
+>      int format = FORMAT_DEFAULT;\r
+\r
+All of the other format fixes look very reasonable to me.  I think you\r
+managed to find one of the least canonical source files in the tree.\r
+Was that intentional?\r