[PATCH 0/5] Document notmuch-pick and some bugfixes

diff --git a/b8/6c37e0decf4c51353e42d9e32b940519ce2480 b/b8/6c37e0decf4c51353e42d9e32b940519ce2480
new file mode 100644 (file)
index 0000000..06ac366
--- /dev/null
+++ b/b8/6c37e0decf4c51353e42d9e32b940519ce2480
@@ -0,0 +1,102 @@
+Return-Path: <markwalters1009@gmail.com>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id E112F429E30\r
+       for <notmuch@notmuchmail.org>; Mon,  1 Jul 2013 00:54:16 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 2.7\r
+X-Spam-Level: **\r
+X-Spam-Status: No, score=2.7 tagged_above=-999 required=5\r
+       tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
+       FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001,\r
+       FREEMAIL_REPLY=2.499, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id Ma06FMTzCAGx for <notmuch@notmuchmail.org>;\r
+       Mon,  1 Jul 2013 00:54:12 -0700 (PDT)\r
+Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com\r
+       [209.85.212.171]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 56702431E82\r
+       for <notmuch@notmuchmail.org>; Mon,  1 Jul 2013 00:54:12 -0700 (PDT)\r
+Received: by mail-wi0-f171.google.com with SMTP id hj3so2742529wib.4\r
+       for <notmuch@notmuchmail.org>; Mon, 01 Jul 2013 00:54:08 -0700 (PDT)\r
+DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
+       h=from:to:cc:subject:date:message-id:x-mailer;\r
+       bh=y8uIFi3OB7r6aEQzVElou7TSq4y83kAmh9ONPMxo/U0=;\r
+       b=fjhWt4mOwcQOt3koVyKooefMVFyA9+2j1nJEmJoGb4kjCdB4L8Qixl9wYG2PTfVSyQ\r
+       3p3b8xkOzpn7D6NWC35g31zRNXmsQ83J85PBRS+n1+owA9V9aqVhohTOhZz5wih4l5gp\r
+       34IQchnY+iPZgcwypX+uvG+Av2etGVUyOdsbxpfbwHmQ84yXhDzf5D86R+sGqWLA8xL9\r
+       MhFKXEK7wGGwp0kOKV2WOTEiglcITKCSOL38asDteQYQhwfGYyTN0rMeT4CLWTxTxFvQ\r
+       lKaBB8oOQYjTsr2aqIO8KpNwobxw4O+Rimzj5g6zEOpJChNyuqBu6WAAwVWYMe1yLx/s\r
+       T4EA==\r
+X-Received: by 10.194.24.40 with SMTP id r8mr18868041wjf.7.1372665247589;\r
+       Mon, 01 Jul 2013 00:54:07 -0700 (PDT)\r
+Received: from localhost (93-97-24-31.zone5.bethere.co.uk. [93.97.24.31])\r
+       by mx.google.com with ESMTPSA id p1sm14445015wix.9.2013.07.01.00.54.06\r
+       for <multiple recipients>\r
+       (version=TLSv1.2 cipher=RC4-SHA bits=128/128);\r
+       Mon, 01 Jul 2013 00:54:07 -0700 (PDT)\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: notmuch@notmuchmail.org\r
+Subject: [PATCH 0/5] Document notmuch-pick and some bugfixes\r
+Date: Mon,  1 Jul 2013 08:53:58 +0100\r
+Message-Id: <1372665243-7675-1-git-send-email-markwalters1009@gmail.com>\r
+X-Mailer: git-send-email 1.7.9.1\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 01 Jul 2013 07:54:17 -0000\r
+\r
+This adds some documentation to all the defvars in notmuch-pick and to\r
+the notmuch-pick function itself (as suggested by David in\r
+id:87li5rtvbh.fsf@zancas.localnet. This series replaces\r
+id:1372627117-31188-1-git-send-email-markwalters1009@gmail.com but\r
+does still need to be applied on top of the main series there (because\r
+it documents the pick function as it is after that change).\r
+\r
+When documenting the defvars I found some trivial bugs: the most\r
+serious being the wrong variable name being made buffer-local. This is\r
+less serious than it could be as this variable was just used to try\r
+and avoid closing the message pane if the user had loaded a different\r
+buffer into it.\r
+\r
+The other "bugs" were defvars for variables which are no longer\r
+used. In one case a moderate amount of effort was made passing this\r
+unused variable around so the patch to remove it is not tiny and thus\r
+its removal is delayed until a followup series.\r
+\r
+Finally, when looking at which functions did not have docstrings (some\r
+still need to be added after this series) I found an unused historical\r
+function so remove that too.\r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+\r
+\r
+Mark Walters (5):\r
+  contrib: pick: add a docstring for the main notmuch-pick function\r
+  contrib: pick: add docstrings to all defvars\r
+  contrib: pick: bugfix: make the right variable buffer-local\r
+  contrib: pick: remove unused variable\r
+  contrib: pick: remove unused function\r
+\r
+ contrib/notmuch-pick/notmuch-pick.el |   71 ++++++++++++++++++++-------------\r
+ 1 files changed, 43 insertions(+), 28 deletions(-)\r
+\r
+-- \r
+1.7.9.1\r
+\r