Re: [PATCH 01/24] lib/message.cc: stale pointer bug

diff --git a/2e/d15c9e70bce1a05c27b30bf2869e5269a9169b b/2e/d15c9e70bce1a05c27b30bf2869e5269a9169b
new file mode 100644 (file)
index 0000000..8f33ab0
--- /dev/null
+++ b/2e/d15c9e70bce1a05c27b30bf2869e5269a9169b
@@ -0,0 +1,90 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id A5D12431FAF\r
+       for <notmuch@notmuchmail.org>; Thu,  2 May 2013 11:03:26 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id hUl6GlmkfTh2 for <notmuch@notmuchmail.org>;\r
+       Thu,  2 May 2013 11:03:23 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id D753D431FB6\r
+       for <notmuch@notmuchmail.org>; Thu,  2 May 2013 11:03:22 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id 8AFA4100044;\r
+       Thu,  2 May 2013 21:03:20 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Vladimir Marek <Vladimir.Marek@Oracle.COM>\r
+Subject: Re: [PATCH 01/24] lib/message.cc: stale pointer bug\r
+In-Reply-To: <20130502134530.GB23259@pub.cz.oracle.com>\r
+References: <1367444021-2757-1-git-send-email-Vladimir.Marek@oracle.com>\r
+       <m2sj25snsk.fsf@guru.guru-group.fi>\r
+       <20130502134530.GB23259@pub.cz.oracle.com>\r
+User-Agent: Notmuch/0.15.2+75~gd7fa7c4 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Thu, 02 May 2013 21:03:20 +0300\r
+Message-ID: <m238u5tg2f.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+Cc: notmuch@notmuchmail.org, Vladimir Marek <vlmarek@volny.cz>\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Thu, 02 May 2013 18:03:26 -0000\r
+\r
+On Thu, May 02 2013, Vladimir Marek <Vladimir.Marek@Oracle.COM> wrote:\r
+\r
+>> >      int prefix_len = strlen (prefix);\r
+>> > -    const char *term = NULL;\r
+>> > +    std::string term;\r
+>> >      char *value;\r
+>> >  \r
+>> >      i.skip_to (prefix);\r
+>> >  \r
+>> > -    if (i != end)\r
+>> > - term = (*i).c_str ();\r
+>> > +    if (i == end)\r
+>> > + return NULL;\r
+>> >  \r
+>> > -    if (!term || strncmp (term, prefix, prefix_len))\r
+>> > +    term = *i;\r
+>> \r
+>> ... hmm, a raii(?) solution above would be std::string term = *i;\r
+>\r
+> I'm not sure what's raii (I'm not very good at c++ ...), but I guess you\r
+> mean to use 'std::string term = *i;' to avoid copy constructor. That\r
+> surely is a good idea. Let me rework the patch!\r
+\r
+I am not that smart (i.e. avoid copy constructor it might be, I don't\r
+know...) I am lousy in c++. I attempter to mean\r
+http://en.wikipedia.org/wiki/Resource_Acquisition_Is_Initialization\r
+in a sense that when variable is introduced it is also initialized\r
+to useful value (so that no-one accidentally add code between introduction\r
+and initialization). \r
+ \r
+Anyway, if you rework the patch then we can vote which version to\r
+apply (yeah, sure >;)\r
+\r
+> -- \r
+>      Vlad\r
+\r
+Tomi\r