Re: [PATCH 00/11] Add ghost messages and fix thread linking

diff --git a/9a/97e88e71ab256a475024d5d146234a321beab5 b/9a/97e88e71ab256a475024d5d146234a321beab5
new file mode 100644 (file)
index 0000000..ad73465
--- /dev/null
+++ b/9a/97e88e71ab256a475024d5d146234a321beab5
@@ -0,0 +1,68 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 90499431FBC\r
+       for <notmuch@notmuchmail.org>; Sun,  5 Oct 2014 02:07:30 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id j20uJifcZivv for <notmuch@notmuchmail.org>;\r
+       Sun,  5 Oct 2014 02:07:25 -0700 (PDT)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id D7160431FB6\r
+       for <notmuch@notmuchmail.org>; Sun,  5 Oct 2014 02:07:25 -0700 (PDT)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1Xahml-0007oy-4D; Sun, 05 Oct 2014 06:07:23 -0300\r
+Received: (nullmailer pid 24422 invoked by uid 1000); Sun, 05 Oct 2014\r
+       09:07:12 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Austin Clements <aclements@csail.mit.edu>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH 00/11] Add ghost messages and fix thread linking\r
+In-Reply-To: <1412345958-8278-1-git-send-email-aclements@csail.mit.edu>\r
+References: <1412345958-8278-1-git-send-email-aclements@csail.mit.edu>\r
+User-Agent: Notmuch/0.18.1+98~gae27403 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sun, 05 Oct 2014 11:07:12 +0200\r
+Message-ID: <87a95aq3zz.fsf@maritornes.cs.unb.ca>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Sun, 05 Oct 2014 09:07:30 -0000\r
+\r
+Austin Clements <aclements@csail.mit.edu> writes:\r
+\r
+> This series modifies our database representation of messages that have\r
+> been referenced by other messages, but for which we don't have the\r
+> message itself.  Currently, we store this information as Xapian\r
+> metadata, but this has several downsides for performance and\r
+> complexity and results in hard-to-fix thread linking bugs.  This patch\r
+> series implements "ghost messages", which replace this Xapian metadata\r
+> with Xapian documents that look and act very much like regular message\r
+> documents, but simply have no content.  This simplifies and speeds up\r
+> our thread linking algorithm and fixes the currently broken thread\r
+> linking test.\r
+\r
+Other than some style / documentation quibbles already noted, \r
+the series looks good to me.\r
+\r
+d\r