[PATCH v2 04/14] new: Don't report version after upgrade
authorAustin Clements <amdragon@MIT.EDU>
Tue, 29 Jul 2014 16:48:02 +0000 (12:48 +2000)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 18:03:56 +0000 (10:03 -0800)
40/7530c592391bb063c072ecae1b4f6a2a34eab1 [new file with mode: 0644]

diff --git a/40/7530c592391bb063c072ecae1b4f6a2a34eab1 b/40/7530c592391bb063c072ecae1b4f6a2a34eab1
new file mode 100644 (file)
index 0000000..554d17f
--- /dev/null
@@ -0,0 +1,117 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 2F464431FBC\r
+       for <notmuch@notmuchmail.org>; Tue, 29 Jul 2014 09:49:19 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.3\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id Tim-1SPG9S2w for <notmuch@notmuchmail.org>;\r
+       Tue, 29 Jul 2014 09:49:13 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-1.mit.edu (dmz-mailsec-scanner-1.mit.edu\r
+       [18.9.25.12])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 9A7CD431FDB\r
+       for <notmuch@notmuchmail.org>; Tue, 29 Jul 2014 09:48:31 -0700 (PDT)\r
+X-AuditID: 1209190c-f79ef6d000005dd6-6e-53d7d05ccac7\r
+Received: from mailhub-auth-1.mit.edu ( [18.9.21.35])\r
+       (using TLS with cipher AES256-SHA (256/256 bits))\r
+       (Client did not present a certificate)\r
+       by dmz-mailsec-scanner-1.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id C6.EC.24022.D50D7D35; Tue, 29 Jul 2014 12:48:29 -0400 (EDT)\r
+Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11])\r
+       by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id s6TGmI5t003474; \r
+       Tue, 29 Jul 2014 12:48:18 -0400\r
+Received: from drake.dyndns.org (31-33-71.wireless.csail.mit.edu\r
+       [128.31.33.71]) (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id s6TGmF9o030250\r
+       (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+       Tue, 29 Jul 2014 12:48:17 -0400\r
+Received: from amthrax by drake.dyndns.org with local (Exim 4.77)\r
+       (envelope-from <amdragon@mit.edu>)\r
+       id 1XCAZS-0007Gk-P2; Tue, 29 Jul 2014 12:48:14 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: notmuch@notmuchmail.org\r
+Subject: [PATCH v2 04/14] new: Don't report version after upgrade\r
+Date: Tue, 29 Jul 2014 12:48:02 -0400\r
+Message-Id: <1406652492-27803-5-git-send-email-amdragon@mit.edu>\r
+X-Mailer: git-send-email 2.0.0\r
+In-Reply-To: <1406652492-27803-1-git-send-email-amdragon@mit.edu>\r
+References: <1406652492-27803-1-git-send-email-amdragon@mit.edu>\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFtrNIsWRmVeSWpSXmKPExsUixCmqrBt74XqwwftmVovVc3ksrt+cyezA\r
+       5LFz1l12j2erbjEHMEVx2aSk5mSWpRbp2yVwZWxcIVXQzVfx9dUN9gbGbdxdjJwcEgImEhPu\r
+       P2GFsMUkLtxbz9bFyMUhJDCbSeLXic/MEM5GRomvhy4xQTjHmCTOrmpkhHDmMko867vGBtLP\r
+       JqAhsW3/ckYQW0RAWmLn3dlgc5kFHCU+718EVMPBIQxk7/zBBBJmEVCV+Hv9EFgrr4CDxLlD\r
+       W6DOkJNouPEJLM4JVH7r3l2weiGgmkOzNrNMYORfwMiwilE2JbdKNzcxM6c4NVm3ODkxLy+1\r
+       SNdQLzezRC81pXQTIziMJHl2ML45qHSIUYCDUYmHd8Pca8FCrIllxZW5hxglOZiURHn19l0P\r
+       FuJLyk+pzEgszogvKs1JLT7EKMHBrCTCy3cWKMebklhZlVqUD5OS5mBREud9a20VLCSQnliS\r
+       mp2aWpBaBJOV4eBQkuA1Og/UKFiUmp5akZaZU4KQZuLgBBnOAzS8GaSGt7ggMbc4Mx0if4pR\r
+       UUqcN/scUEIAJJFRmgfXC4vzV4ziQK8I87qDtPMAUwRc9yugwUxAg1ldwAaXJCKkpBoYlVW0\r
+       Gtg+eFw+tz3QYHJFT4fe/ZisBxOZd9/8JnblGmf4ruuXzumGrf8/8YTi5mu8/1Ri9C6vj+p8\r
+       VPOy/O3c1oWMFSW1Da7yZz+f8KrZEMOS+1Y/TJ2v0qZU9PSbHp6+yCVGF/Z49xoVT5djKZ7H\r
+       pGWubf70Aaef69crao+lxPjnRPJxRfAqsRRnJBpqMRcVJwIA8o7ogs4CAAA=\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 29 Jul 2014 16:49:19 -0000\r
+\r
+The version number has always been pretty meaningless to the user and\r
+it's about to become even more meaningless with the introduction of\r
+"features".  Hopefully, the database will remain on version 3 for some\r
+time to come; however, the introduction of new features over time in\r
+version 3 will necessitate upgrades within version 3.  It would be\r
+confusing if we always tell the user they've been "upgraded to version\r
+3".  If the user wants to know what's new, they should read the news.\r
+---\r
+ notmuch-new.c        | 3 +--\r
+ test/T530-upgrade.sh | 2 +-\r
+ 2 files changed, 2 insertions(+), 3 deletions(-)\r
+\r
+diff --git a/notmuch-new.c b/notmuch-new.c\r
+index d269c7c..b7590a8 100644\r
+--- a/notmuch-new.c\r
++++ b/notmuch-new.c\r
+@@ -1023,8 +1023,7 @@ notmuch_new_command (notmuch_config_t *config, int argc, char *argv[])\r
+                                     add_files_state.verbosity >= VERBOSITY_NORMAL ? upgrade_print_progress : NULL,\r
+                                     &add_files_state);\r
+           if (add_files_state.verbosity >= VERBOSITY_NORMAL)\r
+-              printf ("Your notmuch database has now been upgraded to database format version %u.\n",\r
+-                  notmuch_database_get_version (notmuch));\r
++              printf ("Your notmuch database has now been upgraded.\n");\r
+       }\r
\r
+       add_files_state.total_files = 0;\r
+diff --git a/test/T530-upgrade.sh b/test/T530-upgrade.sh\r
+index 7d5d5aa..c4c4ac8 100755\r
+--- a/test/T530-upgrade.sh\r
++++ b/test/T530-upgrade.sh\r
+@@ -33,7 +33,7 @@ test_expect_equal "$output" "\\r
+ Welcome to a new version of notmuch! Your database will now be upgraded.\r
+ This process is safe to interrupt.\r
+ Backing up tags to FILENAME\r
+-Your notmuch database has now been upgraded to database format version 2.\r
++Your notmuch database has now been upgraded.\r
+ No new mail."\r
\r
+ test_begin_subtest "tag backup matches pre-upgrade dump"\r
+-- \r
+2.0.0\r
+\r