Re: [PATCH] emacs: Don't attempt to colour tags in `notmuch-show-mode'.
authorAustin Clements <amdragon@MIT.EDU>
Wed, 28 Dec 2011 03:29:57 +0000 (22:29 +1900)
committerW. Trevor King <wking@tremily.us>
Fri, 7 Nov 2014 17:41:21 +0000 (09:41 -0800)
c0/c445604fce912430c959765f1127c6171d356c [new file with mode: 0644]

diff --git a/c0/c445604fce912430c959765f1127c6171d356c b/c0/c445604fce912430c959765f1127c6171d356c
new file mode 100644 (file)
index 0000000..a37182f
--- /dev/null
@@ -0,0 +1,114 @@
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id DC82C431FD0\r
+       for <notmuch@notmuchmail.org>; Tue, 27 Dec 2011 19:29:14 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id 97q9FPo2PChx for <notmuch@notmuchmail.org>;\r
+       Tue, 27 Dec 2011 19:29:12 -0800 (PST)\r
+Received: from dmz-mailsec-scanner-3.mit.edu (DMZ-MAILSEC-SCANNER-3.MIT.EDU\r
+       [18.9.25.14])\r
+       by olra.theworths.org (Postfix) with ESMTP id B5A1C431FB6\r
+       for <notmuch@notmuchmail.org>; Tue, 27 Dec 2011 19:29:12 -0800 (PST)\r
+X-AuditID: 1209190e-b7f7c6d0000008c3-d0-4efa8d0809bc\r
+Received: from mailhub-auth-2.mit.edu ( [18.7.62.36])\r
+       by dmz-mailsec-scanner-3.mit.edu (Symantec Messaging Gateway) with SMTP\r
+       id 87.24.02243.80D8AFE4; Tue, 27 Dec 2011 22:29:12 -0500 (EST)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+       by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id pBS3TBDS027702; \r
+       Tue, 27 Dec 2011 22:29:12 -0500\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+       (authenticated bits=0)\r
+       (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+       by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id pBS3T8Wr009667\r
+       (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+       Tue, 27 Dec 2011 22:29:11 -0500 (EST)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
+       (envelope-from <amdragon@mit.edu>)\r
+       id 1RfkDF-0001Qb-Iy; Tue, 27 Dec 2011 22:29:57 -0500\r
+Date: Tue, 27 Dec 2011 22:29:57 -0500\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: David Edmondson <dme@dme.org>\r
+Subject: Re: [PATCH] emacs: Don't attempt to colour tags in\r
+       `notmuch-show-mode'.\r
+Message-ID: <20111228032957.GB30150@mit.edu>\r
+References: <1325004434-24583-1-git-send-email-dme@dme.org>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <1325004434-24583-1-git-send-email-dme@dme.org>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA+NgFmpmleLIzCtJLcpLzFFi42IRYrdT0eXo/eVn0L9a3GLfnS1MFtdvzmR2\r
+       YPLY9fwvk8ezVbeYA5iiuGxSUnMyy1KL9O0SuDK2LvjHUtDOXfH12T2mBsbjHF2MHBwSAiYS\r
+       x7/odzFyApliEhfurWfrYuTiEBLYxyhxvqWHHcLZwCjx8eNCqMxJJomrS7YwQThLGCUaj59n\r
+       B+lnEVCVOHf4JjOIzSagIbFt/3JGEFtEQFHi/7cVYDXMAtIS3343M4HYwgJBEuunXgGzeQV0\r
+       JK6t7gOzhQSsJaZ9XsMGEReUODnzCQtEr5bEjX8vmUDOBpmz/B8HSJhTwEZi88uvYK2iAioS\r
+       U05uY5vAKDQLSfcsJN2zELoXMDKvYpRNya3SzU3MzClOTdYtTk7My0st0jXWy80s0UtNKd3E\r
+       CAprTkm+HYxfDyodYhTgYFTi4b319qefEGtiWXFl7iFGSQ4mJVFer65ffkJ8SfkplRmJxRnx\r
+       RaU5qcWHGCU4mJVEeC0fAJXzpiRWVqUW5cOkpDlYlMR51bTe+QkJpCeWpGanphakFsFkZTg4\r
+       lCR4DXuAhgoWpaanVqRl5pQgpJk4OEGG8wAN9wWp4S0uSMwtzkyHyJ9iVJQS52UBSQiAJDJK\r
+       8+B6YWnnFaM40CvCvHogVTzAlAXX/QpoMBPQ4DjlHyCDSxIRUlINjFzZITlZhw5/E7XyOHpy\r
+       ec4L//dWyk/97OewWd+frvr2F8MP+/nMmtOVnCyjNKY3v9jJXBy2pUur4ZVQddKsDzsDtjMY\r
+       WtcyNp6t9/rns8xphebrxmPzv7msm7N4mgRnovWslR9Pfm1LvdO+w3HphXXbJs97uO+HhMUN\r
+       A0vWwOKbM6e4XC+XPqfEUpyRaKjFXFScCAC4kDIeFgMAAA==\r
+Cc: notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 28 Dec 2011 03:29:15 -0000\r
+\r
+LGTM.\r
+\r
+Quoth David Edmondson on Dec 27 at  4:47 pm:\r
+> The tags were coloured using text properties. Unfortunately that text\r
+> (the header line) also has an overlay, which overrides the text\r
+> properties. There's not point in applying text properties that will\r
+> never be seen.\r
+> ---\r
+>  emacs/notmuch-show.el |    8 ++------\r
+>  1 files changed, 2 insertions(+), 6 deletions(-)\r
+> \r
+> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+> index 8c9d846..24f0b40 100644\r
+> --- a/emacs/notmuch-show.el\r
+> +++ b/emacs/notmuch-show.el\r
+> @@ -221,10 +221,7 @@ indentation."\r
+>      (goto-char (notmuch-show-message-top))\r
+>      (if (re-search-forward "(\\([^()]*\\))$" (line-end-position) t)\r
+>      (let ((inhibit-read-only t))\r
+> -      (replace-match (concat "("\r
+> -                             (propertize (mapconcat 'identity tags " ")\r
+> -                                         'face 'notmuch-tag-face)\r
+> -                             ")"))))))\r
+> +      (replace-match (concat "(" (mapconcat 'identity tags " ") ")"))))))\r
+>  \r
+>  (defun notmuch-show-clean-address (address)\r
+>    "Try to clean a single email ADDRESS for display.  Return\r
+> @@ -278,8 +275,7 @@ message at DEPTH in the current thread."\r
+>          " ("\r
+>          date\r
+>          ") ("\r
+> -        (propertize (mapconcat 'identity tags " ")\r
+> -                    'face 'notmuch-tag-face)\r
+> +        (mapconcat 'identity tags " ")\r
+>          ")\n")\r
+>      (overlay-put (make-overlay start (point)) 'face 'notmuch-message-summary-face)))\r
+>  \r