Re: [PATCH v2 0/7] lib: replace the message header parser with gmime

diff --git a/8c/ee8c9c5dfc44d42c748ef8dd906c8c8b58aff0 b/8c/ee8c9c5dfc44d42c748ef8dd906c8c8b58aff0
new file mode 100644 (file)
index 0000000..5f16493
--- /dev/null
+++ b/8c/ee8c9c5dfc44d42c748ef8dd906c8c8b58aff0
@@ -0,0 +1,75 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 18A75431FBD\r
+       for <notmuch@notmuchmail.org>; Wed, 15 Jan 2014 10:03:22 -0800 (PST)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id kxjfNEXX5el4 for <notmuch@notmuchmail.org>;\r
+       Wed, 15 Jan 2014 10:03:14 -0800 (PST)\r
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])\r
+       (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 83439431FAF\r
+       for <notmuch@notmuchmail.org>; Wed, 15 Jan 2014 10:03:14 -0800 (PST)\r
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1W3Uo3-0007WZ-5c; Wed, 15 Jan 2014 14:03:11 -0400\r
+Received: (nullmailer pid 8859 invoked by uid 1000); Wed, 15 Jan 2014\r
+       18:03:06 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 0/7] lib: replace the message header parser with gmime\r
+In-Reply-To: <cover.1385825425.git.jani@nikula.org>\r
+References: <cover.1385825425.git.jani@nikula.org>\r
+User-Agent: Notmuch/0.17+30~g50677dd (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Wed, 15 Jan 2014 14:03:06 -0400\r
+Message-ID: <87ob3di0md.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 15 Jan 2014 18:03:22 -0000\r
+\r
+Jani Nikula <jani@nikula.org> writes:\r
+\r
+> This is v2 of id:cover.1381948853.git.jani@nikula.org with more polish.\r
+>\r
+> Patches 1-4 do prep work to fix some of the differences in the parsers\r
+> in advance. Arguably they are not that bad regardless of the parser\r
+> change.\r
+>\r
+> Patches 5-6 actually make the change. Having two patches is a somewhat\r
+> artificial division, but perhaps makes it easier to review.\r
+>\r
+\r
+I had a quick look at these changes, and nothing jumped out at me. I'd\r
+appreciate a second pair of eyes on them.\r
+\r
+I ran the performance suite, and there is only one message (in version\r
+0.4 of the corpus) newly classified as non-mail. Of course I did clean\r
+up the corpus a bunch from 0.3 to 0.4. I didn't see any shocking changes\r
+in performance before and after the patches. I only had patience enough\r
+to run twice in both cases.\r
+\r
+d\r
+\r
+\r