Re: [PATCH] emacs: replace setq + let with let*

diff --git a/18/1d8499f9dc228eb3f33fa0fe5d6ec124329bb0 b/18/1d8499f9dc228eb3f33fa0fe5d6ec124329bb0
new file mode 100644 (file)
index 0000000..e5892ec
--- /dev/null
+++ b/18/1d8499f9dc228eb3f33fa0fe5d6ec124329bb0
@@ -0,0 +1,82 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id D9BB0429E5A\r
+       for <notmuch@notmuchmail.org>; Sun,  2 Jun 2013 17:01:36 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.3\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id r2HHxOVBLS2y for <notmuch@notmuchmail.org>;\r
+       Sun,  2 Jun 2013 17:01:31 -0700 (PDT)\r
+Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id D35C1431FBC\r
+       for <notmuch@notmuchmail.org>; Sun,  2 Jun 2013 17:01:30 -0700 (PDT)\r
+Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])\r
+       by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id r5301TTY025232;\r
+       Sun, 2 Jun 2013 21:01:29 -0300\r
+Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net\r
+       ([156.34.82.78] helo=zancas.localnet)\r
+       by tesseract.cs.unb.ca with esmtpsa\r
+       (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1UjIDI-0002V3-Tx; Sun, 02 Jun 2013 21:01:29 -0300\r
+Received: from bremner by zancas.localnet with local (Exim 4.80)\r
+       (envelope-from <david@tethera.net>)\r
+       id 1UjIDD-0007R1-96; Sun, 02 Jun 2013 21:01:23 -0300\r
+From: David Bremner <david@tethera.net>\r
+To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] emacs: replace setq + let with let*\r
+In-Reply-To: <878v2sv2zz.fsf@qmul.ac.uk>\r
+References: <1370175370-13561-1-git-send-email-david@tethera.net>\r
+       <1370185351-23834-1-git-send-email-david@tethera.net>\r
+       <878v2sv2zz.fsf@qmul.ac.uk>\r
+User-Agent: Notmuch/0.15.2+141~gd298af4 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Sun, 02 Jun 2013 21:01:23 -0300\r
+Message-ID: <874ndgt63w.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-Spam_bar: -\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 03 Jun 2013 00:01:37 -0000\r
+\r
+Mark Walters <markwalters1009@gmail.com> writes:\r
+\r
+>> -    (setq search (notmuch-hello-trim search))\r
+>> -    (let ((history-delete-duplicates t))\r
+>> +    (let* ((search (notmuch-hello-trim search))\r
+>> +      (history-delete-duplicates t))\r
+>>        (add-to-history 'notmuch-search-history search)))\r
+>>    (notmuch-search search notmuch-search-oldest-first nil nil\r
+>\r
+> These look good to me except I don't see why the above is a let* not a\r
+> let?\r
+\r
+I ended up dropping this hunk because I realized it introduced a bug;\r
+the side-effect of the setq is needed outside the unless.\r
+\r
+pushed the two patches (as amended) in this thread.\r
+\r
+d\r
+\r
+\r
+\r