Re: [RFC PATCH] emacs: Remove v command

diff --git a/0c/4b28191346577a83f4aa3e592dec6fdcb309b5 b/0c/4b28191346577a83f4aa3e592dec6fdcb309b5
new file mode 100644 (file)
index 0000000..38bb421
--- /dev/null
+++ b/0c/4b28191346577a83f4aa3e592dec6fdcb309b5
@@ -0,0 +1,96 @@
+Return-Path: <tomi.ollila@iki.fi>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 1B408431FAF\r
+       for <notmuch@notmuchmail.org>; Mon,  3 Jun 2013 10:25:33 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: 0\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
+       autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id uQg5m02hg8oz for <notmuch@notmuchmail.org>;\r
+       Mon,  3 Jun 2013 10:25:25 -0700 (PDT)\r
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
+       by olra.theworths.org (Postfix) with ESMTP id 7D4F6431FAE\r
+       for <notmuch@notmuchmail.org>; Mon,  3 Jun 2013 10:25:25 -0700 (PDT)\r
+Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
+       by guru.guru-group.fi (Postfix) with ESMTP id CB98E100030;\r
+       Mon,  3 Jun 2013 20:25:24 +0300 (EEST)\r
+From: Tomi Ollila <tomi.ollila@iki.fi>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [RFC PATCH] emacs: Remove v command\r
+In-Reply-To: <1370274895-32098-1-git-send-email-amdragon@mit.edu>\r
+References: <1370274895-32098-1-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.15.2+168~gf91ff62 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-unknown-linux-gnu)\r
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
+       $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
+       !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
+Date: Mon, 03 Jun 2013 20:25:24 +0300\r
+Message-ID: <m2sj0z3y4b.fsf@guru.guru-group.fi>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 03 Jun 2013 17:25:33 -0000\r
+\r
+On Mon, Jun 03 2013, Austin Clements <amdragon@MIT.EDU> wrote:\r
+\r
+> This removes the v command, since we now have much nicer part commands,\r
+> and deprecates the underlying notmuch-show-view-all-mime-parts.  This\r
+> also means that people who try using the old unprefixed 'v' command on\r
+> a part button will no longer be greeted by ALL of their parts popping\r
+> up.\r
+> ---\r
+\r
++1\r
+\r
+Tomi\r
+\r
+\r
+>  emacs/notmuch-show.el |    4 +++-\r
+>  1 file changed, 3 insertions(+), 1 deletion(-)\r
+>\r
+> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+> index 5771950..bae3171 100644\r
+> --- a/emacs/notmuch-show.el\r
+> +++ b/emacs/notmuch-show.el\r
+> @@ -213,6 +213,9 @@ For example, if you wanted to remove an \"unread\" tag and add a\r
+>    "Enable Visual Line mode."\r
+>    (visual-line-mode t))\r
+>  \r
+> +;; DEPRECATED in Notmuch 0.16 since we now have convenient part\r
+> +;; commands.  We'll keep the command around for a version or two in\r
+> +;; case people want to bind it themselves.\r
+>  (defun notmuch-show-view-all-mime-parts ()\r
+>    "Use external viewers to view all attachments from the current message."\r
+>    (interactive)\r
+> @@ -1216,7 +1219,6 @@ reset based on the original query."\r
+>      (define-key map "|" 'notmuch-show-pipe-message)\r
+>      (define-key map "w" 'notmuch-show-save-attachments)\r
+>      (define-key map "V" 'notmuch-show-view-raw-message)\r
+> -    (define-key map "v" 'notmuch-show-view-all-mime-parts)\r
+>      (define-key map "c" 'notmuch-show-stash-map)\r
+>      (define-key map "=" 'notmuch-show-refresh-view)\r
+>      (define-key map "h" 'notmuch-show-toggle-visibility-headers)\r
+> -- \r
+> 1.7.10.4\r
+>\r
+> _______________________________________________\r
+> notmuch mailing list\r
+> notmuch@notmuchmail.org\r
+> http://notmuchmail.org/mailman/listinfo/notmuch\r