Re: [PATCH v4 7/7] complete ghost-on-removal-when-shared-thread-exists

diff --git a/79/2c6585a2d63118cb6500ad19ea8d6d0de1c2a4 b/79/2c6585a2d63118cb6500ad19ea8d6d0de1c2a4
new file mode 100644 (file)
index 0000000..f88b8a1
--- /dev/null
+++ b/79/2c6585a2d63118cb6500ad19ea8d6d0de1c2a4
@@ -0,0 +1,81 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 2C42B6DE02DD\r
+ for <notmuch@notmuchmail.org>; Sun, 10 Apr 2016 17:33:13 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.018\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.018 tagged_above=-999 required=5\r
+ tests=[AWL=-0.007, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01]\r
+ autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id RJselYdEvfKx for <notmuch@notmuchmail.org>;\r
+ Sun, 10 Apr 2016 17:33:05 -0700 (PDT)\r
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id 6A3336DE02DB\r
+ for <notmuch@notmuchmail.org>; Sun, 10 Apr 2016 17:33:05 -0700 (PDT)\r
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84)\r
+ (envelope-from <david@tethera.net>)\r
+ id 1apPmz-0002BJ-JX; Sun, 10 Apr 2016 20:33:13 -0400\r
+Received: (nullmailer pid 6027 invoked by uid 1000);\r
+ Mon, 11 Apr 2016 00:33:02 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>,\r
+ Notmuch Mail <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH v4 7/7] complete\r
+ ghost-on-removal-when-shared-thread-exists\r
+In-Reply-To: <1460166892-29721-7-git-send-email-dkg@fifthhorseman.net>\r
+References: <1459445693-3900-1-git-send-email-dkg@fifthhorseman.net>\r
+ <1460166892-29721-1-git-send-email-dkg@fifthhorseman.net>\r
+ <1460166892-29721-7-git-send-email-dkg@fifthhorseman.net>\r
+User-Agent: Notmuch/0.21+99~gd93d377 (http://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Sun, 10 Apr 2016 21:33:02 -0300\r
+Message-ID: <87r3ed6l35.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Mon, 11 Apr 2016 00:33:13 -0000\r
+\r
+Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:\r
+\r
+> To fully complete the ghost-on-removal-when-shared-thread-exists\r
+> proposal, we need to clear all ghost messages when the last active\r
+> message is removed from a thread.\r
+\r
+For me this patch breaks T530 as follows\r
+\r
+T530-upgrade: Testing database upgrade\r
+ FAIL   ghost message retains thread ID\r
+       --- T530-upgrade.13.expected    2016-04-11 00:25:19.482196274 +0000\r
+       +++ T530-upgrade.13.output      2016-04-11 00:25:19.482196274 +0000\r
+       @@ -1 +1 @@\r
+       -thread:000000000000001d\r
+       +thread:0000000000000011\r
+No new mail.\r
+No new mail. Removed 1 message.\r
+\r
+I pushed my rebased version of the patches to\r
+\r
+  https://git.notmuchmail.org/git?p=notmuch;a=shortlog;h=refs/heads/thread-fix\r
+\r
+in case the problem is some mistake on my part.\r
+\r
+d\r
+\r
+\r