Re: [PATCH] lib: Precede all function names in notmuch-private.h with an underscore.

diff --git a/46/80ccba1759e2d63094eae476d287dd10f2c619 b/46/80ccba1759e2d63094eae476d287dd10f2c619
new file mode 100644 (file)
index 0000000..2a63460
--- /dev/null
+++ b/46/80ccba1759e2d63094eae476d287dd10f2c619
@@ -0,0 +1,105 @@
+Return-Path: <cceleri@cs.stanford.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id CD36A431FBD\r
+       for <notmuch@notmuchmail.org>; Tue, 13 May 2014 02:40:24 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -2.3\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5\r
+       tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id PlBbEJSeoQ0s for <notmuch@notmuchmail.org>;\r
+       Tue, 13 May 2014 02:40:17 -0700 (PDT)\r
+Received: from smtp3.cs.Stanford.EDU (smtp3.cs.Stanford.EDU [171.64.64.27])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 8CEEE431FAF\r
+       for <notmuch@notmuchmail.org>; Tue, 13 May 2014 02:40:17 -0700 (PDT)\r
+Received: from cs-tor.bu.edu ([204.8.156.142] helo=jane.lan)\r
+       by smtp3.cs.Stanford.EDU with esmtpsa (UNKNOWN:AES128-GCM-SHA256:128)\r
+       (Exim 4.80.1) (envelope-from <cceleri@cs.stanford.edu>)\r
+       id 1Wk9C0-00023j-69; Tue, 13 May 2014 02:40:13 -0700\r
+From: Charles Celerier <cceleri@cs.stanford.edu>\r
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH] lib: Precede all function names in notmuch-private.h with\r
+       an      underscore.\r
+In-Reply-To: <877g5rgrqy.fsf@maritornes.cs.unb.ca>\r
+References: <1399402716-13714-1-git-send-email-cceleri@cs.stanford.edu>\r
+       <87d2fjgtcr.fsf@maritornes.cs.unb.ca>\r
+       <877g5rgrqy.fsf@maritornes.cs.unb.ca>\r
+User-Agent: Notmuch/0.18~rc0+32~gd5092c2 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-apple-darwin13.1.0)\r
+Date: Tue, 13 May 2014 05:40:04 -0400\r
+Message-ID: <m2y4y610gb.fsf@jane.lan>\r
+MIME-Version: 1.0\r
+Content-Type: multipart/signed; boundary="=-=-=";\r
+       micalg=pgp-sha1; protocol="application/pgp-signature"\r
+X-Scan-Signature: 127ff6e1eac6b45a32dc112250ed777d\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 13 May 2014 09:40:24 -0000\r
+\r
+--=-=-=\r
+Content-Type: text/plain\r
+\r
+David Bremner <david@tethera.net> writes:\r
+\r
+> David Bremner <david@tethera.net> writes:\r
+>\r
+>> Originally I thought this was uneccesarily intrusive, but on a second\r
+>> look I see that there is only one symbol changed that doesn't start with\r
+>> _notmuch, so I guess for consistency it's fine.\r
+\r
+Actually, they all start with _notmuch. The symbol\r
+_thread_add_matched_author is not changed.\r
+\r
+>> I'm thinking about a 0.18.1 point release for build and portability\r
+>> fixes; I do think this is a bit too much change for that (especially\r
+>> since it doesn't actually fix the symbol hiding test (or more precisely,\r
+>> your fix for OS/X breaks the linux test).\r
+\r
+I agree.\r
+\r
+> Also, I'd like a less confusing commit message.  Do you understand the\r
+> situation enough to write one now? In particular it's just a convention\r
+> that private symbols should not start with "notmuch", and the actual\r
+> hiding happens elsewhere.\r
+>\r
+> d\r
+\r
+Yes, I now understand the hiding happens elsewhere. There is a note in\r
+devel/STYLE in the "libnotmuch conventions" section that discusses the\r
+use of underscores to denote private library functions; I will cite\r
+that as the reason for the patch instead.\r
+\r
+chuck\r
+\r
+--=-=-=\r
+Content-Type: application/pgp-signature\r
+\r
+-----BEGIN PGP SIGNATURE-----\r
+Version: GnuPG/MacGPG2 v2.0.22 (Darwin)\r
+\r
+iQEcBAEBAgAGBQJTceh0AAoJEOjk698fDjuAXHoIAJLE+SmTzjZVFoqeUaKNXml3\r
+UlIq3h+q6lcW6J8ev+ni/qPHkaK+945GSad1BdaILLfgzJJT85/5ZxVo5JRb6Eex\r
+XIeqNy/WBGJiqJGr7vkoAoQb0T6aUUEOtV6q9qUBansWVYTUGgaMZQe9SXBWkaf1\r
+SXSWHxhY+MAjd8TmMyzvLKWbXjO53VYrYUQm9X2b1PidHGi9SYAzs2DXe+Yv9gID\r
+owg7uZtilUTVEQT7OU79tlU9CjX0AYfJQWC79uznyGzzU3e235ZVPdHBAK8s4Len\r
+zBPC6d/mArWsdBt6J0585E2RvJMkIq/wwesTnvggR7V4orZfx7f/c4G3lL1iTSA=\r
+=Xm0I\r
+-----END PGP SIGNATURE-----\r
+--=-=-=--\r