Re: [PATCH v2 0/8] Improve tag change completion

diff --git a/5c/645d2dff62ca226198ccaa2fc0c9f1a5dff001 b/5c/645d2dff62ca226198ccaa2fc0c9f1a5dff001
new file mode 100644 (file)
index 0000000..5f3d0f2
--- /dev/null
+++ b/5c/645d2dff62ca226198ccaa2fc0c9f1a5dff001
@@ -0,0 +1,133 @@
+Return-Path: <m.walters@qmul.ac.uk>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+       by olra.theworths.org (Postfix) with ESMTP id 6A9FE431FC3\r
+       for <notmuch@notmuchmail.org>; Wed, 23 Oct 2013 09:07:45 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -1.098\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5\r
+       tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,\r
+       NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+       by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+       with ESMTP id w1v3eigrSL6O for <notmuch@notmuchmail.org>;\r
+       Wed, 23 Oct 2013 09:07:39 -0700 (PDT)\r
+Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])\r
+       (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\r
+       (No client certificate requested)\r
+       by olra.theworths.org (Postfix) with ESMTPS id 52B75431FBC\r
+       for <notmuch@notmuchmail.org>; Wed, 23 Oct 2013 09:07:39 -0700 (PDT)\r
+Received: from smtp.qmul.ac.uk ([138.37.6.40])\r
+       by mail2.qmul.ac.uk with esmtp (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1VZ0y4-0001TK-Ri; Wed, 23 Oct 2013 17:07:33 +0100\r
+Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)\r
+       by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)\r
+       (envelope-from <m.walters@qmul.ac.uk>)\r
+       id 1VZ0y4-0001kp-A7; Wed, 23 Oct 2013 17:07:32 +0100\r
+From: Mark Walters <markwalters1009@gmail.com>\r
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org\r
+Subject: Re: [PATCH v2 0/8] Improve tag change completion\r
+In-Reply-To: <1382487721-31776-1-git-send-email-amdragon@mit.edu>\r
+References: <1382487721-31776-1-git-send-email-amdragon@mit.edu>\r
+User-Agent: Notmuch/0.16 (http://notmuchmail.org) Emacs/24.3.1\r
+       (x86_64-pc-linux-gnu)\r
+Date: Wed, 23 Oct 2013 17:06:27 +0100\r
+Message-ID: <87k3h40y64.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-Sender-Host-Address: 93.97.24.31\r
+X-QM-SPAM-Info: Sender has good ham record.  :)\r
+X-QM-Body-MD5: 3f5ceb6e7a115b9b128abc699ab9c329 (of first 20000 bytes)\r
+X-SpamAssassin-Score: 0.0\r
+X-SpamAssassin-SpamBar: /\r
+X-SpamAssassin-Report: The QM spam filters have analysed this message to\r
+       determine if it is\r
+       spam. We require at least 5.0 points to mark a message as spam.\r
+       This message scored 0.0 points. Summary of the scoring: \r
+       * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\r
+       provider *      (markwalters1009[at]gmail.com)\r
+       *  0.0 AWL AWL: From: address is in the auto white-list\r
+X-QM-Scan-Virus: ClamAV says the message is clean\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+       <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+       <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 23 Oct 2013 16:07:45 -0000\r
+\r
+\r
+In might of id:20131023154404.GE20337@mit.edu I am now happy with this\r
+series. LGTM +1 \r
+\r
+Best wishes\r
+\r
+Mark\r
+\r
+\r
+On Wed, 23 Oct 2013, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> This is v2 of id:1382471457-26056-1-git-send-email-amdragon@mit.edu.\r
+> It improves some documentation strings, fixes one bug, and elimintes\r
+> some redundant code.  The diff from v1 is below.\r
+>\r
+> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
+> index ef77839..f66d669 100644\r
+> --- a/emacs/notmuch-show.el\r
+> +++ b/emacs/notmuch-show.el\r
+> @@ -1800,7 +1800,6 @@ See `notmuch-tag' for information on the format of TAG-CHANGES."\r
+>     (list (let (tags)\r
+>         (notmuch-show-mapc\r
+>          (lambda () (setq tags (append (notmuch-show-get-tags) tags))))\r
+> -       (delete-dups tags)\r
+>         (notmuch-read-tag-changes tags "Tag thread"))))\r
+>    (notmuch-tag (notmuch-show-get-messages-ids-search) tag-changes)\r
+>    (notmuch-show-mapc\r
+> diff --git a/emacs/notmuch-tag.el b/emacs/notmuch-tag.el\r
+> index feee17c..7b21006 100644\r
+> --- a/emacs/notmuch-tag.el\r
+> +++ b/emacs/notmuch-tag.el\r
+> @@ -189,6 +189,9 @@ the messages that were tagged"\r
+>  `notmuch-read-tag-changes' function.")\r
+>  \r
+>  (defun notmuch-tag-completions (&rest search-terms)\r
+> +  "Return a list of tags for messages matching SEARCH-TERMS.\r
+> +\r
+> +Returns all tags if no search terms are given."\r
+>    (if (null search-terms)\r
+>        (setq search-terms (list "*")))\r
+>    (split-string\r
+> @@ -199,7 +202,7 @@ the messages that were tagged"\r
+>     "\n+" t))\r
+>  \r
+>  (defun notmuch-select-tag-with-completion (prompt &rest search-terms)\r
+> -  (let ((tag-list (notmuch-tag-completions search-terms)))\r
+> +  (let ((tag-list (apply #'notmuch-tag-completions search-terms)))\r
+>      (completing-read prompt tag-list nil nil nil 'notmuch-select-tag-history)))\r
+>  \r
+>  (defun notmuch-read-tag-changes (current-tags &optional prompt initial-input)\r
+> diff --git a/emacs/notmuch.el b/emacs/notmuch.el\r
+> index 5492e1b..53e9826 100644\r
+> --- a/emacs/notmuch.el\r
+> +++ b/emacs/notmuch.el\r
+> @@ -584,7 +584,10 @@ Returns (TAG-CHANGES REGION-BEGIN REGION-END)."\r
+>    "Change tags for the currently selected thread or region.\r
+>  \r
+>  See `notmuch-tag' for information on the format of TAG-CHANGES.\r
+> -If BEG or END are nil, applies to the thread at point."\r
+> +When called interactively, this uses the region if the region is\r
+> +active.  When called directly, BEG and END provide the region.\r
+> +If these are nil or not provided, this applies to the thread at\r
+> +point."\r
+>    (interactive (notmuch-search-interactive-tag-changes))\r
+>    (unless (and beg end) (setq beg (point) end (point)))\r
+>    (let ((search-string (notmuch-search-find-thread-id-region-search beg end)))\r