--- /dev/null
+Return-Path: <amdragon@mit.edu>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by olra.theworths.org (Postfix) with ESMTP id A18B6431FB6\r
+ for <notmuch@notmuchmail.org>; Wed, 4 Jul 2012 14:00:36 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.7\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
+ tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
+Received: from olra.theworths.org ([127.0.0.1])\r
+ by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id 67SKNLFpig-z for <notmuch@notmuchmail.org>;\r
+ Wed, 4 Jul 2012 14:00:36 -0700 (PDT)\r
+Received: from dmz-mailsec-scanner-7.mit.edu (DMZ-MAILSEC-SCANNER-7.MIT.EDU\r
+ [18.7.68.36])\r
+ by olra.theworths.org (Postfix) with ESMTP id EEAFA431FAE\r
+ for <notmuch@notmuchmail.org>; Wed, 4 Jul 2012 14:00:35 -0700 (PDT)\r
+X-AuditID: 12074424-b7f2a6d0000008bf-fa-4ff4aef3cabd\r
+Received: from mailhub-auth-4.mit.edu ( [18.7.62.39])\r
+ by dmz-mailsec-scanner-7.mit.edu (Symantec Messaging Gateway) with SMTP\r
+ id 7E.6B.02239.3FEA4FF4; Wed, 4 Jul 2012 17:00:35 -0400 (EDT)\r
+Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
+ by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id q64L0YxJ021417; \r
+ Wed, 4 Jul 2012 17:00:34 -0400\r
+Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
+ (authenticated bits=0)\r
+ (User authenticated as amdragon@ATHENA.MIT.EDU)\r
+ by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q64L0UCX004684\r
+ (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
+ Wed, 4 Jul 2012 17:00:32 -0400 (EDT)\r
+Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
+ (envelope-from <amdragon@mit.edu>)\r
+ id 1SmWgY-0000o7-O0; Wed, 04 Jul 2012 17:00:30 -0400\r
+Date: Wed, 4 Jul 2012 17:00:30 -0400\r
+From: Austin Clements <amdragon@MIT.EDU>\r
+To: Mark Walters <markwalters1009@gmail.com>\r
+Subject: Re: [PATCH 1/8] emacs: Clean up notmuch-search-show-result\r
+Message-ID: <20120704210030.GE21653@mit.edu>\r
+References: <1341354059-29396-1-git-send-email-amdragon@mit.edu>\r
+ <1341354059-29396-2-git-send-email-amdragon@mit.edu>\r
+ <87ipe3fe3m.fsf@qmul.ac.uk>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain; charset=us-ascii\r
+Content-Disposition: inline\r
+In-Reply-To: <87ipe3fe3m.fsf@qmul.ac.uk>\r
+User-Agent: Mutt/1.5.21 (2010-09-15)\r
+X-Brightmail-Tracker:\r
+ H4sIAAAAAAAAA01SbUgTYRzv2d22Z2tXt1Pb09SgQ0mkTQUjCbXMRL/Ewo+V5Omubbmdspvi\r
+ 9klR8gWCVQptkS5tDCcqJEhSaU17WZQlgq8lBBJkpmEWVCDdbb59+/2f39vzBjHKI9VCC+dg\r
+ 7RxjpWVKnJLnHtP97N8wpPdOUVm991RZM3MeLGulp0N6Bisa9n6SF439uo8XfQnOYxewi8ps\r
+ I2u11LD2tNxSpXl9Pqbqe2Kte3RTVgc+alqBAiIyE7WsdoAoPoQ+LA7IWoESUuQIQNMv/ZLo\r
+ MABQ4Hb3FvNagjoH1+TR4QFAN9YaZaIfJ5PQQqAbE7GMTEFDo4FIbix5HC2EfHIRY2Qa6gl7\r
+ IpoYMh9NNQdxEROCZuJf/VZdO0C/g0+kUUKNwp4lPGpORbObXwURFHA8CmxCcVkhdLlD7khm\r
+ nLCHtvCQzA0o7x63d4/bu+v2ASwIEo02l87GWKw8W67jyxmOY+26k3qbxaFnjdUPQeTWzyU9\r
+ Ag0hOgRICGgVkWHbMFBSpoZ32kLgMJTQccSpPmHpQFml0WlmePMVe7WV5UMAQYyOJaBH4Agj\r
+ 43Sx9sptKh7itIaYMc4ZKNLEONgKlq1i7dtsAoQ0IiqEl6bUdtbE1l61WB27tAQqxHCVEH5N\r
+ LCb4KsbGW0xR/g3Qwf6V8VlA4Vwlx2o1hEMMIkWRuZrbydn+UctAIxwrhjgvqlTCf9tJWhZK\r
+ JEIJ170uljiYXUpbB4rL/vTpOzpf6emD9c+WSv6m3kwuaJroyUn29Dj96y5Dy4m8H7eeNk82\r
+ DE/nJGe66c9HC8MFxbMmzdT7Qfh2KNxVe10xfDnBd9e3Os6UTqsf55/mm9q0wfZGwr/44nn6\r
+ yILmW54p21Aydqlrn7qwUflOmlLR5jrrn1yT778DjtA4b2YyUjE7z/wHfP1vLiwDAAA=\r
+Cc: tomi.ollila@iki.fi, notmuch@notmuchmail.org\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.13\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Wed, 04 Jul 2012 21:00:36 -0000\r
+\r
+Quoth Mark Walters on Jul 04 at 9:47 pm:\r
+> On Tue, 03 Jul 2012, Austin Clements <amdragon@MIT.EDU> wrote:\r
+> > This simplifies the code and makes it no longer cubic in the number of\r
+> > result fields.\r
+> > ---\r
+> > emacs/notmuch.el | 20 ++++++++++----------\r
+> > 1 file changed, 10 insertions(+), 10 deletions(-)\r
+> >\r
+> > diff --git a/emacs/notmuch.el b/emacs/notmuch.el\r
+> > index c6236db..be217a2 100644\r
+> > --- a/emacs/notmuch.el\r
+> > +++ b/emacs/notmuch.el\r
+> > @@ -707,29 +707,29 @@ non-authors is found, assume that all of the authors match."\r
+> > (overlay-put overlay 'isearch-open-invisible #'delete-overlay)))\r
+> > (insert padding))))\r
+> > \r
+> > -(defun notmuch-search-insert-field (field date count authors subject tags)\r
+> > +(defun notmuch-search-insert-field (field format date count authors subject tags)\r
+> > (cond\r
+> > ((string-equal field "date")\r
+> > - (insert (propertize (format (cdr (assoc field notmuch-search-result-format)) date)\r
+> > + (insert (propertize (format format date)\r
+> > 'face 'notmuch-search-date)))\r
+> > ((string-equal field "count")\r
+> > - (insert (propertize (format (cdr (assoc field notmuch-search-result-format)) count)\r
+> > + (insert (propertize (format format count)\r
+> > 'face 'notmuch-search-count)))\r
+> > ((string-equal field "subject")\r
+> > - (insert (propertize (format (cdr (assoc field notmuch-search-result-format)) subject)\r
+> > + (insert (propertize (format format subject)\r
+> > 'face 'notmuch-search-subject)))\r
+> > \r
+> > ((string-equal field "authors")\r
+> > - (notmuch-search-insert-authors (cdr (assoc field notmuch-search-result-format)) authors))\r
+> > + (notmuch-search-insert-authors format authors))\r
+> > \r
+> > ((string-equal field "tags")\r
+> > - (insert (concat "(" (propertize tags 'font-lock-face 'notmuch-tag-face) ")")))))\r
+> > + (insert\r
+> > + (format format (propertize tags 'font-lock-face 'notmuch-tag-face))))))\r
+> \r
+> Am I missing something or did the search result line previously ignore\r
+> the user's specification for tags and automatically print it with inside\r
+> ()? Now this change does actually obey the user's specification.\r
+> \r
+> In principle that is a good thing, but the tag update code (when\r
+> changing a tag on a message) seems to rely on the brackets to find\r
+> something and errors out if the user format does not have any\r
+> brackets. (The code has things like "(re-search-backward "(")" in it).\r
+\r
+Mm, that's a good point. For now I should probably just revert the\r
+code to ignoring the user's format specification. A better solution\r
+would be to remember the result's plist and simply rebuild the whole\r
+line when the tags change, rather than trying to incrementally edit\r
+it.\r
+\r
+> Incidentally, patch 8 does change the format slightly by not padding the\r
+> the date field string itself and only printing it padded. This (very\r
+> mildly) breaks things if the user has customised\r
+> notmuch-search-result-format\r
+\r
+Yes, that's true. I could pad out the date to keep this backwards\r
+compatible, but since all of the other fields are variable width, I\r
+think I'd rather switch to the variable size date field and just\r
+mention this in the news.\r
+\r
+> Best wishes\r
+> \r
+> Mark\r
+> \r
+> \r
+> \r
+> > \r
+> > (defun notmuch-search-show-result (date count authors subject tags)\r
+> > - (let ((fields) (field))\r
+> > - (setq fields (mapcar 'car notmuch-search-result-format))\r
+> > - (loop for field in fields\r
+> > - do (notmuch-search-insert-field field date count authors subject tags)))\r
+> > + (dolist (format notmuch-search-result-format)\r
+> > + (notmuch-search-insert-field (car format) (cdr format)\r
+> > + date count authors subject tags))\r
+> > (insert "\n"))\r
+> > \r
+> > (defun notmuch-search-process-filter (proc string)\r
projects / notmuch-archives.git / commitdiff