config: make environment parsing routines static

Nobody outside of git_config_from_parameters should need
to use the GIT_CONFIG_PARAMETERS parsing functions, so let's
make them private.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/cache.h b/cache.h
index 123dd4bb93ebfd387a79bd6a4ccf012257a8b0b0..45bb36d17f384e6d1ec2233fbd8a25c49851ea3f 100644 (file)
--- a/cache.h
+++ b/cache.h
@@ -982,8 +982,6 @@ typedef int (*config_fn_t)(const char *, const char *, void *);
 extern int git_default_config(const char *, const char *, void *);
 extern int git_config_from_file(config_fn_t fn, const char *, void *);
 extern void git_config_push_parameter(const char *text);
-extern int git_config_parse_parameter(const char *text);
-extern int git_config_parse_environment(void);
 extern int git_config_from_parameters(config_fn_t fn, void *data);
 extern int git_config(config_fn_t fn, void *);
 extern int git_config_early(config_fn_t fn, void *, const char *repo_config);

diff --git a/config.c b/config.c
index c431f41c5a0d0645a53242e046350ff95a8b48f5..230fe2c0a2f779fd20ba1730349c0fc7bb0d1bef 100644 (file)
--- a/config.c
+++ b/config.c
@@ -48,7 +48,7 @@ void git_config_push_parameter(const char *text)
        strbuf_release(&env);
 }
 
-int git_config_parse_parameter(const char *text)
+static int git_config_parse_parameter(const char *text)
 {
        struct config_item *ct;
        struct strbuf tmp = STRBUF_INIT;
@@ -75,7 +75,7 @@ int git_config_parse_parameter(const char *text)
        return 0;
 }
 
-int git_config_parse_environment(void) {
+static int git_config_parse_environment(void) {
        const char *env = getenv(CONFIG_DATA_ENVIRONMENT);
        char *envw;
        const char **argv = NULL;