Sample update hook: typofix and modernization to use "git log"
authorAndy Parkins <andyparkins@gmail.com>
Fri, 2 Mar 2007 19:29:20 +0000 (19:29 +0000)
committerJunio C Hamano <junkio@cox.net>
Fri, 2 Mar 2007 23:06:25 +0000 (15:06 -0800)
Instead of using antiquated "git-rev-parse | git-rev-list"
pipeline, it is easier to use "git-rev-list" or "git-log" these
days, as Linus points out.

While we are at it, fix the typo on variable name $newref that
should be $newrev.

Signed-off-by: Andy Parkins <andyparkins@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
templates/hooks--update

index fd1f73d6aa48b104cc74d08dcb6a29bd3f8f08d9..4af2fe8d9517f3be1a6cb526a62d12e1f2c70915 100644 (file)
@@ -148,7 +148,7 @@ case "$refname_type" in
                        # This shows all log entries that are not already covered by
                        # another ref - i.e. commits that are now accessible from this
                        # ref that were previously not accessible
-                       git-rev-parse --not --all | git-rev-list --stdin --pretty $newref
+                       git log $newrev --not --all
                        echo $LOGEND
                else
                        # oldrev is valid
@@ -165,7 +165,7 @@ case "$refname_type" in
                        baserev=$(git-merge-base $oldrev $newrev)
 
                        # Commit with a parent
-                       for rev in $(git-rev-parse --not --all | git-rev-list --stdin $newrev ^$baserev)
+                       for rev in $(git-rev-list $newrev --not $baserev --all)
                        do
                                revtype=$(git-cat-file -t "$rev")
                                echo "       via  $rev ($revtype)"
@@ -190,12 +190,11 @@ case "$refname_type" in
                        fi
                        echo ""
                        echo $LOGBEGIN
-                       git-rev-parse --not --all |
-                       git-rev-list --stdin --pretty $newrev ^$baserev
+                       git log $newrev --not $baserev --all
                        echo $LOGEND
                        echo ""
                        echo "Diffstat:"
-                       git-diff-tree --no-color --stat -M -C --find-copies-harder $newrev ^$baserev
+                       git-diff-tree --no-color --stat -M -C --find-copies-harder $baserev..$newrev
                fi
                ;;
        "annotated tag")