Re: [PATCH v2 3/7] fix thread breakage via ghost-on-removal

diff --git a/71/89c0c11379fecdba3ad9a9fafc370062933a5a b/71/89c0c11379fecdba3ad9a9fafc370062933a5a
new file mode 100644 (file)
index 0000000..a7633dd
--- /dev/null
+++ b/71/89c0c11379fecdba3ad9a9fafc370062933a5a
@@ -0,0 +1,74 @@
+Return-Path: <david@tethera.net>\r
+X-Original-To: notmuch@notmuchmail.org\r
+Delivered-To: notmuch@notmuchmail.org\r
+Received: from localhost (localhost [127.0.0.1])\r
+ by arlo.cworth.org (Postfix) with ESMTP id 34FC46DE0243\r
+ for <notmuch@notmuchmail.org>; Tue,  5 Apr 2016 16:34:10 -0700 (PDT)\r
+X-Virus-Scanned: Debian amavisd-new at cworth.org\r
+X-Spam-Flag: NO\r
+X-Spam-Score: -0.02\r
+X-Spam-Level: \r
+X-Spam-Status: No, score=-0.02 tagged_above=-999 required=5 tests=[AWL=-0.009,\r
+  SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled\r
+Received: from arlo.cworth.org ([127.0.0.1])\r
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
+ with ESMTP id aAbfycJJAmQu for <notmuch@notmuchmail.org>;\r
+ Tue,  5 Apr 2016 16:34:02 -0700 (PDT)\r
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])\r
+ by arlo.cworth.org (Postfix) with ESMTPS id DD0FC6DE01F7\r
+ for <notmuch@notmuchmail.org>; Tue,  5 Apr 2016 16:34:01 -0700 (PDT)\r
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84)\r
+ (envelope-from <david@tethera.net>)\r
+ id 1anaUR-0003pI-4J; Tue, 05 Apr 2016 19:34:31 -0400\r
+Received: (nullmailer pid 9428 invoked by uid 1000);\r
+ Tue, 05 Apr 2016 23:33:55 -0000\r
+From: David Bremner <david@tethera.net>\r
+To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>,\r
+ Tomi Ollila <tomi.ollila@iki.fi>, Notmuch Mail <notmuch@notmuchmail.org>\r
+Subject: Re: [PATCH v2 3/7] fix thread breakage via ghost-on-removal\r
+In-Reply-To: <874mbfvn2l.fsf@alice.fifthhorseman.net>\r
+References: <1459445693-3900-1-git-send-email-dkg@fifthhorseman.net>\r
+ <1459606541-23889-1-git-send-email-dkg@fifthhorseman.net>\r
+ <1459606541-23889-3-git-send-email-dkg@fifthhorseman.net>\r
+ <m2lh4sczrl.fsf@guru.guru-group.fi> <874mbfvn2l.fsf@alice.fifthhorseman.net>\r
+User-Agent: Notmuch/0.21+74~g6c60fb1 (http://notmuchmail.org) Emacs/24.5.1\r
+ (x86_64-pc-linux-gnu)\r
+Date: Tue, 05 Apr 2016 20:33:55 -0300\r
+Message-ID: <8760vvhbq4.fsf@zancas.localnet>\r
+MIME-Version: 1.0\r
+Content-Type: text/plain\r
+X-BeenThere: notmuch@notmuchmail.org\r
+X-Mailman-Version: 2.1.20\r
+Precedence: list\r
+List-Id: "Use and development of the notmuch mail system."\r
+ <notmuch.notmuchmail.org>\r
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
+List-Post: <mailto:notmuch@notmuchmail.org>\r
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
+X-List-Received-Date: Tue, 05 Apr 2016 23:34:10 -0000\r
+\r
+Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:\r
+\r
+>>\r
+>> Outside of this patch, but in some of the next messages, adds functions\r
+>> _notmuch_message_has_term() and _notmuch_message_has_term_st(). Perhaps\r
+>> the _notmuch_message_has_term() could be left unimplemented?\r
+>\r
+> yeah, i can do that, though i have to say it's programmatically\r
+> convenient to have a simple boolean test that defaults to some value if\r
+> there was an error.\r
+\r
+Maybe this is obvious, but we rely heavily in the notmuch code base on\r
+NOTMUCH_STATUS_SUCCESS==0, so the following idiom is pretty common,\r
+\r
+      status = notmuch_status_returning_thing (... &out);\r
+      if (status) {\r
+         /* error path */\r
+      }\r
+\r
+      /* otherwise, deal with out */\r
+\r