doc/

2002-03-03  Marcus Brinkmann  <marcus@g10code.de>

	* gpgme.texi (Information About Keys): Document GPGME_ATTR_EXPIRE.

gpgme/
2002-03-03  Marcus Brinkmann  <marcus@g10code.de>

	* passphrase.c (_gpgme_passphrase_status_handler): Also set the
	error No_Passphrase if only a bad passphrase was provided.

diff --git a/NEWS b/NEWS
index ec9db4bd1ae9c3f5e6cc8a9dde50df8c00d37673..b406c499f2ade32025ca0a60833cfde6f9e30258 100644 (file)
--- a/NEWS
+++ b/NEWS
@@ -19,10 +19,13 @@
 
  * New interface gpgme_op_keylist_ext_start to search for multiple patterns.
 
+ * gpgme_key_get_ulong_attr supports the GPGME_ATTR_EXPIRE attribute.
+
  * Interface changes relative to the 0.3.3 release:
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 gpgme_op_encrypt               CHANGED: Can fail with GPGME_Invalid_Recipients
 gpgme_op_verify                        EXTENDED: Accepts uninitialized text argument
+gpgme_key_get_ulong_attr       EXTENDED: Supports GPGME_ATTR_EXPIRE
 gpgme_set_include_certs                NEW
 gpgme_get_include_certs                NEW
 gpgme_op_encrypt_sign          NEW

diff --git a/TODO b/TODO
index 8970c3995d95b769906763216710ab76d6b0c59e..0e1752c8921efc930e9f46db0fda9ade63a6e552 100644 (file)
--- a/TODO
+++ b/TODO
@@ -10,8 +10,6 @@ Hey Emacs, this is -*- outline -*- mode!
 
 * add locking to the key cache?
 
-* GpgmeKey misses GPGME_ATTR_EXPIRE attribute
-
 * Documentation
 ** Add note about GPGME clearing out pointer return values.
 ** validity/trust
@@ -38,10 +36,6 @@ Hey Emacs, this is -*- outline -*- mode!
 * Error Values
 ** Map ASSUAN/GpgSM ERR error values in a better way than is done now.
 ** Verify (and document) if Read_Error, Write_Error, Pipe_Error set errno.
-** "There is an inconsistent behaviour: if we pass three times an  
-   invalid (but non empty) passphrase, return code is GPGME_No_Data,
-   but if we pass three times an empty (and invalid) passphrase, we
-   get GPGME_No_Passphrase." Bug reported by Stephane Corthesy.
 
 * Tests
 ** Write a fake gpg-agent so that we can supply known passphrases to

diff --git a/doc/ChangeLog b/doc/ChangeLog
index 88d4fbf9d28c29141c9661d5838c830585ca2ca1..a4c733ea293a98e520b2b65fabfec1ec3723890a 100644 (file)
--- a/doc/ChangeLog
+++ b/doc/ChangeLog
@@ -1,3 +1,7 @@
+2002-03-03  Marcus Brinkmann  <marcus@g10code.de>
+
+       * gpgme.texi (Information About Keys): Document GPGME_ATTR_EXPIRE.
+
 2002-03-03  Marcus Brinkmann  <marcus@g10code.de>
 
        * gpgme.texi (Verify): Document verification of normal and

diff --git a/doc/gpgme.texi b/doc/gpgme.texi
index f691e50c262538ef9fb8defc7ba7bf3a427113de..fb3cbe3d732f9b3324a94ee62ed1badcb59b66b5 100644 (file)
--- a/doc/gpgme.texi
+++ b/doc/gpgme.texi
@@ -1358,7 +1358,8 @@ This is the timestamp at creation time of a sub key.  It is
 representable as a number.
 
 @item GPGME_ATTR_EXPIRE
-XXX FIXME
+This is the expiration time of a sub key.  It is representable as a
+number.
 
 @item GPGME_ATTR_OTRUST
 XXX FIXME  (also for trust items)

diff --git a/gpgme/ChangeLog b/gpgme/ChangeLog
index 1294c546c20363a5d6f8fb3f3c6c32a38a987c88..f2104c74ba61ba524970fb21124431c64a66bd20 100644 (file)
--- a/gpgme/ChangeLog
+++ b/gpgme/ChangeLog
@@ -1,3 +1,8 @@
+2002-03-03  Marcus Brinkmann  <marcus@g10code.de>
+
+       * passphrase.c (_gpgme_passphrase_status_handler): Also set the
+       error No_Passphrase if only a bad passphrase was provided.
+
 2002-03-03  Marcus Brinkmann  <marcus@g10code.de>
 
        * rungpg.c (_gpgme_gpg_op_verify): If TEXT is of mode

diff --git a/gpgme/passphrase.c b/gpgme/passphrase.c
index f6cf48d7c504f6457540b0f54e8f5e3e1e9b377a..6ba23bafce949c45e1a922a52940d626128506aa 100644 (file)
--- a/gpgme/passphrase.c
+++ b/gpgme/passphrase.c
@@ -88,7 +88,8 @@ _gpgme_passphrase_status_handler (GpgmeCtx ctx, GpgStatusCode code, char *args)
       break;
 
     case STATUS_EOF:
-      if (ctx->result.passphrase->no_passphrase)
+      if (ctx->result.passphrase->no_passphrase
+         || ctx->result.passphrase->bad_passphrase)
        ctx->error = mk_error (No_Passphrase);
       break;